[jira] Commented: (OFBIZ-1365) improve get method of GenericEntity class

["Adam Heath (JIRA)" <ji...@apache.org>]

    [ https://issues.apache.org/jira/browse/OFBIZ-1365?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel#action_12537432 ] 

Adam Heath commented on OFBIZ-1365:
-----------------------------------

What is this good for?  What error do you get?  Please tell us why this change is needed; I don't understand from just reading the the comment.

> improve get method of GenericEntity class
> -----------------------------------------
>
>                 Key: OFBIZ-1365
>                 URL: https://issues.apache.org/jira/browse/OFBIZ-1365
>             Project: OFBiz
>          Issue Type: Improvement
>    Affects Versions: SVN trunk
>         Environment: Windows XP Profissional, on intel pentium 4.
>            Reporter: marcio
>            Priority: Critical
>             Fix For: SVN trunk
>
>
> the orignal method is: 
>     public Object get(String name) {
>         if (getModelEntity().getField(name) == null) {
>             throw new IllegalArgumentException("[GenericEntity.get] \"" + name + "\" is not a field of " + entityName);
>         }
>         return fields.get(name);
>     }
> the improve: 
>     public Object get(String name) {
> 	if (fields != null) {
> 	    if (fields.get(name) != null) {
> 		return fields.get(name);
> 	    }
> 	}
>         if (getModelEntity().getField(name) == null) {
>             throw new IllegalArgumentException("[GenericEntity.get] \"" + name + "\" is not a field of " + entityName);
>         }
>         return fields.get(name);
>     }
> this solve my error when i get list of GenericEntity on RMI call .
> i hope this help and improve ofbiz.

-- 
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.