You are viewing a plain text version of this content. The canonical link for it is here.
Posted to commits@airflow.apache.org by "shubhamraj-git (via GitHub)" <gi...@apache.org> on 2026/05/02 15:12:37 UTC
[PR] Fix the multi type render for aparams [airflow]
shubhamraj-git opened a new pull request, #66278:
URL: https://github.com/apache/airflow/pull/66278
Before -
Type of params -
run_area : ["integer", "string"]
pipelines : ["string", "object"]
but the UI render marks run_area as integer and pipelines as string
<img width="677" height="593" alt="image" src="https://github.com/user-attachments/assets/30f7d557-7ccb-4669-b862-b7331cf935a6" />
After -
<img width="1308" height="1250" alt="image" src="https://github.com/user-attachments/assets/d834152c-8d2b-49e5-8488-e855d64cecc2" />
<!-- SPDX-License-Identifier: Apache-2.0
https://www.apache.org/licenses/LICENSE-2.0 -->
<!--
Thank you for contributing!
Please provide above a brief description of the changes made in this pull request.
Write a good git commit message following this guide: http://chris.beams.io/posts/git-commit/
Please make sure that your code changes are covered with tests.
And in case of new features or big changes remember to adjust the documentation.
Feel free to ping (in general) for the review if you do not see reaction for a few days
(72 Hours is the minimum reaction time you can expect from volunteers) - we sometimes miss notifications.
In case of an existing issue, reference it using one of the following:
* closes: #ISSUE
* related: #ISSUE
-->
---
##### Was generative AI tooling used to co-author this PR?
<!--
If generative AI tooling has been used in the process of authoring this PR, please
change below checkbox to `[X]` followed by the name of the tool, uncomment the "Generated-by".
-->
- [x] Yes (Claude Code Sonnet 4.6)
<!--
Generated-by: [Tool Name] following [the guidelines](https://github.com/apache/airflow/blob/main/contributing-docs/05_pull_requests.rst#gen-ai-assisted-contributions)
-->
---
* Read the **[Pull Request Guidelines](https://github.com/apache/airflow/blob/main/contributing-docs/05_pull_requests.rst#pull-request-guidelines)** for more information. Note: commit author/co-author name and email in commits become permanently public when merged.
* For fundamental code changes, an Airflow Improvement Proposal ([AIP](https://cwiki.apache.org/confluence/display/AIRFLOW/Airflow+Improvement+Proposals)) is needed.
* When adding dependency, check compliance with the [ASF 3rd Party License Policy](https://www.apache.org/legal/resolved.html#category-x).
* For significant user-facing changes create newsfragment: `{pr_number}.significant.rst`, in [airflow-core/newsfragments](https://github.com/apache/airflow/tree/main/airflow-core/newsfragments). You can add this file in a follow-up commit after the PR is created so you know the PR number.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@airflow.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
Re: [PR] Fix the multi type render for params [airflow]
Posted by "eladkal (via GitHub)" <gi...@apache.org>.
eladkal commented on PR #66278:
URL: https://github.com/apache/airflow/pull/66278#issuecomment-4476028146
> For me feels a bit like anew feature. Sure you want to back-port to 3.2.2? I assume would be better in 3.3.0
Then probably best to amend commit message to describe it better
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@airflow.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
Re: [PR] Fix the multi type render for params [airflow]
Posted by "jscheffl (via GitHub)" <gi...@apache.org>.
jscheffl commented on PR #66278:
URL: https://github.com/apache/airflow/pull/66278#issuecomment-4472455464
For me feels a bit like anew feature. Sure you want to back-port to 3.2.2? I assume would be better in 3.3.0
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@airflow.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
Re: [PR] Add UI support to render multi-type params [airflow]
Posted by "shubhamraj-git (via GitHub)" <gi...@apache.org>.
shubhamraj-git merged PR #66278:
URL: https://github.com/apache/airflow/pull/66278
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@airflow.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
Re: [PR] Fix the multi type render for params [airflow]
Posted by "vatsrahul1001 (via GitHub)" <gi...@apache.org>.
vatsrahul1001 commented on PR #66278:
URL: https://github.com/apache/airflow/pull/66278#issuecomment-4474328618
Yeah better with 3.3.0
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@airflow.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
Re: [PR] Fix the multi type render for params [airflow]
Posted by "jscheffl (via GitHub)" <gi...@apache.org>.
jscheffl commented on PR #66278:
URL: https://github.com/apache/airflow/pull/66278#issuecomment-4364194719
> @jscheffl I just pushed a commit, can you recheck again, it will infer type from provided value - for example - 45 as input in UI will be taken as "45" in case of ["string", "object"]
Yeah. That is a bit better. Still can you add some RST as documentation so that people know about it (and potential limitations that come in your mind). Also as the logic might be prone to regressions, can you make a unit test for mapping with some "supported" examples?
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@airflow.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
Re: [PR] Fix the multi type render for params [airflow]
Posted by "shubhamraj-git (via GitHub)" <gi...@apache.org>.
shubhamraj-git commented on code in PR #66278:
URL: https://github.com/apache/airflow/pull/66278#discussion_r3255435571
##########
airflow-core/src/airflow/example_dags/example_multi_type_params.py:
##########
Review Comment:
Sure, I thought anyways we will be refactoring all the examples so added a new one, but that might take some time, I refactored it, Sorry for the long wait
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@airflow.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
Re: [PR] Fix the multi type render for params [airflow]
Posted by "shubhamraj-git (via GitHub)" <gi...@apache.org>.
shubhamraj-git commented on PR #66278:
URL: https://github.com/apache/airflow/pull/66278#issuecomment-4364183330
@jscheffl I just pushed a commit, can you recheck again, it will infer type from provided value - for example - 45 as input in UI will be taken as "45" in case of ["string", "object"]
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@airflow.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
Re: [PR] Fix the multi type render for params [airflow]
Posted by "shubhamraj-git (via GitHub)" <gi...@apache.org>.
shubhamraj-git commented on code in PR #66278:
URL: https://github.com/apache/airflow/pull/66278#discussion_r3178530172
##########
airflow-core/docs/core-concepts/params.rst:
##########
@@ -341,7 +341,43 @@ The following features are supported in the Trigger UI Form:
-
- ``Param(None, type=["null", "string"])``
-- If a form field is left empty, it is passed as ``None`` value to the params dict.
Review Comment:
Opps, yes. Let me add it back.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@airflow.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
Re: [PR] Fix the multi type render for params [airflow]
Posted by "jscheffl (via GitHub)" <gi...@apache.org>.
jscheffl commented on code in PR #66278:
URL: https://github.com/apache/airflow/pull/66278#discussion_r3178494183
##########
airflow-core/docs/core-concepts/params.rst:
##########
@@ -341,7 +341,43 @@ The following features are supported in the Trigger UI Form:
-
- ``Param(None, type=["null", "string"])``
-- If a form field is left empty, it is passed as ``None`` value to the params dict.
Review Comment:
This still holds true? Else it would be a breaking change. I assume the line was removed by accident?
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@airflow.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
Re: [PR] Fix the multi type render for params [airflow]
Posted by "shubhamraj-git (via GitHub)" <gi...@apache.org>.
shubhamraj-git commented on PR #66278:
URL: https://github.com/apache/airflow/pull/66278#issuecomment-4368338473
> Would it make sense to add one demo to airflow-core/src/airflow/example_dags/example_params_ui_tutorial.py ?
Added a new example which have multiple multi-type examples
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@airflow.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
Re: [PR] Fix the multi type render for params [airflow]
Posted by "jscheffl (via GitHub)" <gi...@apache.org>.
jscheffl commented on code in PR #66278:
URL: https://github.com/apache/airflow/pull/66278#discussion_r3190681123
##########
airflow-core/src/airflow/example_dags/example_multi_type_params.py:
##########
Review Comment:
Thanks for adding an example. But oh, we already have soo many and this is overwhelming adding one more. Can you add a new section in `example_params_ui_tutorial.py` which attempts to collect a lot of options already?
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@airflow.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org