[GitHub] [iceberg] rdblue commented on a change in pull request #2276: Spark: Add option to combine tasks by partition

[GitBox <gi...@apache.org>]

rdblue commented on a change in pull request #2276:
URL: https://github.com/apache/iceberg/pull/2276#discussion_r587681999



##########
File path: api/src/main/java/org/apache/iceberg/FileScanTask.java
##########
@@ -47,6 +47,13 @@
    */
   PartitionSpec spec();
 
+  /**
+   * The partition data for the file of this task.

Review comment:
       What does this return if there is no partition?
   
   I think that we should consider adding a struct type that describes this tuple. That way, we can use an empty struct for unpartitioned and a non-empty struct for tasks that are combined by partition. We could also support more combinations, like combining across day partitions by not across bucket partitions or similar.




----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org



---------------------------------------------------------------------
To unsubscribe, e-mail: issues-unsubscribe@iceberg.apache.org
For additional commands, e-mail: issues-help@iceberg.apache.org