You are viewing a plain text version of this content. The canonical link for it is here.
Posted to commits@fineract.apache.org by GitBox <gi...@apache.org> on 2021/03/15 08:28:27 UTC
[GitHub] [fineract-cn-mobile] PatelVatsalB21 opened a new pull request #130: Fix-263: Notification error fixed in JobsReceiver
PatelVatsalB21 opened a new pull request #130:
URL: https://github.com/apache/fineract-cn-mobile/pull/130
Fixes FINCN-263
Now notification just closes on click as it has no purpose to open Dashboard which might create a security threat.
**Error**
https://user-images.githubusercontent.com/70195106/111123794-c49a4d00-8595-11eb-9032-468d5f894f73.mp4
**Solution**
https://user-images.githubusercontent.com/70195106/111123958-f1e6fb00-8595-11eb-90cd-b4f4f5641bb0.mp4
- [x] Apply the `AndroidStyle.xml` style template to your code in Android Studio.
- [x] Run the unit tests with `./gradlew check` to make sure you didn't break anything.
- [x] If you have multiple commits please combine them into one commit by squashing them.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [fineract-cn-mobile] varsvat commented on pull request #130: Fix-263: Notification error fixed in JobsReceiver
Posted by GitBox <gi...@apache.org>.
varsvat commented on pull request #130:
URL: https://github.com/apache/fineract-cn-mobile/pull/130#issuecomment-799330175
> eo for error if you login notification will be visible but don't touch it then logout and turn of internet and on login screen click on notification you will find it. I always confirm 2-3 time an error before posting and don'
It is quite strange but I don't get any notif while logging in :/
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [fineract-cn-mobile] PatelVatsalB21 commented on pull request #130: Fix-263: Notification error fixed in JobsReceiver
Posted by GitBox <gi...@apache.org>.
PatelVatsalB21 commented on pull request #130:
URL: https://github.com/apache/fineract-cn-mobile/pull/130#issuecomment-799336185
@varsvat we have JobReciever for notification. I am getting notification after every time logged in and when on Dashboard as visible in error video. Please check your notification settings for fineract if that the case.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [fineract-cn-mobile] PatelVatsalB21 commented on pull request #130: Fix-263: Notification error fixed in JobsReceiver
Posted by GitBox <gi...@apache.org>.
PatelVatsalB21 commented on pull request #130:
URL: https://github.com/apache/fineract-cn-mobile/pull/130#issuecomment-799316580
@varsvat as attached in video for error if you login notification will be visible but don't touch it then logout and turn of internet and on login screen click on notification you will find it. I always confirm 2-3 time an error before posting and don't be afraid it has just removed intent to dashboard which has no significance as if you would notice, if click notification it would open dashboard with again notification. It is recursion. Hence this pr removes 2 bugs.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [fineract-cn-mobile] PatelVatsalB21 commented on pull request #130: Fix-263: Notification error fixed in JobsReceiver
Posted by GitBox <gi...@apache.org>.
PatelVatsalB21 commented on pull request #130:
URL: https://github.com/apache/fineract-cn-mobile/pull/130#issuecomment-799345044
@varsvat can you approve it is still shows your changes requested symbol.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [fineract-cn-mobile] varsvat commented on pull request #130: Fix-263: Notification error fixed in JobsReceiver
Posted by GitBox <gi...@apache.org>.
varsvat commented on pull request #130:
URL: https://github.com/apache/fineract-cn-mobile/pull/130#issuecomment-799337732
okay
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org