You are viewing a plain text version of this content. The canonical link for it is here.
Posted to dev@orc.apache.org by GitBox <gi...@apache.org> on 2021/07/09 16:46:48 UTC
[GitHub] [orc] belugabehr opened a new pull request #745: ORC-841: Remove Superfluous Array Fill in StringHashTableDictionary
belugabehr opened a new pull request #745:
URL: https://github.com/apache/orc/pull/745
### What changes were proposed in this pull request?
Remove Superfluous Array Fill in StringHashTableDictionary. Java GC will take care of this.
### Why are the changes needed?
Less code. Performance.
### How was this patch tested?
No changes to functionality. Uses existing unit tests.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: dev-unsubscribe@orc.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [orc] pgaref commented on pull request #745: ORC-841: Remove Superfluous Array Fill in StringHashTableDictionary
Posted by GitBox <gi...@apache.org>.
pgaref commented on pull request #745:
URL: https://github.com/apache/orc/pull/745#issuecomment-885541916
Late LGTM ! Thanks all !
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: dev-unsubscribe@orc.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [orc] dongjoon-hyun commented on pull request #745: ORC-841: Remove Superfluous Array Fill in StringHashTableDictionary
Posted by GitBox <gi...@apache.org>.
dongjoon-hyun commented on pull request #745:
URL: https://github.com/apache/orc/pull/745#issuecomment-885223155
Thank you, @belugabehr and @williamhyun .
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: dev-unsubscribe@orc.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [orc] asfgit closed pull request #745: ORC-841: Remove Superfluous Array Fill in StringHashTableDictionary
Posted by GitBox <gi...@apache.org>.
asfgit closed pull request #745:
URL: https://github.com/apache/orc/pull/745
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: dev-unsubscribe@orc.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [orc] williamhyun commented on pull request #745: ORC-841: Remove Superfluous Array Fill in StringHashTableDictionary
Posted by GitBox <gi...@apache.org>.
williamhyun commented on pull request #745:
URL: https://github.com/apache/orc/pull/745#issuecomment-885221454
cc: @dongjoon-hyun and @pgaref
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: dev-unsubscribe@orc.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org