[jira] [Work logged] (GOBBLIN-2169) Fix NPE in overwritePartition and getPartitionSpecificDataFiles

["ASF GitHub Bot (Jira)" <ji...@apache.org>]

     [ https://issues.apache.org/jira/browse/GOBBLIN-2169?focusedWorklogId=941603&page=com.atlassian.jira.plugin.system.issuetabpanels:worklog-tabpanel#worklog-941603 ]

ASF GitHub Bot logged work on GOBBLIN-2169:
-------------------------------------------

                Author: ASF GitHub Bot
            Created on: 04/Nov/24 04:50
            Start Date: 04/Nov/24 04:50
    Worklog Time Spent: 10m 
      Work Description: Blazer-007 commented on code in PR #4071:
URL: https://github.com/apache/gobblin/pull/4071#discussion_r1827188133


##########
gobblin-data-management/src/main/java/org/apache/gobblin/data/management/copy/iceberg/IcebergTable.java:
##########
@@ -234,8 +234,7 @@ protected void registerIcebergTable(TableMetadata srcMetadata, TableMetadata dst
    *
    * @param icebergPartitionFilterPredicate the predicate to filter partitions
    * @return a list of data files that match the partition filter predicate
-   * @throws TableNotFoundException if error occurred while accessing the table metadata
-   * @throws RuntimeException if error occurred while reading the manifest file
+   * @throws IOException if error occurred while accessing the table metadata or reading the manifest file
    */
   public List<DataFile> getPartitionSpecificDataFiles(Predicate<StructLike> icebergPartitionFilterPredicate)
       throws IOException {

Review Comment:
   #4073 





Issue Time Tracking
-------------------

    Worklog Id:     (was: 941603)
    Time Spent: 40m  (was: 0.5h)

> Fix NPE in overwritePartition and getPartitionSpecificDataFiles
> ---------------------------------------------------------------
>
>                 Key: GOBBLIN-2169
>                 URL: https://issues.apache.org/jira/browse/GOBBLIN-2169
>             Project: Apache Gobblin
>          Issue Type: Bug
>            Reporter: Vivek Rai
>            Priority: Major
>          Time Spent: 40m
>  Remaining Estimate: 0h
>
> While overwrite we log the snapshot id of last snapshot present before commit, incase table has no previous snapshot it will give NPE
> Line giving NPE - 
> {code:java}
> log.info("~{}~ SnapshotId before overwrite: {}", tableId, accessTableMetadata().currentSnapshot().snapshotId());{code}



--
This message was sent by Atlassian Jira
(v8.20.10#820010)