[GitHub] [tomcat] oopexpert edited a comment on issue #242: get a hands on ...

[GitBox <gi...@apache.org>]

oopexpert edited a comment on issue #242: get a hands on ...
URL: https://github.com/apache/tomcat/pull/242#issuecomment-586561346
 
 
   I do understand that there are some prequistes that I did not consider according to the Java 8 deps. It would be helpful to get a hint what kind of line of code does violate it.
   
   I also agree that performance might decrease a little bit. But you have to admit: Reflection in general is not fast at all. And as you also said: Here performance does not really matter.
   
   But what I do not understand is: what do you mean with excessive? According to my motivation: I like CleanCode an I wanted to help to improve the code base. Never thought to justify for that anywhere...
   
   Nevertheless. Thank you for the the fast feedback. Could we at least have one more iteration where you see the problem with java deps?

----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
users@infra.apache.org


With regards,
Apache Git Services

---------------------------------------------------------------------
To unsubscribe, e-mail: dev-unsubscribe@tomcat.apache.org
For additional commands, e-mail: dev-help@tomcat.apache.org