You are viewing a plain text version of this content. The canonical link for it is here.
Posted to reviews@aurora.apache.org by Brian Brazil <br...@boxever.com> on 2015/07/08 14:53:47 UTC
Review Request 36305: Remove restriction that -hostname must resolve.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/36305/
-----------------------------------------------------------
Review request for Aurora, Stephan Erb and Bill Farner.
Repository: aurora
Description
-------
There's valid configuration where the hostname
visibile in the browser won't exist in DNS, and
mesos master/slave's equivilent settings don't
have this restriction.
Leave as a warning, as for most users this is a misconfiguration.
Diffs
-----
src/main/java/org/apache/aurora/scheduler/http/JettyServerModule.java b4701295922ddad44d9d5c9fa29eb95e195e1604
Diff: https://reviews.apache.org/r/36305/diff/
Testing
-------
Verified in Vagrant environment.
Thanks,
Brian Brazil
Re: Review Request 36305: Remove restriction that -hostname must
resolve.
Posted by Aurora ReviewBot <wf...@apache.org>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/36305/#review91260
-----------------------------------------------------------
Master (4a4b11c) is green with this patch.
./build-support/jenkins/build.sh
However, it appears that it might lack test coverage.
I will refresh this build result if you post a review containing "@ReviewBot retry"
- Aurora ReviewBot
On July 9, 2015, 10:14 a.m., Brian Brazil wrote:
>
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/36305/
> -----------------------------------------------------------
>
> (Updated July 9, 2015, 10:14 a.m.)
>
>
> Review request for Aurora, Stephan Erb and Bill Farner.
>
>
> Repository: aurora
>
>
> Description
> -------
>
> There's valid configuration where the hostname
> visibile in the browser won't exist in DNS, and
> mesos master/slave's equivilent settings don't
> have this restriction.
>
> Leave as a warning, as for most users this is a misconfiguration.
>
>
> Diffs
> -----
>
> src/main/java/org/apache/aurora/scheduler/http/JettyServerModule.java b4701295922ddad44d9d5c9fa29eb95e195e1604
>
> Diff: https://reviews.apache.org/r/36305/diff/
>
>
> Testing
> -------
>
> Verified in Vagrant environment.
>
>
> Thanks,
>
> Brian Brazil
>
>
Re: Review Request 36305: Remove restriction that -hostname must
resolve.
Posted by Bill Farner <wf...@apache.org>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/36305/#review91258
-----------------------------------------------------------
@ReviewBot retry
- Bill Farner
On July 9, 2015, 10:14 a.m., Brian Brazil wrote:
>
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/36305/
> -----------------------------------------------------------
>
> (Updated July 9, 2015, 10:14 a.m.)
>
>
> Review request for Aurora, Stephan Erb and Bill Farner.
>
>
> Repository: aurora
>
>
> Description
> -------
>
> There's valid configuration where the hostname
> visibile in the browser won't exist in DNS, and
> mesos master/slave's equivilent settings don't
> have this restriction.
>
> Leave as a warning, as for most users this is a misconfiguration.
>
>
> Diffs
> -----
>
> src/main/java/org/apache/aurora/scheduler/http/JettyServerModule.java b4701295922ddad44d9d5c9fa29eb95e195e1604
>
> Diff: https://reviews.apache.org/r/36305/diff/
>
>
> Testing
> -------
>
> Verified in Vagrant environment.
>
>
> Thanks,
>
> Brian Brazil
>
>
Re: Review Request 36305: Remove restriction that -hostname must
resolve.
Posted by Aurora ReviewBot <wf...@apache.org>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/36305/#review91083
-----------------------------------------------------------
Master (8efcd06) is red with this patch.
./build-support/jenkins/build.sh
src.test.python.apache.aurora.client.cli.plugins ..... SUCCESS
src.test.python.apache.aurora.client.cli.quota ..... SUCCESS
src.test.python.apache.aurora.client.cli.sla ..... SUCCESS
src.test.python.apache.aurora.client.cli.supdate ..... SUCCESS
src.test.python.apache.aurora.client.cli.task ..... SUCCESS
src.test.python.apache.aurora.client.cli.update ..... SUCCESS
src.test.python.apache.aurora.client.cli.version ..... SUCCESS
src.test.python.apache.aurora.client.config ..... SUCCESS
src.test.python.apache.aurora.client.hooks.hooked_api ..... SUCCESS
src.test.python.apache.aurora.client.hooks.non_hooked_api ..... SUCCESS
src.test.python.apache.aurora.common.test_aurora_job_key ..... SUCCESS
src.test.python.apache.aurora.common.test_cluster ..... SUCCESS
src.test.python.apache.aurora.common.test_cluster_option ..... SUCCESS
src.test.python.apache.aurora.common.test_clusters ..... SUCCESS
src.test.python.apache.aurora.common.test_http_signaler ..... SUCCESS
src.test.python.apache.aurora.common.test_pex_version ..... SUCCESS
src.test.python.apache.aurora.common.test_shellify ..... SUCCESS
src.test.python.apache.aurora.common.test_transport ..... SUCCESS
src.test.python.apache.aurora.config.test_base ..... SUCCESS
src.test.python.apache.aurora.config.test_constraint_parsing ..... SUCCESS
src.test.python.apache.aurora.config.test_loader ..... SUCCESS
src.test.python.apache.aurora.config.test_thrift ..... SUCCESS
src.test.python.apache.aurora.executor.common.path_detector ..... SUCCESS
src.test.python.apache.aurora.executor.common.task_info ..... SUCCESS
src.test.python.apache.aurora.executor.executor_base ..... SUCCESS
src.test.python.apache.aurora.executor.executor_vars ..... SUCCESS
src.test.python.apache.aurora.executor.http_lifecycle ..... SUCCESS
src.test.python.apache.aurora.executor.status_manager ..... SUCCESS
src.test.python.apache.aurora.executor.thermos_task_runner ..... FAILURE
src.test.python.apache.thermos.cli.commands.commands ..... SUCCESS
src.test.python.apache.thermos.cli.common ..... SUCCESS
src.test.python.apache.thermos.cli.main ..... SUCCESS
src.test.python.apache.thermos.common.test_pathspec ..... SUCCESS
src.test.python.apache.thermos.core.test_runner_integration ..... SUCCESS
src.test.python.apache.thermos.monitoring.test_disk ..... SUCCESS
FAILURE
[31m
FAILURE[0m
I will refresh this build result if you post a review containing "@ReviewBot retry"
- Aurora ReviewBot
On July 9, 2015, 10:14 a.m., Brian Brazil wrote:
>
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/36305/
> -----------------------------------------------------------
>
> (Updated July 9, 2015, 10:14 a.m.)
>
>
> Review request for Aurora, Stephan Erb and Bill Farner.
>
>
> Repository: aurora
>
>
> Description
> -------
>
> There's valid configuration where the hostname
> visibile in the browser won't exist in DNS, and
> mesos master/slave's equivilent settings don't
> have this restriction.
>
> Leave as a warning, as for most users this is a misconfiguration.
>
>
> Diffs
> -----
>
> src/main/java/org/apache/aurora/scheduler/http/JettyServerModule.java b4701295922ddad44d9d5c9fa29eb95e195e1604
>
> Diff: https://reviews.apache.org/r/36305/diff/
>
>
> Testing
> -------
>
> Verified in Vagrant environment.
>
>
> Thanks,
>
> Brian Brazil
>
>
Re: Review Request 36305: Remove restriction that -hostname must
resolve.
Posted by Brian Brazil <br...@boxever.com>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/36305/
-----------------------------------------------------------
(Updated July 9, 2015, 10:14 a.m.)
Review request for Aurora, Stephan Erb and Bill Farner.
Changes
-------
Improved log message.
Repository: aurora
Description
-------
There's valid configuration where the hostname
visibile in the browser won't exist in DNS, and
mesos master/slave's equivilent settings don't
have this restriction.
Leave as a warning, as for most users this is a misconfiguration.
Diffs (updated)
-----
src/main/java/org/apache/aurora/scheduler/http/JettyServerModule.java b4701295922ddad44d9d5c9fa29eb95e195e1604
Diff: https://reviews.apache.org/r/36305/diff/
Testing
-------
Verified in Vagrant environment.
Thanks,
Brian Brazil
Re: Review Request 36305: Remove restriction that -hostname must
resolve.
Posted by Stephan Erb <st...@dev.static-void.de>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/36305/#review90989
-----------------------------------------------------------
Ship it!
Ship It!
- Stephan Erb
On July 8, 2015, 2:53 p.m., Brian Brazil wrote:
>
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/36305/
> -----------------------------------------------------------
>
> (Updated July 8, 2015, 2:53 p.m.)
>
>
> Review request for Aurora, Stephan Erb and Bill Farner.
>
>
> Repository: aurora
>
>
> Description
> -------
>
> There's valid configuration where the hostname
> visibile in the browser won't exist in DNS, and
> mesos master/slave's equivilent settings don't
> have this restriction.
>
> Leave as a warning, as for most users this is a misconfiguration.
>
>
> Diffs
> -----
>
> src/main/java/org/apache/aurora/scheduler/http/JettyServerModule.java b4701295922ddad44d9d5c9fa29eb95e195e1604
>
> Diff: https://reviews.apache.org/r/36305/diff/
>
>
> Testing
> -------
>
> Verified in Vagrant environment.
>
>
> Thanks,
>
> Brian Brazil
>
>
Re: Review Request 36305: Remove restriction that -hostname must
resolve.
Posted by Aurora ReviewBot <wf...@apache.org>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/36305/#review90888
-----------------------------------------------------------
Master (62a432a) is green with this patch.
./build-support/jenkins/build.sh
However, it appears that it might lack test coverage.
I will refresh this build result if you post a review containing "@ReviewBot retry"
- Aurora ReviewBot
On July 8, 2015, 12:53 p.m., Brian Brazil wrote:
>
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/36305/
> -----------------------------------------------------------
>
> (Updated July 8, 2015, 12:53 p.m.)
>
>
> Review request for Aurora, Stephan Erb and Bill Farner.
>
>
> Repository: aurora
>
>
> Description
> -------
>
> There's valid configuration where the hostname
> visibile in the browser won't exist in DNS, and
> mesos master/slave's equivilent settings don't
> have this restriction.
>
> Leave as a warning, as for most users this is a misconfiguration.
>
>
> Diffs
> -----
>
> src/main/java/org/apache/aurora/scheduler/http/JettyServerModule.java b4701295922ddad44d9d5c9fa29eb95e195e1604
>
> Diff: https://reviews.apache.org/r/36305/diff/
>
>
> Testing
> -------
>
> Verified in Vagrant environment.
>
>
> Thanks,
>
> Brian Brazil
>
>
Re: Review Request 36305: Remove restriction that -hostname must
resolve.
Posted by Brian Brazil <br...@boxever.com>.
> On July 8, 2015, 9:41 p.m., Bill Farner wrote:
> > src/main/java/org/apache/aurora/scheduler/http/JettyServerModule.java, line 155
> > <https://reviews.apache.org/r/36305/diff/1/?file=1002206#file1002206line155>
> >
> > Some more prose would be useful. How about:
> >
> > "Unable to resolve name specified in -hostname. Depending on your environment, this may be valid."
Done.
- Brian
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/36305/#review91000
-----------------------------------------------------------
On July 9, 2015, 10:14 a.m., Brian Brazil wrote:
>
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/36305/
> -----------------------------------------------------------
>
> (Updated July 9, 2015, 10:14 a.m.)
>
>
> Review request for Aurora, Stephan Erb and Bill Farner.
>
>
> Repository: aurora
>
>
> Description
> -------
>
> There's valid configuration where the hostname
> visibile in the browser won't exist in DNS, and
> mesos master/slave's equivilent settings don't
> have this restriction.
>
> Leave as a warning, as for most users this is a misconfiguration.
>
>
> Diffs
> -----
>
> src/main/java/org/apache/aurora/scheduler/http/JettyServerModule.java b4701295922ddad44d9d5c9fa29eb95e195e1604
>
> Diff: https://reviews.apache.org/r/36305/diff/
>
>
> Testing
> -------
>
> Verified in Vagrant environment.
>
>
> Thanks,
>
> Brian Brazil
>
>
Re: Review Request 36305: Remove restriction that -hostname must
resolve.
Posted by Bill Farner <wf...@apache.org>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/36305/#review91000
-----------------------------------------------------------
Ship it!
src/main/java/org/apache/aurora/scheduler/http/JettyServerModule.java (line 154)
<https://reviews.apache.org/r/36305/#comment144195>
Some more prose would be useful. How about:
"Unable to resolve name specified in -hostname. Depending on your environment, this may be valid."
- Bill Farner
On July 8, 2015, 12:53 p.m., Brian Brazil wrote:
>
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/36305/
> -----------------------------------------------------------
>
> (Updated July 8, 2015, 12:53 p.m.)
>
>
> Review request for Aurora, Stephan Erb and Bill Farner.
>
>
> Repository: aurora
>
>
> Description
> -------
>
> There's valid configuration where the hostname
> visibile in the browser won't exist in DNS, and
> mesos master/slave's equivilent settings don't
> have this restriction.
>
> Leave as a warning, as for most users this is a misconfiguration.
>
>
> Diffs
> -----
>
> src/main/java/org/apache/aurora/scheduler/http/JettyServerModule.java b4701295922ddad44d9d5c9fa29eb95e195e1604
>
> Diff: https://reviews.apache.org/r/36305/diff/
>
>
> Testing
> -------
>
> Verified in Vagrant environment.
>
>
> Thanks,
>
> Brian Brazil
>
>