You are viewing a plain text version of this content. The canonical link for it is here.
Posted to reviews@helix.apache.org by GitBox <gi...@apache.org> on 2022/06/17 22:31:41 UTC
[GitHub] [helix] qqu0127 opened a new pull request, #2161: Disable delayed rebalance in TestHelixViewAggregator test
qqu0127 opened a new pull request, #2161:
URL: https://github.com/apache/helix/pull/2161
### Issues
- [X] My PR addresses the following Helix issues and references them in the PR description:
Fixes https://github.com/apache/helix/issues/2049
### Description
- [X] Here are some details about my PR, including screenshots of any UI changes:
CI test history shows that test TestHelixViewAggregator is unstable. We suspect this is caused by delayed rebalance triggered during testing. This PR disable it for the source clusters in the test.
### Tests
- [X] The following tests are written for this issue:
Local test passed.
- The following is the result of the "mvn test" command on the appropriate module:
(If CI test fails due to known issue, please specify the issue and test PR locally. Then copy & paste the result of "mvn test" to here.)
### Changes that Break Backward Compatibility (Optional)
- My PR contains changes that break backward compatibility or previous assumptions for certain methods or API. They include:
(Consider including all behavior changes for public methods or API. Also include these changes in merge description so that other developers are aware of these changes. This allows them to make relevant code changes in feature branches accounting for the new method/API behavior.)
### Documentation (Optional)
- In case of new functionality, my PR adds documentation in the following wiki page:
(Link the GitHub wiki you added)
### Commits
- My commits all reference appropriate Apache Helix GitHub issues in their subject lines. In addition, my commits follow the guidelines from "[How to write a good git commit message](http://chris.beams.io/posts/git-commit/)":
1. Subject is separated from body by a blank line
1. Subject is limited to 50 characters (not including Jira issue reference)
1. Subject does not end with a period
1. Subject uses the imperative mood ("add", not "adding")
1. Body wraps at 72 characters
1. Body explains "what" and "why", not "how"
### Code Quality
- My diff has been formatted using helix-style.xml
(helix-style-intellij.xml if IntelliJ IDE is used)
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: reviews-unsubscribe@helix.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@helix.apache.org
For additional commands, e-mail: reviews-help@helix.apache.org
[GitHub] [helix] NealSun96 commented on a diff in pull request #2161: Fix TestHelixViewAggregator test
Posted by GitBox <gi...@apache.org>.
NealSun96 commented on code in PR #2161:
URL: https://github.com/apache/helix/pull/2161#discussion_r911459998
##########
helix-view-aggregator/src/test/java/org/apache/helix/view/integration/TestHelixViewAggregator.java:
##########
@@ -125,7 +123,8 @@ public void testHelixViewAggregator() throws Exception {
// Wait for refresh and verify
Thread.sleep((_viewClusterRefreshPeriodSec + 2) * 1000);
- verifyViewClusterEventChanges(false, true, true);
+ verifyInstanceConfigChange();
Review Comment:
Are you suggesting that some cluster events can happen before the verify functions, therefore the `<= 0` checks may fail? If that's the case, what do the `> 0` really verify, noise or test results? Correct me if my understanding is wrong.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: reviews-unsubscribe@helix.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@helix.apache.org
For additional commands, e-mail: reviews-help@helix.apache.org
[GitHub] [helix] junkaixue commented on pull request #2161: Fix TestHelixViewAggregator test
Posted by "junkaixue (via GitHub)" <gi...@apache.org>.
junkaixue commented on PR #2161:
URL: https://github.com/apache/helix/pull/2161#issuecomment-1407786537
Do we still this PR?
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: reviews-unsubscribe@helix.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@helix.apache.org
For additional commands, e-mail: reviews-help@helix.apache.org
[GitHub] [helix] junkaixue closed pull request #2161: Fix TestHelixViewAggregator test
Posted by "junkaixue (via GitHub)" <gi...@apache.org>.
junkaixue closed pull request #2161: Fix TestHelixViewAggregator test
URL: https://github.com/apache/helix/pull/2161
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: reviews-unsubscribe@helix.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@helix.apache.org
For additional commands, e-mail: reviews-help@helix.apache.org
[GitHub] [helix] qqu0127 commented on a diff in pull request #2161: Fix TestHelixViewAggregator test
Posted by GitBox <gi...@apache.org>.
qqu0127 commented on code in PR #2161:
URL: https://github.com/apache/helix/pull/2161#discussion_r911472418
##########
helix-view-aggregator/src/test/java/org/apache/helix/view/integration/TestHelixViewAggregator.java:
##########
@@ -125,7 +123,8 @@ public void testHelixViewAggregator() throws Exception {
// Wait for refresh and verify
Thread.sleep((_viewClusterRefreshPeriodSec + 2) * 1000);
- verifyViewClusterEventChanges(false, true, true);
+ verifyInstanceConfigChange();
Review Comment:
Yes. In extreme scenario, cluster event triggered by previous test can happen after the monitor reset and received during the following test, this would cause unexpected test failure if we check `_monitor.getExternalViewChangeCount() <= 0` e.g.
And yes, there could be false negative in some cases (regardless of this patch or not), where `> 0` test pass because of events from previous test or other sources.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: reviews-unsubscribe@helix.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@helix.apache.org
For additional commands, e-mail: reviews-help@helix.apache.org
[GitHub] [helix] qqu0127 commented on a diff in pull request #2161: Fix TestHelixViewAggregator test
Posted by GitBox <gi...@apache.org>.
qqu0127 commented on code in PR #2161:
URL: https://github.com/apache/helix/pull/2161#discussion_r911457378
##########
helix-view-aggregator/src/test/java/org/apache/helix/view/integration/TestHelixViewAggregator.java:
##########
@@ -125,7 +123,8 @@ public void testHelixViewAggregator() throws Exception {
// Wait for refresh and verify
Thread.sleep((_viewClusterRefreshPeriodSec + 2) * 1000);
- verifyViewClusterEventChanges(false, true, true);
+ verifyInstanceConfigChange();
Review Comment:
You are right about the behavior change, we are narrowing down the test scope since "No cluster event change" is actually not a functional requirement.
On the other side, the overlapping effect is also introducing noise to the overall CI tests.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: reviews-unsubscribe@helix.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@helix.apache.org
For additional commands, e-mail: reviews-help@helix.apache.org
[GitHub] [helix] NealSun96 commented on a diff in pull request #2161: Fix TestHelixViewAggregator test
Posted by GitBox <gi...@apache.org>.
NealSun96 commented on code in PR #2161:
URL: https://github.com/apache/helix/pull/2161#discussion_r911453212
##########
helix-view-aggregator/src/test/java/org/apache/helix/view/integration/TestHelixViewAggregator.java:
##########
@@ -125,7 +123,8 @@ public void testHelixViewAggregator() throws Exception {
// Wait for refresh and verify
Thread.sleep((_viewClusterRefreshPeriodSec + 2) * 1000);
- verifyViewClusterEventChanges(false, true, true);
+ verifyInstanceConfigChange();
Review Comment:
This as well as all the other similar changes:
The behavior is changed here. When it was (false, true, true), it was verifying that `_monitor.getExternalViewChangeCount() <= 0`, but that's no longer a check here. Is there a reason for that?
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: reviews-unsubscribe@helix.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@helix.apache.org
For additional commands, e-mail: reviews-help@helix.apache.org