You are viewing a plain text version of this content. The canonical link for it is here.
Posted to issues@hive.apache.org by "David Mollitor (Jira)" <ji...@apache.org> on 2020/04/16 14:49:00 UTC

[jira] [Updated] (HIVE-23099) Improve Logger for Operation Child Classes

     [ https://issues.apache.org/jira/browse/HIVE-23099?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ]

David Mollitor updated HIVE-23099:
----------------------------------
    Attachment: HIVE-23099.2.patch

> Improve Logger for Operation Child Classes
> ------------------------------------------
>
>                 Key: HIVE-23099
>                 URL: https://issues.apache.org/jira/browse/HIVE-23099
>             Project: Hive
>          Issue Type: Improvement
>            Reporter: David Mollitor
>            Assignee: David Mollitor
>            Priority: Minor
>         Attachments: HIVE-23099.1.patch, HIVE-23099.2.patch
>
>
> The {{Operation}} class declares its logger this way:
> {code:java|title=Operation.java}
> public abstract class Operation {
>   public static final Logger LOG = LoggerFactory.getLogger(Operation.class.getName());
>   ...
> }
> {code}
> Notice that this is an {{abstract}} class, but the {{Logger}} is tied to the {{Operation.class.getName()}}.  This means that logging cannot be controlled for each subclass of {{Operation}} independently since they all use the same static {{Logger}} instance.
> Make the LOG a {{protected}} instance variable that inherits the name of the child class.



--
This message was sent by Atlassian Jira
(v8.3.4#803005)