You are viewing a plain text version of this content. The canonical link for it is here.
Posted to commits@beam.apache.org by "Valentyn Tymofieiev (JIRA)" <ji...@apache.org> on 2018/08/02 01:14:00 UTC
[jira] [Commented] (BEAM-4730) Replace try/except imports related
to Py2/3 compatibility with from past.builtins imports
[ https://issues.apache.org/jira/browse/BEAM-4730?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16566208#comment-16566208 ]
Valentyn Tymofieiev commented on BEAM-4730:
-------------------------------------------
I think this was addressed by https://github.com/apache/beam/pull/5869 - should we close this issue?
I see two places in the codebase where we still have try/excepts, which I think are written as intended:
- https://github.com/apache/beam/blob/25a0070e48ab74e8d8e78f5f480d4824cffe270e/sdks/python/apache_beam/typehints/trivial_inference.py#L38
- https://github.com/apache/beam/blob/25a0070e48ab74e8d8e78f5f480d4824cffe270e/sdks/python/apache_beam/coders/coders.py#L317
> Replace try/except imports related to Py2/3 compatibility with from past.builtins imports
> -----------------------------------------------------------------------------------------
>
> Key: BEAM-4730
> URL: https://issues.apache.org/jira/browse/BEAM-4730
> Project: Beam
> Issue Type: Sub-task
> Components: sdk-py-core
> Reporter: Robbe
> Assignee: Robbe
> Priority: Major
>
--
This message was sent by Atlassian JIRA
(v7.6.3#76005)