You are viewing a plain text version of this content. The canonical link for it is here.
Posted to reviews@spark.apache.org by GitBox <gi...@apache.org> on 2021/02/26 19:05:08 UTC
[GitHub] [spark] sunchao opened a new pull request #31667: [SPARK-32703][SQL] Replace deprecated API calls from SpecificParquetRecordReaderBase
sunchao opened a new pull request #31667:
URL: https://github.com/apache/spark/pull/31667
<!--
Thanks for sending a pull request! Here are some tips for you:
1. If this is your first time, please read our contributor guidelines: https://spark.apache.org/contributing.html
2. Ensure you have added or run the appropriate tests for your PR: https://spark.apache.org/developer-tools.html
3. If the PR is unfinished, add '[WIP]' in your PR title, e.g., '[WIP][SPARK-XXXX] Your PR title ...'.
4. Be sure to keep the PR description updated to reflect all changes.
5. Please write your PR title to summarize what this PR proposes.
6. If possible, provide a concise example to reproduce the issue for a faster review.
7. If you want to add a new configuration, please read the guideline first for naming configurations in
'core/src/main/scala/org/apache/spark/internal/config/ConfigEntry.scala'.
-->
### What changes were proposed in this pull request?
<!--
Please clarify what changes you are proposing. The purpose of this section is to outline the changes and how this PR fixes the issue.
If possible, please consider writing useful notes for better and faster reviews in your PR. See the examples below.
1. If you refactor some codes with changing classes, showing the class hierarchy will help reviewers.
2. If you fix some SQL features, you can provide some references of other DBMSes.
3. If there is design documentation, please add the link.
4. If there is a discussion in the mailing list, please add the link.
-->
Currently in `SpecificParquetRecordReaderBase` we use deprecated APIs in a few places from Parquet, such as `readFooter`, `ParquetInputSplit`, `new ParquetFileReader`, `filterRowGroups`, etc. This replaces these with the newer APIs. In specific this:
- Replaces `ParquetInputSplit` with `FileSplit`. We never use specific things in the former such as `rowGroupOffsets` so the swap is pretty simple.
- Removes `readFooter` calls by using `ParquetFileReader.open`
- Replace deprecated `ParquetFileReader` ctor with the newer API which takes `ParquetReadOptions`.
- Removes the unnecessary handling of case when `rowGroupOffsets` is not null. It seems this never happens.
### Why are the changes needed?
<!--
Please clarify why the changes are needed. For instance,
1. If you propose a new API, clarify the use case for a new API.
2. If you fix a bug, you can clarify why it is a bug.
-->
The aforementioned APIs were deprecated and is going to be removed at some point in future. This is to ensure better supportability.
### Does this PR introduce _any_ user-facing change?
<!--
Note that it means *any* user-facing change including all aspects such as the documentation fix.
If yes, please clarify the previous behavior and the change this PR proposes - provide the console output, description and/or an example to show the behavior difference if possible.
If possible, please also clarify if this is a user-facing change compared to the released Spark versions or within the unreleased branches such as master.
If no, write 'No'.
-->
No
### How was this patch tested?
<!--
If tests were added, say they were added here. Please make sure to add some test cases that check the changes thoroughly including negative and positive cases if possible.
If it was tested in a way different from regular unit tests, please clarify how you tested step by step, ideally copy and paste-able, so that other reviewers can test and check, and descendants can verify in the future.
If tests were not added, please describe why they were not added and/or why it was difficult to add.
-->
This is a cleanup and relies on existing tests on the relevant code paths.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
[GitHub] [spark] AmplabJenkins removed a comment on pull request #31667: [SPARK-32703][SQL] Replace deprecated API calls from SpecificParquetRecordReaderBase
Posted by GitBox <gi...@apache.org>.
AmplabJenkins removed a comment on pull request #31667:
URL: https://github.com/apache/spark/pull/31667#issuecomment-788001461
Refer to this link for build results (access rights to CI server needed):
https://amplab.cs.berkeley.edu/jenkins//job/SparkPullRequestBuilder/135591/
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
[GitHub] [spark] AmplabJenkins removed a comment on pull request #31667: [SPARK-32703][SQL] Replace deprecated API calls from SpecificParquetRecordReaderBase
Posted by GitBox <gi...@apache.org>.
AmplabJenkins removed a comment on pull request #31667:
URL: https://github.com/apache/spark/pull/31667#issuecomment-787884580
Refer to this link for build results (access rights to CI server needed):
https://amplab.cs.berkeley.edu/jenkins//job/SparkPullRequestBuilder-K8s/40172/
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
[GitHub] [spark] SparkQA commented on pull request #31667: [SPARK-32703][SQL] Replace deprecated API calls from SpecificParquetRecordReaderBase
Posted by GitBox <gi...@apache.org>.
SparkQA commented on pull request #31667:
URL: https://github.com/apache/spark/pull/31667#issuecomment-786882779
Kubernetes integration test starting
URL: https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder-K8s/40101/
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
[GitHub] [spark] HyukjinKwon commented on pull request #31667: [SPARK-32703][SQL] Replace deprecated API calls from SpecificParquetRecordReaderBase
Posted by GitBox <gi...@apache.org>.
HyukjinKwon commented on pull request #31667:
URL: https://github.com/apache/spark/pull/31667#issuecomment-788697644
Merged to master.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
[GitHub] [spark] SparkQA commented on pull request #31667: [SPARK-32703][SQL] Replace deprecated API calls from SpecificParquetRecordReaderBase
Posted by GitBox <gi...@apache.org>.
SparkQA commented on pull request #31667:
URL: https://github.com/apache/spark/pull/31667#issuecomment-787852619
Kubernetes integration test starting
URL: https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder-K8s/40172/
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
[GitHub] [spark] maropu commented on pull request #31667: [SPARK-32703][SQL] Replace deprecated API calls from SpecificParquetRecordReaderBase
Posted by GitBox <gi...@apache.org>.
maropu commented on pull request #31667:
URL: https://github.com/apache/spark/pull/31667#issuecomment-787406568
okay, I've checked that there is no perf regression caused by this PR. Nice, @sunchao !
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
[GitHub] [spark] SparkQA removed a comment on pull request #31667: [SPARK-32703][SQL] Replace deprecated API calls from SpecificParquetRecordReaderBase
Posted by GitBox <gi...@apache.org>.
SparkQA removed a comment on pull request #31667:
URL: https://github.com/apache/spark/pull/31667#issuecomment-787826326
**[Test build #135591 has started](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/135591/testReport)** for PR 31667 at commit [`7f5d922`](https://github.com/apache/spark/commit/7f5d922382094f64882a30ff31332a777cfbf823).
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
[GitHub] [spark] AmplabJenkins commented on pull request #31667: [SPARK-32703][SQL] Replace deprecated API calls from SpecificParquetRecordReaderBase
Posted by GitBox <gi...@apache.org>.
AmplabJenkins commented on pull request #31667:
URL: https://github.com/apache/spark/pull/31667#issuecomment-788001461
Refer to this link for build results (access rights to CI server needed):
https://amplab.cs.berkeley.edu/jenkins//job/SparkPullRequestBuilder/135591/
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
[GitHub] [spark] SparkQA commented on pull request #31667: [SPARK-32703][SQL] Replace deprecated API calls from SpecificParquetRecordReaderBase
Posted by GitBox <gi...@apache.org>.
SparkQA commented on pull request #31667:
URL: https://github.com/apache/spark/pull/31667#issuecomment-787008337
**[Test build #135524 has finished](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/135524/testReport)** for PR 31667 at commit [`9b3bb11`](https://github.com/apache/spark/commit/9b3bb11f2576b44242d2b2d904e59ebf3fd5ae62).
* This patch passes all tests.
* This patch merges cleanly.
* This patch adds no public classes.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
[GitHub] [spark] AmplabJenkins removed a comment on pull request #31667: [SPARK-32703][SQL] Replace deprecated API calls from SpecificParquetRecordReaderBase
Posted by GitBox <gi...@apache.org>.
AmplabJenkins removed a comment on pull request #31667:
URL: https://github.com/apache/spark/pull/31667#issuecomment-786965906
Refer to this link for build results (access rights to CI server needed):
https://amplab.cs.berkeley.edu/jenkins//job/SparkPullRequestBuilder/135520/
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
[GitHub] [spark] HyukjinKwon closed pull request #31667: [SPARK-32703][SQL] Replace deprecated API calls from SpecificParquetRecordReaderBase
Posted by GitBox <gi...@apache.org>.
HyukjinKwon closed pull request #31667:
URL: https://github.com/apache/spark/pull/31667
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
[GitHub] [spark] maropu commented on pull request #31667: [SPARK-32703][SQL] Replace deprecated API calls from SpecificParquetRecordReaderBase
Posted by GitBox <gi...@apache.org>.
maropu commented on pull request #31667:
URL: https://github.com/apache/spark/pull/31667#issuecomment-787572022
LGTM
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
[GitHub] [spark] SparkQA commented on pull request #31667: [SPARK-32703][SQL] Replace deprecated API calls from SpecificParquetRecordReaderBase
Posted by GitBox <gi...@apache.org>.
SparkQA commented on pull request #31667:
URL: https://github.com/apache/spark/pull/31667#issuecomment-786985939
Kubernetes integration test status success
URL: https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder-K8s/40105/
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
[GitHub] [spark] dongjoon-hyun commented on pull request #31667: [SPARK-32703][SQL] Replace deprecated API calls from SpecificParquetRecordReaderBase
Posted by GitBox <gi...@apache.org>.
dongjoon-hyun commented on pull request #31667:
URL: https://github.com/apache/spark/pull/31667#issuecomment-787013547
Thank you, @maropu .
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
[GitHub] [spark] SparkQA commented on pull request #31667: [SPARK-32703][SQL] Replace deprecated API calls from SpecificParquetRecordReaderBase
Posted by GitBox <gi...@apache.org>.
SparkQA commented on pull request #31667:
URL: https://github.com/apache/spark/pull/31667#issuecomment-786980614
Kubernetes integration test starting
URL: https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder-K8s/40105/
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
[GitHub] [spark] AmplabJenkins removed a comment on pull request #31667: [SPARK-32703][SQL] Replace deprecated API calls from SpecificParquetRecordReaderBase
Posted by GitBox <gi...@apache.org>.
AmplabJenkins removed a comment on pull request #31667:
URL: https://github.com/apache/spark/pull/31667#issuecomment-787009801
Refer to this link for build results (access rights to CI server needed):
https://amplab.cs.berkeley.edu/jenkins//job/SparkPullRequestBuilder/135524/
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
[GitHub] [spark] SparkQA commented on pull request #31667: [SPARK-32703][SQL] Replace deprecated API calls from SpecificParquetRecordReaderBase
Posted by GitBox <gi...@apache.org>.
SparkQA commented on pull request #31667:
URL: https://github.com/apache/spark/pull/31667#issuecomment-787826326
**[Test build #135591 has started](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/135591/testReport)** for PR 31667 at commit [`7f5d922`](https://github.com/apache/spark/commit/7f5d922382094f64882a30ff31332a777cfbf823).
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
[GitHub] [spark] LuciferYang commented on a change in pull request #31667: [SPARK-32703][SQL] Replace deprecated API calls from SpecificParquetRecordReaderBase
Posted by GitBox <gi...@apache.org>.
LuciferYang commented on a change in pull request #31667:
URL: https://github.com/apache/spark/pull/31667#discussion_r584418998
##########
File path: sql/core/src/main/java/org/apache/spark/sql/execution/datasources/parquet/SpecificParquetRecordReaderBase.java
##########
@@ -227,6 +189,8 @@ protected void initialize(String path, List<String> columns) throws IOException
}
}
this.sparkSchema = new ParquetToSparkSchemaConverter(config).convert(requestedSchema);
+ // unfortunately we'd have to create the reader again since there is no column projection
+ // in the new API.
this.reader = new ParquetFileReader(
Review comment:
Can we reuse the `ParquetFileReader ` create at line 166 and manual set `requestedSchema ` ?
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
[GitHub] [spark] AmplabJenkins commented on pull request #31667: [SPARK-32703][SQL] Replace deprecated API calls from SpecificParquetRecordReaderBase
Posted by GitBox <gi...@apache.org>.
AmplabJenkins commented on pull request #31667:
URL: https://github.com/apache/spark/pull/31667#issuecomment-787884580
Refer to this link for build results (access rights to CI server needed):
https://amplab.cs.berkeley.edu/jenkins//job/SparkPullRequestBuilder-K8s/40172/
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
[GitHub] [spark] SparkQA commented on pull request #31667: [SPARK-32703][SQL] Replace deprecated API calls from SpecificParquetRecordReaderBase
Posted by GitBox <gi...@apache.org>.
SparkQA commented on pull request #31667:
URL: https://github.com/apache/spark/pull/31667#issuecomment-786960272
**[Test build #135520 has finished](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/135520/testReport)** for PR 31667 at commit [`3d32fb6`](https://github.com/apache/spark/commit/3d32fb698488ee564f9df470d10145a854dcf628).
* This patch passes all tests.
* This patch merges cleanly.
* This patch adds no public classes.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
[GitHub] [spark] AmplabJenkins commented on pull request #31667: [SPARK-32703][SQL] Replace deprecated API calls from SpecificParquetRecordReaderBase
Posted by GitBox <gi...@apache.org>.
AmplabJenkins commented on pull request #31667:
URL: https://github.com/apache/spark/pull/31667#issuecomment-786905405
Refer to this link for build results (access rights to CI server needed):
https://amplab.cs.berkeley.edu/jenkins//job/SparkPullRequestBuilder-K8s/40101/
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
[GitHub] [spark] SparkQA commented on pull request #31667: [SPARK-32703][SQL] Replace deprecated API calls from SpecificParquetRecordReaderBase
Posted by GitBox <gi...@apache.org>.
SparkQA commented on pull request #31667:
URL: https://github.com/apache/spark/pull/31667#issuecomment-786862331
**[Test build #135520 has started](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/135520/testReport)** for PR 31667 at commit [`3d32fb6`](https://github.com/apache/spark/commit/3d32fb698488ee564f9df470d10145a854dcf628).
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
[GitHub] [spark] AmplabJenkins removed a comment on pull request #31667: [SPARK-32703][SQL] Replace deprecated API calls from SpecificParquetRecordReaderBase
Posted by GitBox <gi...@apache.org>.
AmplabJenkins removed a comment on pull request #31667:
URL: https://github.com/apache/spark/pull/31667#issuecomment-786905405
Refer to this link for build results (access rights to CI server needed):
https://amplab.cs.berkeley.edu/jenkins//job/SparkPullRequestBuilder-K8s/40101/
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
[GitHub] [spark] AmplabJenkins removed a comment on pull request #31667: [SPARK-32703][SQL] Replace deprecated API calls from SpecificParquetRecordReaderBase
Posted by GitBox <gi...@apache.org>.
AmplabJenkins removed a comment on pull request #31667:
URL: https://github.com/apache/spark/pull/31667#issuecomment-786989064
Refer to this link for build results (access rights to CI server needed):
https://amplab.cs.berkeley.edu/jenkins//job/SparkPullRequestBuilder-K8s/40105/
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
[GitHub] [spark] AmplabJenkins commented on pull request #31667: [SPARK-32703][SQL] Replace deprecated API calls from SpecificParquetRecordReaderBase
Posted by GitBox <gi...@apache.org>.
AmplabJenkins commented on pull request #31667:
URL: https://github.com/apache/spark/pull/31667#issuecomment-787009801
Refer to this link for build results (access rights to CI server needed):
https://amplab.cs.berkeley.edu/jenkins//job/SparkPullRequestBuilder/135524/
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
[GitHub] [spark] SparkQA commented on pull request #31667: [SPARK-32703][SQL] Replace deprecated API calls from SpecificParquetRecordReaderBase
Posted by GitBox <gi...@apache.org>.
SparkQA commented on pull request #31667:
URL: https://github.com/apache/spark/pull/31667#issuecomment-787870116
Kubernetes integration test status success
URL: https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder-K8s/40172/
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
[GitHub] [spark] AmplabJenkins commented on pull request #31667: [SPARK-32703][SQL] Replace deprecated API calls from SpecificParquetRecordReaderBase
Posted by GitBox <gi...@apache.org>.
AmplabJenkins commented on pull request #31667:
URL: https://github.com/apache/spark/pull/31667#issuecomment-786989064
Refer to this link for build results (access rights to CI server needed):
https://amplab.cs.berkeley.edu/jenkins//job/SparkPullRequestBuilder-K8s/40105/
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
[GitHub] [spark] SparkQA commented on pull request #31667: [SPARK-32703][SQL] Replace deprecated API calls from SpecificParquetRecordReaderBase
Posted by GitBox <gi...@apache.org>.
SparkQA commented on pull request #31667:
URL: https://github.com/apache/spark/pull/31667#issuecomment-786971100
**[Test build #135524 has started](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/135524/testReport)** for PR 31667 at commit [`9b3bb11`](https://github.com/apache/spark/commit/9b3bb11f2576b44242d2b2d904e59ebf3fd5ae62).
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
[GitHub] [spark] SparkQA removed a comment on pull request #31667: [SPARK-32703][SQL] Replace deprecated API calls from SpecificParquetRecordReaderBase
Posted by GitBox <gi...@apache.org>.
SparkQA removed a comment on pull request #31667:
URL: https://github.com/apache/spark/pull/31667#issuecomment-786971100
**[Test build #135524 has started](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/135524/testReport)** for PR 31667 at commit [`9b3bb11`](https://github.com/apache/spark/commit/9b3bb11f2576b44242d2b2d904e59ebf3fd5ae62).
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
[GitHub] [spark] sunchao commented on a change in pull request #31667: [SPARK-32703][SQL] Replace deprecated API calls from SpecificParquetRecordReaderBase
Posted by GitBox <gi...@apache.org>.
sunchao commented on a change in pull request #31667:
URL: https://github.com/apache/spark/pull/31667#discussion_r584555944
##########
File path: sql/core/src/main/java/org/apache/spark/sql/execution/datasources/parquet/SpecificParquetRecordReaderBase.java
##########
@@ -227,6 +189,8 @@ protected void initialize(String path, List<String> columns) throws IOException
}
}
this.sparkSchema = new ParquetToSparkSchemaConverter(config).convert(requestedSchema);
+ // unfortunately we'd have to create the reader again since there is no column projection
+ // in the new API.
this.reader = new ParquetFileReader(
Review comment:
You're right. I missed this. Will update.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
[GitHub] [spark] SparkQA commented on pull request #31667: [SPARK-32703][SQL] Replace deprecated API calls from SpecificParquetRecordReaderBase
Posted by GitBox <gi...@apache.org>.
SparkQA commented on pull request #31667:
URL: https://github.com/apache/spark/pull/31667#issuecomment-786896966
Kubernetes integration test status failure
URL: https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder-K8s/40101/
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
[GitHub] [spark] sunchao commented on pull request #31667: [SPARK-32703][SQL] Replace deprecated API calls from SpecificParquetRecordReaderBase
Posted by GitBox <gi...@apache.org>.
sunchao commented on pull request #31667:
URL: https://github.com/apache/spark/pull/31667#issuecomment-786960800
Seems test is flaky - let me re-trigger it.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
[GitHub] [spark] AmplabJenkins commented on pull request #31667: [SPARK-32703][SQL] Replace deprecated API calls from SpecificParquetRecordReaderBase
Posted by GitBox <gi...@apache.org>.
AmplabJenkins commented on pull request #31667:
URL: https://github.com/apache/spark/pull/31667#issuecomment-786965906
Refer to this link for build results (access rights to CI server needed):
https://amplab.cs.berkeley.edu/jenkins//job/SparkPullRequestBuilder/135520/
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
[GitHub] [spark] maropu commented on pull request #31667: [SPARK-32703][SQL] Replace deprecated API calls from SpecificParquetRecordReaderBase
Posted by GitBox <gi...@apache.org>.
maropu commented on pull request #31667:
URL: https://github.com/apache/spark/pull/31667#issuecomment-786986205
I'm running TPCDS queries based on this fix.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
[GitHub] [spark] SparkQA removed a comment on pull request #31667: [SPARK-32703][SQL] Replace deprecated API calls from SpecificParquetRecordReaderBase
Posted by GitBox <gi...@apache.org>.
SparkQA removed a comment on pull request #31667:
URL: https://github.com/apache/spark/pull/31667#issuecomment-786862331
**[Test build #135520 has started](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/135520/testReport)** for PR 31667 at commit [`3d32fb6`](https://github.com/apache/spark/commit/3d32fb698488ee564f9df470d10145a854dcf628).
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
[GitHub] [spark] SparkQA commented on pull request #31667: [SPARK-32703][SQL] Replace deprecated API calls from SpecificParquetRecordReaderBase
Posted by GitBox <gi...@apache.org>.
SparkQA commented on pull request #31667:
URL: https://github.com/apache/spark/pull/31667#issuecomment-787988781
**[Test build #135591 has finished](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/135591/testReport)** for PR 31667 at commit [`7f5d922`](https://github.com/apache/spark/commit/7f5d922382094f64882a30ff31332a777cfbf823).
* This patch passes all tests.
* This patch merges cleanly.
* This patch adds no public classes.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org