You are viewing a plain text version of this content. The canonical link for it is here.
Posted to commits@harmony.apache.org by "Alexey Petrenko (JIRA)" <ji...@apache.org> on 2006/09/20 15:41:23 UTC
[jira] Created: (HARMONY-1505) [build?] Some of the Harmony jni
libraries has wrong function names inside
[build?] Some of the Harmony jni libraries has wrong function names inside
--------------------------------------------------------------------------
Key: HARMONY-1505
URL: http://issues.apache.org/jira/browse/HARMONY-1505
Project: Harmony
Issue Type: Bug
Components: Classlib
Environment: Windows
Reporter: Alexey Petrenko
Some of the Harmony jni libraries, for example hyluni.dll, has function names which are not prefixed by underscore ( _ ).
JNI spec says that all the JNI methods on Windows should be declared as __stdcall. [1] And MS C documentation says that __stdcall function names should be prefixed by underscore. [2]
[1] http://java.sun.com/j2se/1.5.0/docs/guide/jni/spec/design.html#wp615
[2] http://msdn2.microsoft.com/en-us/library/zxk0tw93.aspx
--
This message is automatically generated by JIRA.
-
If you think it was sent incorrectly contact one of the administrators: http://issues.apache.org/jira/secure/Administrators.jspa
-
For more information on JIRA, see: http://www.atlassian.com/software/jira
Re: [jira] Created: (HARMONY-1505) [build?] Some of the Harmony jni libraries has wrong function names inside
Posted by Alexey Petrenko <al...@gmail.com>.
Investigation shown another problem... Number of JNI methods in
archive and luni modules does not marked with JNIEXPORT as it required
by the spec.
This issue should be also fixed.
I'll split the original (1505) issue on two subtasks. To make patches smaller.
SY, Alexey
2006/9/27, Alexey Petrenko <al...@gmail.com>:
> MS VC documentation recommends to use "__declspec(dllexport)" option
> instead of EXPORTS section. In our case it is JNIEXPORT.
> And all of the JNI functions are marked as JNIEXPORT.
>
> 2006/9/27, Mark Hindess <ma...@googlemail.com>:
> >
> > On 27 September 2006 at 15:18, "Alexey Petrenko" <al...@gmail.com> wrote:
> > > So... If there is now EXPORTS section advocates I will prepare a patch
> > > to remove them from the def files for Windows.
> >
> > If removing them means we are exporting all symbols, then I'd rather
> > keep explicit exports of the symbols we intend to be public.
> >
> > Is there no way to fix it and keep the explicit list of "public"
> > symbols?
> >
> > -Mark.
> >
> > > SY, Alexey
> > >
> > > 2006/9/26, Alexey Petrenko <al...@gmail.com>:
> > > > Guys,
> > > >
> > > > investigation shown that if we remove EXPORTS section from the def
> > > > file then the result dll has correct names.
> > > >
> > > > Is there any objections on removing EXPORTS sections from the def
> > > > files on Windows?
> > > >
> > > > SY, Alexey
> > > >
> > > > 2006/9/20, Alexey Petrenko (JIRA) <ji...@apache.org>:
> > > > > [build?] Some of the Harmony jni libraries has wrong function names insid
> > > e
> > > > > -------------------------------------------------------------------------
> > > -
> > > > >
> > > > > Key: HARMONY-1505
> > > > > URL: http://issues.apache.org/jira/browse/HARMONY-1505
> > > > > Project: Harmony
> > > > > Issue Type: Bug
> > > > > Components: Classlib
> > > > > Environment: Windows
> > > > > Reporter: Alexey Petrenko
> > > > >
> > > > >
> > > > > Some of the Harmony jni libraries, for example hyluni.dll, has function n
> > > ames which are not prefixed by underscore ( _ ).
> > > > >
> > > > > JNI spec says that all the JNI methods on Windows should be declared as _
> > > _stdcall. [1] And MS C documentation says that __stdcall function names shoul
> > > d be prefixed by underscore. [2]
> > > > >
> > > > > [1] http://java.sun.com/j2se/1.5.0/docs/guide/jni/spec/design.html#wp615
> > > > > [2] http://msdn2.microsoft.com/en-us/library/zxk0tw93.aspx
> > > > >
> > > > > --
> > > > > This message is automatically generated by JIRA.
> > > > > -
> > > > > If you think it was sent incorrectly contact one of the administrators: h
> > > ttp://issues.apache.org/jira/secure/Administrators.jspa
> > > > > -
> > > > > For more information on JIRA, see: http://www.atlassian.com/software/jira
> > > > >
> > > > >
> > > > >
> > > >
> > > >
> > > > --
> > > > Alexey A. Petrenko
> > > > Intel Middleware Products Division
> > > >
> > >
> > >
> > > --
> > > Alexey A. Petrenko
> > > Intel Middleware Products Division
> > >
> > > ---------------------------------------------------------------------
> > > Terms of use : http://incubator.apache.org/harmony/mailing.html
> > > To unsubscribe, e-mail: harmony-dev-unsubscribe@incubator.apache.org
> > > For additional commands, e-mail: harmony-dev-help@incubator.apache.org
> > >
> >
> >
> >
> > ---------------------------------------------------------------------
> > Terms of use : http://incubator.apache.org/harmony/mailing.html
> > To unsubscribe, e-mail: harmony-dev-unsubscribe@incubator.apache.org
> > For additional commands, e-mail: harmony-dev-help@incubator.apache.org
> >
> >
>
>
> --
> Alexey A. Petrenko
> Intel Middleware Products Division
>
--
Alexey A. Petrenko
Intel Middleware Products Division
---------------------------------------------------------------------
Terms of use : http://incubator.apache.org/harmony/mailing.html
To unsubscribe, e-mail: harmony-dev-unsubscribe@incubator.apache.org
For additional commands, e-mail: harmony-dev-help@incubator.apache.org
Re: [jira] Created: (HARMONY-1505) [build?] Some of the Harmony jni libraries has wrong function names inside
Posted by Alexey Petrenko <al...@gmail.com>.
MS VC documentation recommends to use "__declspec(dllexport)" option
instead of EXPORTS section. In our case it is JNIEXPORT.
And all of the JNI functions are marked as JNIEXPORT.
2006/9/27, Mark Hindess <ma...@googlemail.com>:
>
> On 27 September 2006 at 15:18, "Alexey Petrenko" <al...@gmail.com> wrote:
> > So... If there is now EXPORTS section advocates I will prepare a patch
> > to remove them from the def files for Windows.
>
> If removing them means we are exporting all symbols, then I'd rather
> keep explicit exports of the symbols we intend to be public.
>
> Is there no way to fix it and keep the explicit list of "public"
> symbols?
>
> -Mark.
>
> > SY, Alexey
> >
> > 2006/9/26, Alexey Petrenko <al...@gmail.com>:
> > > Guys,
> > >
> > > investigation shown that if we remove EXPORTS section from the def
> > > file then the result dll has correct names.
> > >
> > > Is there any objections on removing EXPORTS sections from the def
> > > files on Windows?
> > >
> > > SY, Alexey
> > >
> > > 2006/9/20, Alexey Petrenko (JIRA) <ji...@apache.org>:
> > > > [build?] Some of the Harmony jni libraries has wrong function names insid
> > e
> > > > -------------------------------------------------------------------------
> > -
> > > >
> > > > Key: HARMONY-1505
> > > > URL: http://issues.apache.org/jira/browse/HARMONY-1505
> > > > Project: Harmony
> > > > Issue Type: Bug
> > > > Components: Classlib
> > > > Environment: Windows
> > > > Reporter: Alexey Petrenko
> > > >
> > > >
> > > > Some of the Harmony jni libraries, for example hyluni.dll, has function n
> > ames which are not prefixed by underscore ( _ ).
> > > >
> > > > JNI spec says that all the JNI methods on Windows should be declared as _
> > _stdcall. [1] And MS C documentation says that __stdcall function names shoul
> > d be prefixed by underscore. [2]
> > > >
> > > > [1] http://java.sun.com/j2se/1.5.0/docs/guide/jni/spec/design.html#wp615
> > > > [2] http://msdn2.microsoft.com/en-us/library/zxk0tw93.aspx
> > > >
> > > > --
> > > > This message is automatically generated by JIRA.
> > > > -
> > > > If you think it was sent incorrectly contact one of the administrators: h
> > ttp://issues.apache.org/jira/secure/Administrators.jspa
> > > > -
> > > > For more information on JIRA, see: http://www.atlassian.com/software/jira
> > > >
> > > >
> > > >
> > >
> > >
> > > --
> > > Alexey A. Petrenko
> > > Intel Middleware Products Division
> > >
> >
> >
> > --
> > Alexey A. Petrenko
> > Intel Middleware Products Division
> >
> > ---------------------------------------------------------------------
> > Terms of use : http://incubator.apache.org/harmony/mailing.html
> > To unsubscribe, e-mail: harmony-dev-unsubscribe@incubator.apache.org
> > For additional commands, e-mail: harmony-dev-help@incubator.apache.org
> >
>
>
>
> ---------------------------------------------------------------------
> Terms of use : http://incubator.apache.org/harmony/mailing.html
> To unsubscribe, e-mail: harmony-dev-unsubscribe@incubator.apache.org
> For additional commands, e-mail: harmony-dev-help@incubator.apache.org
>
>
--
Alexey A. Petrenko
Intel Middleware Products Division
---------------------------------------------------------------------
Terms of use : http://incubator.apache.org/harmony/mailing.html
To unsubscribe, e-mail: harmony-dev-unsubscribe@incubator.apache.org
For additional commands, e-mail: harmony-dev-help@incubator.apache.org
Re: [jira] Created: (HARMONY-1505) [build?] Some of the Harmony jni libraries has wrong function names inside
Posted by Mark Hindess <ma...@googlemail.com>.
On 27 September 2006 at 15:18, "Alexey Petrenko" <al...@gmail.com> wrote:
> So... If there is now EXPORTS section advocates I will prepare a patch
> to remove them from the def files for Windows.
If removing them means we are exporting all symbols, then I'd rather
keep explicit exports of the symbols we intend to be public.
Is there no way to fix it and keep the explicit list of "public"
symbols?
-Mark.
> SY, Alexey
>
> 2006/9/26, Alexey Petrenko <al...@gmail.com>:
> > Guys,
> >
> > investigation shown that if we remove EXPORTS section from the def
> > file then the result dll has correct names.
> >
> > Is there any objections on removing EXPORTS sections from the def
> > files on Windows?
> >
> > SY, Alexey
> >
> > 2006/9/20, Alexey Petrenko (JIRA) <ji...@apache.org>:
> > > [build?] Some of the Harmony jni libraries has wrong function names insid
> e
> > > -------------------------------------------------------------------------
> -
> > >
> > > Key: HARMONY-1505
> > > URL: http://issues.apache.org/jira/browse/HARMONY-1505
> > > Project: Harmony
> > > Issue Type: Bug
> > > Components: Classlib
> > > Environment: Windows
> > > Reporter: Alexey Petrenko
> > >
> > >
> > > Some of the Harmony jni libraries, for example hyluni.dll, has function n
> ames which are not prefixed by underscore ( _ ).
> > >
> > > JNI spec says that all the JNI methods on Windows should be declared as _
> _stdcall. [1] And MS C documentation says that __stdcall function names shoul
> d be prefixed by underscore. [2]
> > >
> > > [1] http://java.sun.com/j2se/1.5.0/docs/guide/jni/spec/design.html#wp615
> > > [2] http://msdn2.microsoft.com/en-us/library/zxk0tw93.aspx
> > >
> > > --
> > > This message is automatically generated by JIRA.
> > > -
> > > If you think it was sent incorrectly contact one of the administrators: h
> ttp://issues.apache.org/jira/secure/Administrators.jspa
> > > -
> > > For more information on JIRA, see: http://www.atlassian.com/software/jira
> > >
> > >
> > >
> >
> >
> > --
> > Alexey A. Petrenko
> > Intel Middleware Products Division
> >
>
>
> --
> Alexey A. Petrenko
> Intel Middleware Products Division
>
> ---------------------------------------------------------------------
> Terms of use : http://incubator.apache.org/harmony/mailing.html
> To unsubscribe, e-mail: harmony-dev-unsubscribe@incubator.apache.org
> For additional commands, e-mail: harmony-dev-help@incubator.apache.org
>
---------------------------------------------------------------------
Terms of use : http://incubator.apache.org/harmony/mailing.html
To unsubscribe, e-mail: harmony-dev-unsubscribe@incubator.apache.org
For additional commands, e-mail: harmony-dev-help@incubator.apache.org
Re: [jira] Created: (HARMONY-1505) [build?] Some of the Harmony jni libraries has wrong function names inside
Posted by Alexey Petrenko <al...@gmail.com>.
So... If there is now EXPORTS section advocates I will prepare a patch
to remove them from the def files for Windows.
SY, Alexey
2006/9/26, Alexey Petrenko <al...@gmail.com>:
> Guys,
>
> investigation shown that if we remove EXPORTS section from the def
> file then the result dll has correct names.
>
> Is there any objections on removing EXPORTS sections from the def
> files on Windows?
>
> SY, Alexey
>
> 2006/9/20, Alexey Petrenko (JIRA) <ji...@apache.org>:
> > [build?] Some of the Harmony jni libraries has wrong function names inside
> > --------------------------------------------------------------------------
> >
> > Key: HARMONY-1505
> > URL: http://issues.apache.org/jira/browse/HARMONY-1505
> > Project: Harmony
> > Issue Type: Bug
> > Components: Classlib
> > Environment: Windows
> > Reporter: Alexey Petrenko
> >
> >
> > Some of the Harmony jni libraries, for example hyluni.dll, has function names which are not prefixed by underscore ( _ ).
> >
> > JNI spec says that all the JNI methods on Windows should be declared as __stdcall. [1] And MS C documentation says that __stdcall function names should be prefixed by underscore. [2]
> >
> > [1] http://java.sun.com/j2se/1.5.0/docs/guide/jni/spec/design.html#wp615
> > [2] http://msdn2.microsoft.com/en-us/library/zxk0tw93.aspx
> >
> > --
> > This message is automatically generated by JIRA.
> > -
> > If you think it was sent incorrectly contact one of the administrators: http://issues.apache.org/jira/secure/Administrators.jspa
> > -
> > For more information on JIRA, see: http://www.atlassian.com/software/jira
> >
> >
> >
>
>
> --
> Alexey A. Petrenko
> Intel Middleware Products Division
>
--
Alexey A. Petrenko
Intel Middleware Products Division
---------------------------------------------------------------------
Terms of use : http://incubator.apache.org/harmony/mailing.html
To unsubscribe, e-mail: harmony-dev-unsubscribe@incubator.apache.org
For additional commands, e-mail: harmony-dev-help@incubator.apache.org
Re: [jira] Created: (HARMONY-1505) [build?] Some of the Harmony jni libraries has wrong function names inside
Posted by Alexey Petrenko <al...@gmail.com>.
Guys,
investigation shown that if we remove EXPORTS section from the def
file then the result dll has correct names.
Is there any objections on removing EXPORTS sections from the def
files on Windows?
SY, Alexey
2006/9/20, Alexey Petrenko (JIRA) <ji...@apache.org>:
> [build?] Some of the Harmony jni libraries has wrong function names inside
> --------------------------------------------------------------------------
>
> Key: HARMONY-1505
> URL: http://issues.apache.org/jira/browse/HARMONY-1505
> Project: Harmony
> Issue Type: Bug
> Components: Classlib
> Environment: Windows
> Reporter: Alexey Petrenko
>
>
> Some of the Harmony jni libraries, for example hyluni.dll, has function names which are not prefixed by underscore ( _ ).
>
> JNI spec says that all the JNI methods on Windows should be declared as __stdcall. [1] And MS C documentation says that __stdcall function names should be prefixed by underscore. [2]
>
> [1] http://java.sun.com/j2se/1.5.0/docs/guide/jni/spec/design.html#wp615
> [2] http://msdn2.microsoft.com/en-us/library/zxk0tw93.aspx
>
> --
> This message is automatically generated by JIRA.
> -
> If you think it was sent incorrectly contact one of the administrators: http://issues.apache.org/jira/secure/Administrators.jspa
> -
> For more information on JIRA, see: http://www.atlassian.com/software/jira
>
>
>
--
Alexey A. Petrenko
Intel Middleware Products Division
---------------------------------------------------------------------
Terms of use : http://incubator.apache.org/harmony/mailing.html
To unsubscribe, e-mail: harmony-dev-unsubscribe@incubator.apache.org
For additional commands, e-mail: harmony-dev-help@incubator.apache.org
[jira] Updated: (HARMONY-1505) [build?] Some of the Harmony jni
libraries has wrong function names inside
Posted by "Alexey Petrenko (JIRA)" <ji...@apache.org>.
[ http://issues.apache.org/jira/browse/HARMONY-1505?page=all ]
Alexey Petrenko updated HARMONY-1505:
-------------------------------------
Attachment: HARMONY-1505.diff
Investigation shown that removing JNI methods from EXPORTS section of def files solves the problem.
Moreover MS VC documentatio recommends to use "__declspec(dllexport)" option instead of EXPORTS section. In our case it is JNIEXPORT option.
NB. This patch should be applied after the patch for HARMONY-1608.
> [build?] Some of the Harmony jni libraries has wrong function names inside
> --------------------------------------------------------------------------
>
> Key: HARMONY-1505
> URL: http://issues.apache.org/jira/browse/HARMONY-1505
> Project: Harmony
> Issue Type: Bug
> Components: Classlib
> Environment: Windows
> Reporter: Alexey Petrenko
> Attachments: HARMONY-1505.diff
>
>
> Some of the Harmony jni libraries, for example hyluni.dll, has function names which are not prefixed by underscore ( _ ).
> JNI spec says that all the JNI methods on Windows should be declared as __stdcall. [1] And MS C documentation says that __stdcall function names should be prefixed by underscore. [2]
> [1] http://java.sun.com/j2se/1.5.0/docs/guide/jni/spec/design.html#wp615
> [2] http://msdn2.microsoft.com/en-us/library/zxk0tw93.aspx
--
This message is automatically generated by JIRA.
-
If you think it was sent incorrectly contact one of the administrators: http://issues.apache.org/jira/secure/Administrators.jspa
-
For more information on JIRA, see: http://www.atlassian.com/software/jira
[jira] Commented: (HARMONY-1505) [build?] Some of the Harmony jni
libraries has wrong function names inside
Posted by "Alexey Petrenko (JIRA)" <ji...@apache.org>.
[ http://issues.apache.org/jira/browse/HARMONY-1505?page=comments#action_12436233 ]
Alexey Petrenko commented on HARMONY-1505:
------------------------------------------
I'll look into this issue.
> [build?] Some of the Harmony jni libraries has wrong function names inside
> --------------------------------------------------------------------------
>
> Key: HARMONY-1505
> URL: http://issues.apache.org/jira/browse/HARMONY-1505
> Project: Harmony
> Issue Type: Bug
> Components: Classlib
> Environment: Windows
> Reporter: Alexey Petrenko
>
> Some of the Harmony jni libraries, for example hyluni.dll, has function names which are not prefixed by underscore ( _ ).
> JNI spec says that all the JNI methods on Windows should be declared as __stdcall. [1] And MS C documentation says that __stdcall function names should be prefixed by underscore. [2]
> [1] http://java.sun.com/j2se/1.5.0/docs/guide/jni/spec/design.html#wp615
> [2] http://msdn2.microsoft.com/en-us/library/zxk0tw93.aspx
--
This message is automatically generated by JIRA.
-
If you think it was sent incorrectly contact one of the administrators: http://issues.apache.org/jira/secure/Administrators.jspa
-
For more information on JIRA, see: http://www.atlassian.com/software/jira