[GitHub] [incubator-devlake] e2corporation commented on a diff in pull request #3107: feat: Responsive sidebar

[GitBox <gi...@apache.org>]

e2corporation commented on code in PR #3107:
URL: https://github.com/apache/incubator-devlake/pull/3107#discussion_r975648117


##########
config-ui/src/components/Nav.jsx:
##########
@@ -26,11 +26,41 @@ import {
 import '@/styles/nav.scss'
 import { ReactComponent as SlackIcon } from '@/images/slack-mark-monochrome-black.svg'
 import { ReactComponent as SlackLogo } from '@/images/slack-rgb.svg'
+import UIContext from '../store/UIContext'
+import useWindowSize from '../hooks/useWIndowSize'
+
 
 const Nav = () => {
+  const uiContext = useContext(UIContext);
+  const [menuClass, setMenuClass] = useState("navbarMenuButton");
+  const size = useWindowSize();
+
+  const toggleSidebarOpen = (open) => {

Review Comment:
   I think this could be refactored to be more declarative and drop the need for using the `IF` and `return` statements.
   ```suggestion
     const toggleSidebarOpen = (open) => {
     uiContext.changeSidebarVisibility(open)
     setMenuClass(open ? 'navbarMenuButtonSidebarOpened' : 'navbarMenuButton'
    }
   ```



-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: commits-unsubscribe@devlake.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org