[GitHub] [druid] loquisgon commented on a diff in pull request #12392: Make tombstones ingestible by having them return an empty result set.

[GitBox <gi...@apache.org>]

loquisgon commented on code in PR #12392:
URL: https://github.com/apache/druid/pull/12392#discussion_r847586866


##########
core/src/main/java/org/apache/druid/data/input/InputEntity.java:
##########
@@ -136,4 +136,13 @@ public void close()
   {
     return Predicates.alwaysFalse();
   }
+
+  /**
+   * This is required so that an empty iterator is created for the reader corresponding to a tombstone
+   * @return false if the entity does not come from a tombstone segment, true otherwise
+   */
+  default boolean isFromTombstone()

Review Comment:
   Fixed in next commit



-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: commits-unsubscribe@druid.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org


---------------------------------------------------------------------
To unsubscribe, e-mail: commits-unsubscribe@druid.apache.org
For additional commands, e-mail: commits-help@druid.apache.org