You are viewing a plain text version of this content. The canonical link for it is here.
Posted to commits@druid.apache.org by GitBox <gi...@apache.org> on 2019/12/04 08:04:15 UTC

[GitHub] [incubator-druid] frnidito opened a new pull request #8987: Adding support for autoscaling in GCE

frnidito opened a new pull request #8987: Adding support for autoscaling in GCE
URL: https://github.com/apache/incubator-druid/pull/8987
 
 
   ### Description
   
   With this PR we intend to upstream the module we use to autoscale druid in GCE.
   
   The module structure—and configuration— take inspiration from the autoscaling module for EC2 and they are quite straightforward.
   
   The central piece is represented by the `GCEAutoScaler` class implementing the interface `org.apache.druid.indexing.overlord.autoscaling.AutoScaler` and embedding all the logic to communicate with GCE to provision and terminate instances.
   
   The module manages the instances through the Managed Instances Groups of GCE in order to make the interaction, and in turn the logic of the module, simpler.
   
   Aside from the code, we provide the documentation in `docs/development/extensions-contrib/gce-extensions.md` explaining how to set up the instances, the group and the account for the module to be used. 
   
   <hr>
   
   This PR has:
   - [X] been self-reviewed.
   - [X] added documentation for new or modified features or behaviors.
   - [X] added Javadocs for most classes and all non-trivial methods. Linked related entities via Javadoc links.
   - [X] added or updated version, license, or notice information in [licenses.yaml](https://github.com/apache/incubator-druid/blob/master/licenses.yaml)
   - [X] added comments explaining the "why" and the intent of the code wherever would not be obvious for an unfamiliar reader.
   - [X] added unit tests or modified existing tests to cover new code paths.
   - [ ] added integration tests.
   - [X] been tested in a test Druid cluster.
   
   <hr>
   
   ##### Key added classes in this PR
    * `GCEAutoScaler`
    * `GCEEnvironmentConfig`
    * `GCEModule`
    * `GCEUtils`
   

----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
users@infra.apache.org


With regards,
Apache Git Services

---------------------------------------------------------------------
To unsubscribe, e-mail: commits-unsubscribe@druid.apache.org
For additional commands, e-mail: commits-help@druid.apache.org