You are viewing a plain text version of this content. The canonical link for it is here.
Posted to reviews@spark.apache.org by rik-coenders <gi...@git.apache.org> on 2017/08/02 10:00:17 UTC
[GitHub] spark pull request #18817: [SPARK-21612] Allow unicode strings in __getitem_...
GitHub user rik-coenders opened a pull request:
https://github.com/apache/spark/pull/18817
[SPARK-21612] Allow unicode strings in __getitem__ of StructType
## What changes were proposed in this pull request?
Check against `basestring` instead of `str`.
You can merge this pull request into a Git repository by running:
$ git pull https://github.com/rik-coenders/spark SPARK-21612
Alternatively you can review and apply these changes as the patch at:
https://github.com/apache/spark/pull/18817.patch
To close this pull request, make a commit to your master/trunk branch
with (at least) the following in the commit message:
This closes #18817
----
commit c655215c4e7ad3b458c003ca399919a640c80dec
Author: Rik Coenders <ri...@adchieve.com>
Date: 2017-08-02T09:57:35Z
[SPARK-21612] Allow unicode strings in __getitem__ of StructType
----
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
[GitHub] spark issue #18817: [SPARK-21612] Allow unicode strings in __getitem__ of St...
Posted by HyukjinKwon <gi...@git.apache.org>.
Github user HyukjinKwon commented on the issue:
https://github.com/apache/spark/pull/18817
I guess we really need a close investigation and thorough tests for this case. There are few PRs open for unicode support but I believe we have been finding few holes, even, including my PR. For example, please see https://github.com/apache/spark/pull/17096#issuecomment-283868146 and complete PR description with some tests.
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
[GitHub] spark pull request #18817: [SPARK-21612] Allow unicode strings in __getitem_...
Posted by rik-coenders <gi...@git.apache.org>.
Github user rik-coenders closed the pull request at:
https://github.com/apache/spark/pull/18817
---
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
[GitHub] spark issue #18817: [SPARK-21612] Allow unicode strings in __getitem__ of St...
Posted by AmplabJenkins <gi...@git.apache.org>.
Github user AmplabJenkins commented on the issue:
https://github.com/apache/spark/pull/18817
Can one of the admins verify this patch?
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
[GitHub] spark issue #18817: [SPARK-21612] Allow unicode strings in __getitem__ of St...
Posted by HyukjinKwon <gi...@git.apache.org>.
Github user HyukjinKwon commented on the issue:
https://github.com/apache/spark/pull/18817
ping @rik-coenders
---
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
[GitHub] spark issue #18817: [SPARK-21612] Allow unicode strings in __getitem__ of St...
Posted by rik-coenders <gi...@git.apache.org>.
Github user rik-coenders commented on the issue:
https://github.com/apache/spark/pull/18817
Unfortunately I do not have time to work on this issue at the moment, so I will close this PR for now.
---
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org