[jira] [Comment Edited] (IGNITE-4636) .NET: Support local collection joins in LINQ

["Pavel Tupitsyn (JIRA)" <ji...@apache.org>]

    [ https://issues.apache.org/jira/browse/IGNITE-4636?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16047721#comment-16047721 ] 

Pavel Tupitsyn edited comment on IGNITE-4636 at 6/13/17 10:42 AM:
------------------------------------------------------------------

[~GuruStron], looks good to me in general. Please fix code style a bit:
* Make sure all methods and classes have XMLDoc
* All method parameters are validated (Debug.Assert for internal stuff, IgniteArgumentCheck for user-facing APIs)
* All files have Apache license header
* EnumerableHelper should be internal, I think
* Source file line length limit is 120 chars
* Let's move JoinInnerSequenceParameterTransformingExpressionVisitor to a separate file (internal class in Impl folder). Better name is probably JoinInnerSequenceParameterNotNullExpressionVisitor.

Also can you please describe what works and what does not, what are current limitations?


was (Author: ptupitsyn):
Sergey, looks good to me in general. Please fix code style a bit:
1) Make sure all methods and classes have XMLDoc
2) All method parameters are validated (Debug.Assert for internal stuff, IgniteArgumentCheck for user-facing APIs)
3) All files have Apache license header
4) EnumerableHelper should be internal, I think
5) Source file line length limit is 120 chars
6) Let's move JoinInnerSequenceParameterTransformingExpressionVisitor to a separate file (internal class in Impl folder). Better name is probably JoinInnerSequenceParameterNotNullExpressionVisitor.

Also can you please describe what works and what does not, what are current limitations?

> .NET: Support local collection joins in LINQ
> --------------------------------------------
>
>                 Key: IGNITE-4636
>                 URL: https://issues.apache.org/jira/browse/IGNITE-4636
>             Project: Ignite
>          Issue Type: Improvement
>          Components: platforms
>    Affects Versions: 1.8
>            Reporter: Pavel Tupitsyn
>            Assignee: Sergey Stronchinskiy
>              Labels: .NET, LINQ
>             Fix For: 2.1
>
>
> LINQ {{IN}} clause is implemented in IGNITE-4425 and maps from {{ICollection.Contains}}.
> However, {{IN}} has some limitations in Ignite, and better alternative is temporary table join:
> https://apacheignite.readme.io/docs/sql-performance-and-debugging#sql-performance-and-usability-considerations
> Example SQL:
> {code}
> new SqlFieldsQuery("select p.name from Person p join table(id bigint = ?) i on p.OrgId = i.id", new object[] { new object[] {1,3}})
> {code}
> Add support in LINQ like this:
> {code}persons.AsCacheQueryable().Join(new[] {1, 3}, p => p.Value.OrgId, x => x, (p, x) => p);{code}



--
This message was sent by Atlassian JIRA
(v6.4.14#64029)