You are viewing a plain text version of this content. The canonical link for it is here.
Posted to reviews@mesos.apache.org by Andrei Budnik <ab...@mesosphere.com> on 2020/03/04 10:56:52 UTC
Review Request 72189: Updated nested mesos containerizer tests to
support `shared_cgroups`.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/72189/
-----------------------------------------------------------
Review request for mesos, Greg Mann and Qian Zhang.
Repository: mesos
Description
-------
Parametrized some `NestedMesosContainerizerTest` tests on whether we
are launching nested containers with `shared_cgroups=false` or not.
Previously, all nested containers shared cgroups with their parent by
default. Now, since we've added support for nested containers with
their own cgroups, we need to verify that a nested container with
`shared_cgroups=false` can be successfully launched and it does not
lead to errors during the recovery of Mesos containerizer.
Diffs
-----
src/tests/containerizer/nested_mesos_containerizer_tests.cpp c6f96e6b1bc0d9989ca87d23e112604820ac1d51
Diff: https://reviews.apache.org/r/72189/diff/1/
Testing
-------
Thanks,
Andrei Budnik
Re: Review Request 72189: Updated nested mesos containerizer tests to
support `shared_cgroups`.
Posted by Greg Mann <gr...@mesosphere.io>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/72189/#review219920
-----------------------------------------------------------
In commit message: s/shared_cgroups/share_cgroups/
- Greg Mann
On March 4, 2020, 10:56 a.m., Andrei Budnik wrote:
>
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/72189/
> -----------------------------------------------------------
>
> (Updated March 4, 2020, 10:56 a.m.)
>
>
> Review request for mesos, Greg Mann and Qian Zhang.
>
>
> Repository: mesos
>
>
> Description
> -------
>
> Parametrized some `NestedMesosContainerizerTest` tests on whether we
> are launching nested containers with `shared_cgroups=false` or not.
> Previously, all nested containers shared cgroups with their parent by
> default. Now, since we've added support for nested containers with
> their own cgroups, we need to verify that a nested container with
> `shared_cgroups=false` can be successfully launched and it does not
> lead to errors during the recovery of Mesos containerizer.
>
>
> Diffs
> -----
>
> src/tests/containerizer/nested_mesos_containerizer_tests.cpp c6f96e6b1bc0d9989ca87d23e112604820ac1d51
>
>
> Diff: https://reviews.apache.org/r/72189/diff/4/
>
>
> Testing
> -------
>
>
> Thanks,
>
> Andrei Budnik
>
>
Re: Review Request 72189: Updated nested mesos containerizer tests to
support `shared_cgroups`.
Posted by Qian Zhang <zh...@gmail.com>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/72189/#review219918
-----------------------------------------------------------
Ship it!
Ship It!
- Qian Zhang
On March 4, 2020, 6:56 p.m., Andrei Budnik wrote:
>
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/72189/
> -----------------------------------------------------------
>
> (Updated March 4, 2020, 6:56 p.m.)
>
>
> Review request for mesos, Greg Mann and Qian Zhang.
>
>
> Repository: mesos
>
>
> Description
> -------
>
> Parametrized some `NestedMesosContainerizerTest` tests on whether we
> are launching nested containers with `shared_cgroups=false` or not.
> Previously, all nested containers shared cgroups with their parent by
> default. Now, since we've added support for nested containers with
> their own cgroups, we need to verify that a nested container with
> `shared_cgroups=false` can be successfully launched and it does not
> lead to errors during the recovery of Mesos containerizer.
>
>
> Diffs
> -----
>
> src/tests/containerizer/nested_mesos_containerizer_tests.cpp c6f96e6b1bc0d9989ca87d23e112604820ac1d51
>
>
> Diff: https://reviews.apache.org/r/72189/diff/2/
>
>
> Testing
> -------
>
>
> Thanks,
>
> Andrei Budnik
>
>