You are viewing a plain text version of this content. The canonical link for it is here.
Posted to commits@pulsar.apache.org by GitBox <gi...@apache.org> on 2020/07/05 15:32:17 UTC
[GitHub] [pulsar-client-go] liangyuanpeng opened a new issue #306: Should clear Error/Warn log
liangyuanpeng opened a new issue #306:
URL: https://github.com/apache/pulsar-client-go/issues/306
#### Expected behavior
Got detail error message when connection failed.
#### Actual behavior
Just got `WARN[0000] Failed to perform initial handshake - Expecting 'Connected' cmd, got 'ERROR' local_addr="192.168.1.11:49262" remote_addr="pulsar://192.168.1.11:6560"`
#### Steps to reproduce
How can we reproduce the issue
#### System configuration
**Pulsar version**: x.y
#### Other
connection.go#doHandshake
```
if cmd.Connected == nil {
c.log.Warnf("Failed to perform initial handshake - Expecting 'Connected' cmd, got '%s' ",
cmd.Type)
return false
}
```
Why can't we use `cmd.GetError()`
```
if cmd.Connected == nil {
c.log.Warnf("Failed to perform initial handshake - Expecting 'Connected' cmd, got '%s' ",
cmd.GetError())
return false
}
```
and it can let me got `WARN[0000] Failed to perform initial handshake - Expecting 'Connected' cmd, got 'request_id:18446744073709551615 error:AuthenticationError message:"Unable to authenticate" ' local_addr="192.168.1.11:50334" remote_addr="pulsar://192.168.1.11:6560"`. Maybe it should be `Error` instead of `Warn`.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [pulsar-client-go] wolfstudy commented on issue #306: Should clear Error/Warn log
Posted by GitBox <gi...@apache.org>.
wolfstudy commented on issue #306:
URL: https://github.com/apache/pulsar-client-go/issues/306#issuecomment-653971729
Thanks to @liangyuanpeng feedback. Can you send a pull request to fix the issue?
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [pulsar-client-go] wolfstudy closed issue #306: Should clear Error/Warn log
Posted by GitBox <gi...@apache.org>.
wolfstudy closed issue #306:
URL: https://github.com/apache/pulsar-client-go/issues/306
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [pulsar-client-go] liangyuanpeng commented on issue #306: Should clear Error/Warn log
Posted by GitBox <gi...@apache.org>.
liangyuanpeng commented on issue #306:
URL: https://github.com/apache/pulsar-client-go/issues/306#issuecomment-654014261
@wolfstudy Yeah, i will. Thanks for your reply.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org