You are viewing a plain text version of this content. The canonical link for it is here.
Posted to notifications@dubbo.apache.org by "lixiaojiee (GitHub)" <gi...@apache.org> on 2019/01/03 06:01:23 UTC
[GitHub] [incubator-dubbo] lixiaojiee opened pull request #3120:
monitor optimize and add java doc
# What is the purpose of the change
some optimize about monitor module and add some java doc #2997
## Brief changelog
/dubbo-monitor-api/src/main/java/org/apache/dubbo/monitor/support/AbstractMonitorFactory.java
/dubbo-monitor-api/src/main/java/org/apache/dubbo/monitor/support/MonitorFilter.java
/dubbo-monitor-default/src/main/java/org/apache/dubbo/monitor/dubbo/DubboMonitor.java
## Verifying this change
unit test pass
Follow this checklist to help us incorporate your contribution quickly and easily:
- [x] Make sure there is a [GITHUB_issue](https://github.com/apache/incubator-dubbo/issues) field for the change (usually before you start working on it). Trivial changes like typos do not require a GITHUB issue. Your pull request should address just this issue, without pulling in other changes - one PR resolves one issue.
- [ ] Format the pull request title like `[Dubbo-XXX] Fix UnknownException when host config not exist #XXX`. Each commit in the pull request should have a meaningful subject line and body.
- [ ] Write a pull request description that is detailed enough to understand what the pull request does, how, and why.
- [ ] Write necessary unit-test to verify your logic correction, more mock a little better when cross module dependency exist. If the new feature or significant change is committed, please remember to add integration-test in [test module](https://github.com/apache/incubator-dubbo/tree/master/dubbo-test).
- [ ] Run `mvn clean install -DskipTests=false` & `mvn clean test-compile failsafe:integration-test` to make sure unit-test and integration-test pass.
- [ ] If this contribution is large, please follow the [Software Donation Guide](https://github.com/apache/incubator-dubbo/wiki/Software-donation-guide).
[ Full content available at: https://github.com/apache/incubator-dubbo/pull/3120 ]
This message was relayed via gitbox.apache.org for notifications@dubbo.apache.org
[GitHub] [incubator-dubbo] lixiaojiee commented on issue #3120:
monitor optimize and add java doc
Posted by "lixiaojiee (GitHub)" <gi...@apache.org>.
repeat commit
[ Full content available at: https://github.com/apache/incubator-dubbo/pull/3120 ]
This message was relayed via gitbox.apache.org for notifications@dubbo.apache.org
[GitHub] [incubator-dubbo] lixiaojiee closed pull request #3120:
monitor optimize and add java doc
Posted by "lixiaojiee (GitHub)" <gi...@apache.org>.
[ pull request closed by lixiaojiee ]
[ Full content available at: https://github.com/apache/incubator-dubbo/pull/3120 ]
This message was relayed via gitbox.apache.org for notifications@dubbo.apache.org