You are viewing a plain text version of this content. The canonical link for it is here.
Posted to dev@phoenix.apache.org by michfr <gi...@git.apache.org> on 2015/02/24 04:08:49 UTC
[GitHub] phoenix pull request: Additional DATE tests
GitHub user michfr opened a pull request:
https://github.com/apache/phoenix/pull/38
Additional DATE tests
You can merge this pull request into a Git repository by running:
$ git pull https://github.com/michfr/phoenix master
Alternatively you can review and apply these changes as the patch at:
https://github.com/apache/phoenix/pull/38.patch
To close this pull request, make a commit to your master/trunk branch
with (at least) the following in the commit message:
This closes #38
----
commit 9d8af3bbbd9f6102f5adbcee58ff85652975424d
Author: mike.friedman <mi...@192.168.0.169>
Date: 2015-02-24T02:48:41Z
Add some DATE-related tests.
commit 31466d490f8f152d81bbf9e9a1c78d61f4316406
Author: mike.friedman <mi...@192.168.0.169>
Date: 2015-02-24T03:06:10Z
More DATE tests.
----
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---
[GitHub] phoenix pull request: Additional DATE tests
Posted by michfr <gi...@git.apache.org>.
Github user michfr closed the pull request at:
https://github.com/apache/phoenix/pull/38
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---
[GitHub] phoenix pull request: Additional DATE tests
Posted by JamesRTaylor <gi...@git.apache.org>.
Github user JamesRTaylor commented on a diff in the pull request:
https://github.com/apache/phoenix/pull/38#discussion_r26443330
--- Diff: phoenix-core/src/it/java/org/apache/phoenix/end2end/QueryIT.java ---
@@ -295,6 +299,130 @@ public void testTimestamp() throws Exception {
}
@Test
+ public void testDateBetweenLiterals() throws Exception {
--- End diff --
Tests look good, but let's put them in a new class derived from BaseHBaseManagedTimeIT as we're trying to move away from tests that manage the timestamp through the CURRENT_SCN since it's much less common than just letting HBase manage the timestamps. It's also easier to write your test, because you can just open a single connection and do everything on it.
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---
[GitHub] phoenix pull request: Additional DATE tests
Posted by michfr <gi...@git.apache.org>.
Github user michfr commented on the pull request:
https://github.com/apache/phoenix/pull/38#issuecomment-75690857
Here are some additional date tests.
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---
[GitHub] phoenix pull request: Additional DATE tests
Posted by michfr <gi...@git.apache.org>.
Github user michfr closed the pull request at:
https://github.com/apache/phoenix/pull/38
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---
[GitHub] phoenix pull request: Additional DATE tests
Posted by michfr <gi...@git.apache.org>.
GitHub user michfr reopened a pull request:
https://github.com/apache/phoenix/pull/38
Additional DATE tests
In support of the recent feature to support ANSI SQL date literals, here are some tests to add to the existing ones.
You can merge this pull request into a Git repository by running:
$ git pull https://github.com/michfr/phoenix master
Alternatively you can review and apply these changes as the patch at:
https://github.com/apache/phoenix/pull/38.patch
To close this pull request, make a commit to your master/trunk branch
with (at least) the following in the commit message:
This closes #38
----
commit 9d8af3bbbd9f6102f5adbcee58ff85652975424d
Author: mike.friedman <mi...@192.168.0.169>
Date: 2015-02-24T02:48:41Z
Add some DATE-related tests.
commit 31466d490f8f152d81bbf9e9a1c78d61f4316406
Author: mike.friedman <mi...@192.168.0.169>
Date: 2015-02-24T03:06:10Z
More DATE tests.
----
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---