[jira] [Commented] (SAMZA-340) Support metrics report via Graphite

["Luis Casillas (JIRA)" <ji...@apache.org>]

    [ https://issues.apache.org/jira/browse/SAMZA-340?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=14959432#comment-14959432 ] 

Luis Casillas commented on SAMZA-340:
-------------------------------------

I hacked together a quick-and-dirty metrics reporter and I'm also running into the `getMax()` exception reported above.  I looked at the code (0.9.1) and I do spot this problem:

    public Snapshot(Collection<Long> values) {
      this.values = new ArrayList<Long>(values);
      this.size = values.size();    // should be `this.size = this.values.size()`
      Collections.sort(this.values);
    }

That is, the size of the original `Collection` may change between the first and the second line, so the size should be computed off the copy.

> Support metrics report via Graphite
> -----------------------------------
>
>                 Key: SAMZA-340
>                 URL: https://issues.apache.org/jira/browse/SAMZA-340
>             Project: Samza
>          Issue Type: Improvement
>          Components: metrics
>    Affects Versions: 0.9.0
>            Reporter: Yan Fang
>            Assignee: Luis De Pombo
>              Labels: metrics
>         Attachments: SAMZA-340.patch, SAMZA-340.v2.patch, SAMZA-340.v3.patch
>
>
> Currently we only support metrics report via JMX, it is helpful to support more output formats.  



--
This message was sent by Atlassian JIRA
(v6.3.4#6332)