You are viewing a plain text version of this content. The canonical link for it is here.
Posted to commits@mesos.apache.org by br...@apache.org on 2013/09/17 18:52:48 UTC
git commit: Fixed build breakage from 37e946683f1bb6a.
Updated Branches:
refs/heads/master fbaa7319c -> 37c291194
Fixed build breakage from 37e946683f1bb6a.
In 37e946683f1bb6a I fixed a build failure from a warning, which are
treated as errors.
Newer versions of GCC have a feature (documented here:
http://gcc.gnu.org/onlinedocs/gcc/Warning-Options.html) where unknown
warning flags are ignored.
In older version of GCC (such as 4.1 or 4.2), it appears that these flags
aren't ignored, resulting in an error.
Review: https://reviews.apache.org/r/14164
Project: http://git-wip-us.apache.org/repos/asf/mesos/repo
Commit: http://git-wip-us.apache.org/repos/asf/mesos/commit/37c29119
Tree: http://git-wip-us.apache.org/repos/asf/mesos/tree/37c29119
Diff: http://git-wip-us.apache.org/repos/asf/mesos/diff/37c29119
Branch: refs/heads/master
Commit: 37c291194a290769446d2976aac9349651c69ff3
Parents: fbaa731
Author: Brenden Matthews <br...@airbnb.com>
Authored: Mon Sep 16 14:49:10 2013 -0700
Committer: Brenden Matthews <br...@airbnb.com>
Committed: Tue Sep 17 09:49:14 2013 -0700
----------------------------------------------------------------------
configure.ac | 18 ++++++++++--------
1 file changed, 10 insertions(+), 8 deletions(-)
----------------------------------------------------------------------
http://git-wip-us.apache.org/repos/asf/mesos/blob/37c29119/configure.ac
----------------------------------------------------------------------
diff --git a/configure.ac b/configure.ac
index 73baf03..96ac7a8 100644
--- a/configure.ac
+++ b/configure.ac
@@ -51,14 +51,6 @@ LT_OUTPUT
AS_IF([test "x${ac_cv_env_CFLAGS_set}" = "x"], [CFLAGS="-g"])
AS_IF([test "x${ac_cv_env_CXXFLAGS_set}" = "x"], [CXXFLAGS="-g"])
-# Boost 1.53.0 won't compile with GCC 4.8 without -Wno-unused-local-typedefs,
-# and automake doesn't recognize the flag.
-# TODO(brenden): remove this when Boost has a resolution.
-if test "x$GCC" = "xyes"; then
- CFLAGS="${CFLAGS} -Wno-unused-local-typedefs"
- CXXFLAGS="${CXXFLAGS} -Wno-unused-local-typedefs"
-fi
-
# Save the configure arguments so we can pass them to any third-party
# libraries that we might run configure on (see
# 3rdparty/Makefile.am). One downside of our strategy for shipping and
@@ -216,6 +208,16 @@ case "${GCC_VERSION}" in
CFLAGS="$CFLAGS -fno-strict-aliasing"
CXXFLAGS="$CXXFLAGS -fno-strict-aliasing"
;;
+ 4.8*)
+ echo ===========================================================
+ echo Setting up CXXFLAGS for gcc 4.8.*
+ echo ===========================================================
+ # Boost 1.53.0 won't compile with GCC 4.8 without -Wno-unused-local-typedefs,
+ # and automake doesn't recognize the flag.
+ # TODO(brenden): Remove this when Boost has a resolution.
+ CFLAGS="${CFLAGS} -Wno-unused-local-typedefs"
+ CXXFLAGS="${CXXFLAGS} -Wno-unused-local-typedefs"
+ ;;
esac