You are viewing a plain text version of this content. The canonical link for it is here.
Posted to dev@qpid.apache.org by "Robbie Gemmell (JIRA)" <ji...@apache.org> on 2011/08/04 13:47:28 UTC
[jira] [Created] (QPID-3390) the Java broker does not validate the
exchange-declare arguments are supported
the Java broker does not validate the exchange-declare arguments are supported
------------------------------------------------------------------------------
Key: QPID-3390
URL: https://issues.apache.org/jira/browse/QPID-3390
Project: Qpid
Issue Type: Improvement
Components: Java Broker
Affects Versions: 0.10, 0.9, 0.8, 0.7, 0.6, 0.11, 0.12
Reporter: Robbie Gemmell
Assignee: Robbie Gemmell
Fix For: 0.13
The Java broker does not currently validate the arguments supplied are supported, and simply ignores ones which are not. The 0-10 spec requires that a 'NOT_IMPLEMENTED' session execution exception be raised when presented with an exchange declare argument the broker doesn't have knowledge of; this should be implemented.
--
This message is automatically generated by JIRA.
For more information on JIRA, see: http://www.atlassian.com/software/jira
---------------------------------------------------------------------
Apache Qpid - AMQP Messaging Implementation
Project: http://qpid.apache.org
Use/Interact: mailto:dev-subscribe@qpid.apache.org
[jira] [Issue Comment Edited] (QPID-3390) the Java broker does not
validate the exchange-declare arguments are supported
Posted by "Robbie Gemmell (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/QPID-3390?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13079360#comment-13079360 ]
Robbie Gemmell edited comment on QPID-3390 at 8/8/11 1:11 PM:
--------------------------------------------------------------
Hi Keith, can your review these changes please?
The broker now validates the exchange-declare arguments to ensure none are present, since we don't currently support any. If arguments are found, an executionException is raised indicating support for the arguments is not implemented.
A test was added to ensure the expected behaviour with nonsense argument, at the same time splitting 2 of the existing tests (which would now error due to the validation) into versions with valid arguments (for the C++ broker at least) and those with no arguments. This allows the rest of the functionality they test to be tested with the Java broker until such time as QPID-3392 is completed.
was (Author: gemmellr):
Hi Keith, can your review these changes please?
The broker now validates the exchange-declare arguments to ensure none are present, since we don't currently support any. If arguments are found, an executionException is raised indicating support for the arguments is not implemented.
A test was added to ensure the expected behaviour with nonsense argument, at the same time splitting 2 of the existing tests (which would now error due to the validation) into versions with valid arguments (for the C++ broker at least) and those with no arguments. This allows the rest of the functionality they test to be tested with the Java broker until such time as QPID-3092 is completed.
> the Java broker does not validate the exchange-declare arguments are supported
> ------------------------------------------------------------------------------
>
> Key: QPID-3390
> URL: https://issues.apache.org/jira/browse/QPID-3390
> Project: Qpid
> Issue Type: Bug
> Components: Java Broker
> Affects Versions: 0.6, 0.7, 0.8, 0.9, 0.10, 0.11, 0.12
> Reporter: Robbie Gemmell
> Assignee: Keith Wall
> Fix For: 0.13
>
>
> The Java broker does not currently validate the arguments supplied are supported, and simply ignores ones which are not known. The 0-10 spec requires that a 'NOT_IMPLEMENTED' session execution exception be raised when presented with an exchange declare argument the broker doesn't have knowledge of; this should be implemented.
--
This message is automatically generated by JIRA.
For more information on JIRA, see: http://www.atlassian.com/software/jira
---------------------------------------------------------------------
Apache Qpid - AMQP Messaging Implementation
Project: http://qpid.apache.org
Use/Interact: mailto:dev-subscribe@qpid.apache.org
[jira] [Updated] (QPID-3390) the Java broker does not validate the
exchange-declare arguments are supported
Posted by "Robbie Gemmell (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/QPID-3390?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ]
Robbie Gemmell updated QPID-3390:
---------------------------------
Issue Type: Bug (was: Improvement)
> the Java broker does not validate the exchange-declare arguments are supported
> ------------------------------------------------------------------------------
>
> Key: QPID-3390
> URL: https://issues.apache.org/jira/browse/QPID-3390
> Project: Qpid
> Issue Type: Bug
> Components: Java Broker
> Affects Versions: 0.6, 0.7, 0.8, 0.9, 0.10, 0.11, 0.12
> Reporter: Robbie Gemmell
> Assignee: Robbie Gemmell
> Fix For: 0.13
>
>
> The Java broker does not currently validate the arguments supplied are supported, and simply ignores ones which are not. The 0-10 spec requires that a 'NOT_IMPLEMENTED' session execution exception be raised when presented with an exchange declare argument the broker doesn't have knowledge of; this should be implemented.
--
This message is automatically generated by JIRA.
For more information on JIRA, see: http://www.atlassian.com/software/jira
---------------------------------------------------------------------
Apache Qpid - AMQP Messaging Implementation
Project: http://qpid.apache.org
Use/Interact: mailto:dev-subscribe@qpid.apache.org
[jira] [Resolved] (QPID-3390) the Java broker does not validate the
exchange-declare arguments are supported
Posted by "Keith Wall (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/QPID-3390?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ]
Keith Wall resolved QPID-3390.
------------------------------
Resolution: Fixed
Hi Robbie,
I've reviewed the change and I have no comments.
cheers Keith.
> the Java broker does not validate the exchange-declare arguments are supported
> ------------------------------------------------------------------------------
>
> Key: QPID-3390
> URL: https://issues.apache.org/jira/browse/QPID-3390
> Project: Qpid
> Issue Type: Bug
> Components: Java Broker
> Affects Versions: 0.6, 0.7, 0.8, 0.9, 0.10, 0.11, 0.12
> Reporter: Robbie Gemmell
> Assignee: Keith Wall
> Fix For: 0.13
>
>
> The Java broker does not currently validate the arguments supplied are supported, and simply ignores ones which are not known. The 0-10 spec requires that a 'NOT_IMPLEMENTED' session execution exception be raised when presented with an exchange declare argument the broker doesn't have knowledge of; this should be implemented.
--
This message is automatically generated by JIRA.
For more information on JIRA, see: http://www.atlassian.com/software/jira
---------------------------------------------------------------------
Apache Qpid - AMQP Messaging Implementation
Project: http://qpid.apache.org
Use/Interact: mailto:dev-subscribe@qpid.apache.org
[jira] [Assigned] (QPID-3390) the Java broker does not validate the
exchange-declare arguments are supported
Posted by "Robbie Gemmell (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/QPID-3390?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ]
Robbie Gemmell reassigned QPID-3390:
------------------------------------
Assignee: Keith Wall (was: Robbie Gemmell)
Hi Keith, can your review these changes please?
The broker now validates the exchange-declare arguments to ensure none are present, since we don't currently support any. If arguments are found, an executionException is raised indicating support for the arguments is not implemented.
A test was added to ensure the expected behaviour with nonsense argument, at the same time splitting 2 of the existing tests (which would now error due to the validation) into versions with valid arguments (for the C++ broker at least) and those with no arguments. This allows the rest of the functionality they test to be tested with the Java broker until such time as QPID-3092 is completed.
> the Java broker does not validate the exchange-declare arguments are supported
> ------------------------------------------------------------------------------
>
> Key: QPID-3390
> URL: https://issues.apache.org/jira/browse/QPID-3390
> Project: Qpid
> Issue Type: Bug
> Components: Java Broker
> Affects Versions: 0.6, 0.7, 0.8, 0.9, 0.10, 0.11, 0.12
> Reporter: Robbie Gemmell
> Assignee: Keith Wall
> Fix For: 0.13
>
>
> The Java broker does not currently validate the arguments supplied are supported, and simply ignores ones which are not. The 0-10 spec requires that a 'NOT_IMPLEMENTED' session execution exception be raised when presented with an exchange declare argument the broker doesn't have knowledge of; this should be implemented.
--
This message is automatically generated by JIRA.
For more information on JIRA, see: http://www.atlassian.com/software/jira
---------------------------------------------------------------------
Apache Qpid - AMQP Messaging Implementation
Project: http://qpid.apache.org
Use/Interact: mailto:dev-subscribe@qpid.apache.org
[jira] [Updated] (QPID-3390) the Java broker does not validate the
exchange-declare arguments are supported
Posted by "Robbie Gemmell (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/QPID-3390?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ]
Robbie Gemmell updated QPID-3390:
---------------------------------
Status: Ready To Review (was: In Progress)
> the Java broker does not validate the exchange-declare arguments are supported
> ------------------------------------------------------------------------------
>
> Key: QPID-3390
> URL: https://issues.apache.org/jira/browse/QPID-3390
> Project: Qpid
> Issue Type: Bug
> Components: Java Broker
> Affects Versions: 0.6, 0.7, 0.8, 0.9, 0.10, 0.11, 0.12
> Reporter: Robbie Gemmell
> Assignee: Robbie Gemmell
> Fix For: 0.13
>
>
> The Java broker does not currently validate the arguments supplied are supported, and simply ignores ones which are not. The 0-10 spec requires that a 'NOT_IMPLEMENTED' session execution exception be raised when presented with an exchange declare argument the broker doesn't have knowledge of; this should be implemented.
--
This message is automatically generated by JIRA.
For more information on JIRA, see: http://www.atlassian.com/software/jira
---------------------------------------------------------------------
Apache Qpid - AMQP Messaging Implementation
Project: http://qpid.apache.org
Use/Interact: mailto:dev-subscribe@qpid.apache.org
[jira] [Updated] (QPID-3390) the Java broker does not validate the
exchange-declare arguments are supported
Posted by "Robbie Gemmell (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/QPID-3390?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ]
Robbie Gemmell updated QPID-3390:
---------------------------------
Description: The Java broker does not currently validate the arguments supplied are supported, and simply ignores ones which are not known. The 0-10 spec requires that a 'NOT_IMPLEMENTED' session execution exception be raised when presented with an exchange declare argument the broker doesn't have knowledge of; this should be implemented. (was: The Java broker does not currently validate the arguments supplied are supported, and simply ignores ones which are not. The 0-10 spec requires that a 'NOT_IMPLEMENTED' session execution exception be raised when presented with an exchange declare argument the broker doesn't have knowledge of; this should be implemented.)
> the Java broker does not validate the exchange-declare arguments are supported
> ------------------------------------------------------------------------------
>
> Key: QPID-3390
> URL: https://issues.apache.org/jira/browse/QPID-3390
> Project: Qpid
> Issue Type: Bug
> Components: Java Broker
> Affects Versions: 0.6, 0.7, 0.8, 0.9, 0.10, 0.11, 0.12
> Reporter: Robbie Gemmell
> Assignee: Keith Wall
> Fix For: 0.13
>
>
> The Java broker does not currently validate the arguments supplied are supported, and simply ignores ones which are not known. The 0-10 spec requires that a 'NOT_IMPLEMENTED' session execution exception be raised when presented with an exchange declare argument the broker doesn't have knowledge of; this should be implemented.
--
This message is automatically generated by JIRA.
For more information on JIRA, see: http://www.atlassian.com/software/jira
---------------------------------------------------------------------
Apache Qpid - AMQP Messaging Implementation
Project: http://qpid.apache.org
Use/Interact: mailto:dev-subscribe@qpid.apache.org