You are viewing a plain text version of this content. The canonical link for it is here.
Posted to commits@ofbiz.apache.org by jl...@apache.org on 2017/12/13 13:09:53 UTC

svn commit: r1818010 - /ofbiz/ofbiz-framework/trunk/framework/entity/src/main/java/org/apache/ofbiz/entity/util/EntitySaxReader.java

Author: jleroux
Date: Wed Dec 13 13:09:52 2017
New Revision: 1818010

URL: http://svn.apache.org/viewvc?rev=1818010&view=rev
Log:
Improved: Always check if debug verbose is on when using Debug.logVerbose()
(OFBIZ-10052)

As spotted by Nicolas and reported on dev ML there was a case w/ a double check
This removes it

Modified:
    ofbiz/ofbiz-framework/trunk/framework/entity/src/main/java/org/apache/ofbiz/entity/util/EntitySaxReader.java

Modified: ofbiz/ofbiz-framework/trunk/framework/entity/src/main/java/org/apache/ofbiz/entity/util/EntitySaxReader.java
URL: http://svn.apache.org/viewvc/ofbiz/ofbiz-framework/trunk/framework/entity/src/main/java/org/apache/ofbiz/entity/util/EntitySaxReader.java?rev=1818010&r1=1818009&r2=1818010&view=diff
==============================================================================
--- ofbiz/ofbiz-framework/trunk/framework/entity/src/main/java/org/apache/ofbiz/entity/util/EntitySaxReader.java (original)
+++ ofbiz/ofbiz-framework/trunk/framework/entity/src/main/java/org/apache/ofbiz/entity/util/EntitySaxReader.java Wed Dec 13 13:09:52 2017
@@ -251,7 +251,7 @@ public class EntitySaxReader extends Def
         }
         Debug.logImportant("Finished " + numberRead + " values from " + docDescription, module);
         if (Debug.verboseOn()) { 
-            if (Debug.verboseOn()) Debug.logVerbose("  Detail created : " + numberCreated + ", skipped : " + numberSkipped +
+            Debug.logVerbose("  Detail created : " + numberCreated + ", skipped : " + numberSkipped +
                     ", updated : " + numberUpdated + ", replaced : " + numberReplaced +
                     ", deleted : " + numberDeleted, module);
         }



Re: svn commit: r1818010 - /ofbiz/ofbiz-framework/trunk/framework/entity/src/main/java/org/apache/ofbi z/entity/util/EntitySaxReader.java

Posted by Jacques Le Roux <ja...@les7arts.com>.
Le 13/12/2017 à 14:14, Jacques Le Roux a écrit :
> Le 13/12/2017 à 14:09, jleroux@apache.org a écrit :
>> Author: jleroux
>> Date: Wed Dec 13 13:09:52 2017
>> New Revision: 1818010
>>
>> URL: http://svn.apache.org/viewvc?rev=1818010&view=rev
>> Log:
>> Improved: Always check if debug verbose is on when using Debug.logVerbose()
>> (OFBIZ-10052)
>>
>> As spotted by Nicolas and reported on dev ML there was a case w/ a double check
>> This removes it
> Actually not sure how I missed them, but there are much more cases. I'll improve that soon...
>
> Jacques
>
Completed: At revision: 1818020

Jacques


Re: svn commit: r1818010 - /ofbiz/ofbiz-framework/trunk/framework/entity/src/main/java/org/apache/ofbi z/entity/util/EntitySaxReader.java

Posted by Jacques Le Roux <ja...@les7arts.com>.
Le 13/12/2017 à 14:09, jleroux@apache.org a écrit :
> Author: jleroux
> Date: Wed Dec 13 13:09:52 2017
> New Revision: 1818010
>
> URL: http://svn.apache.org/viewvc?rev=1818010&view=rev
> Log:
> Improved: Always check if debug verbose is on when using Debug.logVerbose()
> (OFBIZ-10052)
>
> As spotted by Nicolas and reported on dev ML there was a case w/ a double check
> This removes it
Actually not sure how I missed them, but there are much more cases. I'll improve that soon...

Jacques