You are viewing a plain text version of this content. The canonical link for it is here.
Posted to oak-dev@jackrabbit.apache.org by Julian Reschke <re...@apache.org> on 2025/01/12 21:55:15 UTC

[VOTE] Release Apache Jackrabbit Oak 1.74.0

A candidate for the Jackrabbit Oak 1.74.0 release is available at:

     https://dist.apache.org/repos/dist/dev/jackrabbit/oak/1.74.0/

The release candidate is a zip archive of the sources in:

      https://github.com/apache/jackrabbit-oak/tree/jackrabbit-oak-1.74.0/

The SHA1 checksum of the archive is 
cbdc8448ac8cb5f402ef498ced872f49877f2d0b.

A staged Maven repository is available for review at:

     https://repository.apache.org/

The command for running automated checks against this release candidate is:

     # run in SVN checkout of 
https://dist.apache.org/repos/dist/dev/jackrabbit
     $ sh check-release.sh oak 1.74.0 
cbdc8448ac8cb5f402ef498ced872f49877f2d0b

Please vote on releasing this package as Apache Jackrabbit Oak 1.74.0.
The vote is open for the next 72 hours and passes if a majority of at
least three +1 Jackrabbit PMC votes are cast.

     [ ] +1 Release this package as Apache Jackrabbit Oak 1.74.0
     [ ] -1 Do not release this package because...

Best regards, Julian

Re: [VOTE] Release Apache Jackrabbit Oak 1.74.0

Posted by Julian Reschke <ju...@gmail.com>.
On 14.01.2025 11:38, Konrad Windszus wrote:
> Hi
> Although the build was finally successfu it took 1 hour 24 minutes on my computer and emitted 31 MB of build log.
> I consider this a state we should definitely revisit.

Yes.

> I am not in favour of releasing the code base in this state.
> However, I am not blocking this release but I would appreciate at least a revisit of check style and the longest running ITs to achieve

This is not a regression; it's an issue we have lived with for quite 
some time. In the last year it has become worse by the ultra-long 
VersionGarbageColl*IT.

> - a build log with a decent size
> - a build not taking longer than 45 minutes

Best regards, Julian


Re: [VOTE] Release Apache Jackrabbit Oak 1.74.0

Posted by Konrad Windszus <kw...@apache.org>.
Hi
Although the build was finally successfu it took 1 hour 24 minutes on my computer and emitted 31 MB of build log.
I consider this a state we should definitely revisit.

I am not in favour of releasing the code base in this state.
However, I am not blocking this release but I would appreciate at least a revisit of check style and the longest running ITs to achieve

- a build log with a decent size
- a build not taking longer than 45 minutes

Thanks,
Konrad


> On 12. Jan 2025, at 22:55, Julian Reschke <re...@apache.org> wrote:
> 
> A candidate for the Jackrabbit Oak 1.74.0 release is available at:
> 
>    https://dist.apache.org/repos/dist/dev/jackrabbit/oak/1.74.0/
> 
> The release candidate is a zip archive of the sources in:
> 
>     https://github.com/apache/jackrabbit-oak/tree/jackrabbit-oak-1.74.0/
> 
> The SHA1 checksum of the archive is cbdc8448ac8cb5f402ef498ced872f49877f2d0b.
> 
> A staged Maven repository is available for review at:
> 
>    https://repository.apache.org/
> 
> The command for running automated checks against this release candidate is:
> 
>    # run in SVN checkout of https://dist.apache.org/repos/dist/dev/jackrabbit
>    $ sh check-release.sh oak 1.74.0 cbdc8448ac8cb5f402ef498ced872f49877f2d0b
> 
> Please vote on releasing this package as Apache Jackrabbit Oak 1.74.0.
> The vote is open for the next 72 hours and passes if a majority of at
> least three +1 Jackrabbit PMC votes are cast.
> 
>    [ ] +1 Release this package as Apache Jackrabbit Oak 1.74.0
>    [ ] -1 Do not release this package because...
> 
> Best regards, Julian


Re: [VOTE] Release Apache Jackrabbit Oak 1.74.0

Posted by Rishabh Daim <da...@apache.org>.
+1

Thanks
Rishabh Daim

On 2025/01/14 09:05:36 Jörg Hoh wrote:
> +1
> 
> [INFO]
> ------------------------------------------------------------------------
> [INFO] Apache Maven 3.9.9 (8e8579a9e76f7d015ee5ec7bfcdc97d260186937)
> [INFO] OS name: "mac os x", version: "15.2", arch: "x86_64", family: "mac"
> [INFO] Java version: 11.0.21, vendor: Eclipse Adoptium, runtime:
> /Users/joerg/java/jdk-11.0.21+9-amd64/Contents/Home
> [INFO] MAVEN_OPTS: -Xmx2g
> [INFO]
> ------------------------------------------------------------------------
> [INFO] ALL CHECKS OK
> 
> Am So., 12. Jan. 2025 um 22:55 Uhr schrieb Julian Reschke <
> reschke@apache.org>:
> 
> > A candidate for the Jackrabbit Oak 1.74.0 release is available at:
> >
> >      https://dist.apache.org/repos/dist/dev/jackrabbit/oak/1.74.0/
> >
> > The release candidate is a zip archive of the sources in:
> >
> >       https://github.com/apache/jackrabbit-oak/tree/jackrabbit-oak-1.74.0/
> >
> > The SHA1 checksum of the archive is
> > cbdc8448ac8cb5f402ef498ced872f49877f2d0b.
> >
> > A staged Maven repository is available for review at:
> >
> >      https://repository.apache.org/
> >
> > The command for running automated checks against this release candidate is:
> >
> >      # run in SVN checkout of
> > https://dist.apache.org/repos/dist/dev/jackrabbit
> >      $ sh check-release.sh oak 1.74.0
> > cbdc8448ac8cb5f402ef498ced872f49877f2d0b
> >
> > Please vote on releasing this package as Apache Jackrabbit Oak 1.74.0.
> > The vote is open for the next 72 hours and passes if a majority of at
> > least three +1 Jackrabbit PMC votes are cast.
> >
> >      [ ] +1 Release this package as Apache Jackrabbit Oak 1.74.0
> >      [ ] -1 Do not release this package because...
> >
> > Best regards, Julian
> >
> 
> 
> -- 
> https://cqdump.joerghoh.de
> 

Re: [VOTE] Release Apache Jackrabbit Oak 1.74.0

Posted by Jörg Hoh <jh...@googlemail.com.INVALID>.
+1

[INFO]
------------------------------------------------------------------------
[INFO] Apache Maven 3.9.9 (8e8579a9e76f7d015ee5ec7bfcdc97d260186937)
[INFO] OS name: "mac os x", version: "15.2", arch: "x86_64", family: "mac"
[INFO] Java version: 11.0.21, vendor: Eclipse Adoptium, runtime:
/Users/joerg/java/jdk-11.0.21+9-amd64/Contents/Home
[INFO] MAVEN_OPTS: -Xmx2g
[INFO]
------------------------------------------------------------------------
[INFO] ALL CHECKS OK

Am So., 12. Jan. 2025 um 22:55 Uhr schrieb Julian Reschke <
reschke@apache.org>:

> A candidate for the Jackrabbit Oak 1.74.0 release is available at:
>
>      https://dist.apache.org/repos/dist/dev/jackrabbit/oak/1.74.0/
>
> The release candidate is a zip archive of the sources in:
>
>       https://github.com/apache/jackrabbit-oak/tree/jackrabbit-oak-1.74.0/
>
> The SHA1 checksum of the archive is
> cbdc8448ac8cb5f402ef498ced872f49877f2d0b.
>
> A staged Maven repository is available for review at:
>
>      https://repository.apache.org/
>
> The command for running automated checks against this release candidate is:
>
>      # run in SVN checkout of
> https://dist.apache.org/repos/dist/dev/jackrabbit
>      $ sh check-release.sh oak 1.74.0
> cbdc8448ac8cb5f402ef498ced872f49877f2d0b
>
> Please vote on releasing this package as Apache Jackrabbit Oak 1.74.0.
> The vote is open for the next 72 hours and passes if a majority of at
> least three +1 Jackrabbit PMC votes are cast.
>
>      [ ] +1 Release this package as Apache Jackrabbit Oak 1.74.0
>      [ ] -1 Do not release this package because...
>
> Best regards, Julian
>


-- 
https://cqdump.joerghoh.de

Re: [VOTE] Release Apache Jackrabbit Oak 1.74.0

Posted by Julian Reschke <ju...@gmail.com>.
On 14.01.2025 11:18, Konrad Windszus wrote:
> Hi,
> I see lots of checkstyle errors during building:
> 
> "[INFO] --- checkstyle:3.5.0:check (default) @ oak-jackrabbit-api ---
> [INFO] There are 761 errors reported by Checkstyle 9.3 with sun_checks.xml ruleset.
> [ERROR] src/main/java/org/apache/jackrabbit/api/JackrabbitRepository.java:[41] (sizes) LineLength: Line is longer than 80 characters (found 81).
> [ERROR] src/main/java/org/apache/jackrabbit/api/JackrabbitRepository.java:[47] (sizes) LineLength: Line is longer than 80 characters (found 91).”
> 
> I don’t remember them being reported before.
> But IMHO every error should break the build, otherwise the severity should be lowered.
> I have a log of 28 MB with profile “pedantic” which is obviously to big too skim through it.
> 
> Has anything changed in this regard recently?
> 
> Thanks,
> Konrad

I don't think so. This issue has been around for a long time. And yes, 
we should fix it one way or the other.

Best regards, Julian


Re: [VOTE] Release Apache Jackrabbit Oak 1.74.0

Posted by Konrad Windszus <kw...@apache.org>.
Hi,
I see lots of checkstyle errors during building:

"[INFO] --- checkstyle:3.5.0:check (default) @ oak-jackrabbit-api ---
[INFO] There are 761 errors reported by Checkstyle 9.3 with sun_checks.xml ruleset.
[ERROR] src/main/java/org/apache/jackrabbit/api/JackrabbitRepository.java:[41] (sizes) LineLength: Line is longer than 80 characters (found 81).
[ERROR] src/main/java/org/apache/jackrabbit/api/JackrabbitRepository.java:[47] (sizes) LineLength: Line is longer than 80 characters (found 91).”

I don’t remember them being reported before.
But IMHO every error should break the build, otherwise the severity should be lowered.
I have a log of 28 MB with profile “pedantic” which is obviously to big too skim through it.

Has anything changed in this regard recently?

Thanks,
Konrad


> On 12. Jan 2025, at 22:55, Julian Reschke <re...@apache.org> wrote:
> 
> A candidate for the Jackrabbit Oak 1.74.0 release is available at:
> 
>    https://dist.apache.org/repos/dist/dev/jackrabbit/oak/1.74.0/
> 
> The release candidate is a zip archive of the sources in:
> 
>     https://github.com/apache/jackrabbit-oak/tree/jackrabbit-oak-1.74.0/
> 
> The SHA1 checksum of the archive is cbdc8448ac8cb5f402ef498ced872f49877f2d0b.
> 
> A staged Maven repository is available for review at:
> 
>    https://repository.apache.org/
> 
> The command for running automated checks against this release candidate is:
> 
>    # run in SVN checkout of https://dist.apache.org/repos/dist/dev/jackrabbit
>    $ sh check-release.sh oak 1.74.0 cbdc8448ac8cb5f402ef498ced872f49877f2d0b
> 
> Please vote on releasing this package as Apache Jackrabbit Oak 1.74.0.
> The vote is open for the next 72 hours and passes if a majority of at
> least three +1 Jackrabbit PMC votes are cast.
> 
>    [ ] +1 Release this package as Apache Jackrabbit Oak 1.74.0
>    [ ] -1 Do not release this package because...
> 
> Best regards, Julian


[RESULT[ VOTE] Release Apache Jackrabbit Oak 1.74.0

Posted by Julian Reschke <ju...@gmail.com>.
On 12.01.2025 22:55, Julian Reschke wrote:
> ...

Hi there,

The vote passes as follows:

+1 Jörg Hoh <jh...@googlemail.com>
+1 Julian Reschke <ju...@gmail.com>
+1 Manfred Baedke <ma...@gmail.com>
+1 Rishabh Daim <da...@apache.org>

Thanks for voting. I'll push the release out.

Best regards, Julian



Re: [VOTE] Release Apache Jackrabbit Oak 1.74.0

Posted by Julian Reschke <ju...@gmail.com>.
On 12.01.2025 22:55, Julian Reschke wrote:
> ...

[X] +1 Release this package as Apache Jackrabbit Oak 1.74.0

...where...

> [INFO] Apache Maven 3.6.3 (cecedd343002696d0abb50b32b541b8a6ba2883f)
> [INFO] OS name: "windows 10", version: "10.0", arch: "amd64", family: "windows"
> [INFO] Java version: 11.0.24, vendor: Oracle Corporation, runtime: C:\usr\local\jdk-11.0.24
> [INFO] MAVEN_OPTS: -Xmx2g

Best regards, Julian

Re: [VOTE] Release Apache Jackrabbit Oak 1.74.0

Posted by Manfred Baedke <ma...@gmail.com>.
[X] +1 Release this package as Apache Jackrabbit Oak 1.74.0

with

[INFO] Apache Maven 3.8.7
[INFO] OS name: "linux", version: "6.8.0-51-generic", arch: "amd64",
family: "unix"
[INFO] Java version: 11.0.25, vendor: Ubuntu, runtime:
/usr/lib/jvm/java-11-openjdk-amd64
[INFO] MAVEN_OPTS:
[INFO]
------------------------------------------------------------------------
[INFO] ALL CHECKS OK



Am So., 12. Jan. 2025 um 22:55 Uhr schrieb Julian Reschke <
reschke@apache.org>:

> A candidate for the Jackrabbit Oak 1.74.0 release is available at:
>
>      https://dist.apache.org/repos/dist/dev/jackrabbit/oak/1.74.0/
>
> The release candidate is a zip archive of the sources in:
>
>       https://github.com/apache/jackrabbit-oak/tree/jackrabbit-oak-1.74.0/
>
> The SHA1 checksum of the archive is
> cbdc8448ac8cb5f402ef498ced872f49877f2d0b.
>
> A staged Maven repository is available for review at:
>
>      https://repository.apache.org/
>
> The command for running automated checks against this release candidate is:
>
>      # run in SVN checkout of
> https://dist.apache.org/repos/dist/dev/jackrabbit
>      $ sh check-release.sh oak 1.74.0
> cbdc8448ac8cb5f402ef498ced872f49877f2d0b
>
> Please vote on releasing this package as Apache Jackrabbit Oak 1.74.0.
> The vote is open for the next 72 hours and passes if a majority of at
> least three +1 Jackrabbit PMC votes are cast.
>
>      [ ] +1 Release this package as Apache Jackrabbit Oak 1.74.0
>      [ ] -1 Do not release this package because...
>
> Best regards, Julian
>