You are viewing a plain text version of this content. The canonical link for it is here.
Posted to oak-commits@jackrabbit.apache.org by re...@apache.org on 2015/04/16 18:19:23 UTC
svn commit: r1674107 -
/jackrabbit/oak/trunk/oak-core/src/main/java/org/apache/jackrabbit/oak/plugins/nodetype/TypeEditorProvider.java
Author: reschke
Date: Thu Apr 16 16:19:23 2015
New Revision: 1674107
URL: http://svn.apache.org/r1674107
Log:
OAK-2781 - log time spent for repository scan upon node type change
Modified:
jackrabbit/oak/trunk/oak-core/src/main/java/org/apache/jackrabbit/oak/plugins/nodetype/TypeEditorProvider.java
Modified: jackrabbit/oak/trunk/oak-core/src/main/java/org/apache/jackrabbit/oak/plugins/nodetype/TypeEditorProvider.java
URL: http://svn.apache.org/viewvc/jackrabbit/oak/trunk/oak-core/src/main/java/org/apache/jackrabbit/oak/plugins/nodetype/TypeEditorProvider.java?rev=1674107&r1=1674106&r2=1674107&view=diff
==============================================================================
--- jackrabbit/oak/trunk/oak-core/src/main/java/org/apache/jackrabbit/oak/plugins/nodetype/TypeEditorProvider.java (original)
+++ jackrabbit/oak/trunk/oak-core/src/main/java/org/apache/jackrabbit/oak/plugins/nodetype/TypeEditorProvider.java Thu Apr 16 16:19:23 2015
@@ -34,11 +34,15 @@ import org.apache.jackrabbit.oak.spi.com
import org.apache.jackrabbit.oak.spi.commit.VisibleEditor;
import org.apache.jackrabbit.oak.spi.state.NodeBuilder;
import org.apache.jackrabbit.oak.spi.state.NodeState;
+import org.slf4j.Logger;
+import org.slf4j.LoggerFactory;
@Component
@Service(EditorProvider.class)
public class TypeEditorProvider implements EditorProvider {
+ private static final Logger LOG = LoggerFactory.getLogger(TypeEditorProvider.class);
+
private final boolean strict;
public TypeEditorProvider(boolean strict) {
@@ -69,6 +73,7 @@ public class TypeEditorProvider implemen
Set<String> modifiedTypes =
registration.getModifiedTypes(beforeTypes);
if (!modifiedTypes.isEmpty()) {
+ long start = System.currentTimeMillis();
// Some node types were modified, so scan the repository
// to make sure that the modified definitions still apply.
Editor editor = new VisibleEditor(new TypeEditor(
@@ -76,6 +81,8 @@ public class TypeEditorProvider implemen
primary, mixins, builder));
CommitFailedException exception =
EditorDiff.process(editor, MISSING_NODE, after);
+ LOG.info("Node type changes: " + modifiedTypes + "; repository scan took " + (System.currentTimeMillis() - start)
+ + "ms" + (exception == null ? "" : "; failed with " + exception.getMessage()));
if (exception != null) {
throw exception;
}
Re: svn commit: r1674107 - /jackrabbit/oak/trunk/oak-core/src/main/java/org/apache/jackrabbit/oak/plugins/nodetype/TypeEditorProvider.java
Posted by Chetan Mehrotra <ch...@gmail.com>.
On Thu, Apr 16, 2015 at 9:49 PM, <re...@apache.org> wrote:
> + LOG.info("Node type changes: " + modifiedTypes + "; repository scan took " + (System.currentTimeMillis() - start)
> + + "ms" + (exception == null ? "" : "; failed with " + exception.getMessage()));
It would be better to make use of PerfLogger here
Chetan Mehrotra