[GitHub] [incubator-opendal] Xuanwo commented on a diff in pull request #2314: refactor(core): Implement RFC-2299 for presign_read_with

["Xuanwo (via GitHub)" <gi...@apache.org>]

Xuanwo commented on code in PR #2314:
URL: https://github.com/apache/incubator-opendal/pull/2314#discussion_r1204689438


##########
core/src/types/operator/operator_futures.rs:
##########
@@ -215,6 +215,57 @@ impl Future for FutureAppender {
     }
 }
 
+/// Future that generated by [`Operator::presign_read_with`].
+///
+/// Users can add more options by public functions provided by this struct.
+pub struct FuturePresignRead(pub(crate) OperatorFuture<(OpRead, OpPresign), PresignedRequest>);

Review Comment:
   `OpPresign` should be built by `OpRead`, so we need `(OpRead, Duration)` here.



-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: commits-unsubscribe@opendal.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org