You are viewing a plain text version of this content. The canonical link for it is here.
Posted to commits@pulsar.apache.org by te...@apache.org on 2023/02/08 08:27:03 UTC

[pulsar] branch branch-2.11 updated: [fix][authorization] Fix the return value of canConsumeAsync (#19412)

This is an automated email from the ASF dual-hosted git repository.

technoboy pushed a commit to branch branch-2.11
in repository https://gitbox.apache.org/repos/asf/pulsar.git


The following commit(s) were added to refs/heads/branch-2.11 by this push:
     new 542a98ae534 [fix][authorization] Fix the return value of canConsumeAsync (#19412)
542a98ae534 is described below

commit 542a98ae53407e8ff128409d132f2173fa7daf13
Author: Zixuan Liu <no...@gmail.com>
AuthorDate: Tue Feb 7 17:49:55 2023 +0800

    [fix][authorization] Fix the return value of canConsumeAsync (#19412)
    
    Signed-off-by: Zixuan Liu <no...@gmail.com>
---
 .../broker/authorization/PulsarAuthorizationProvider.java     | 11 -----------
 1 file changed, 11 deletions(-)

diff --git a/pulsar-broker-common/src/main/java/org/apache/pulsar/broker/authorization/PulsarAuthorizationProvider.java b/pulsar-broker-common/src/main/java/org/apache/pulsar/broker/authorization/PulsarAuthorizationProvider.java
index 399ecc4a9f0..765835fde33 100644
--- a/pulsar-broker-common/src/main/java/org/apache/pulsar/broker/authorization/PulsarAuthorizationProvider.java
+++ b/pulsar-broker-common/src/main/java/org/apache/pulsar/broker/authorization/PulsarAuthorizationProvider.java
@@ -141,10 +141,6 @@ public class PulsarAuthorizationProvider implements AuthorizationProvider {
                         }
                     }
                     return checkAuthorization(topicName, role, AuthAction.consume);
-                }).exceptionally(ex -> {
-                    log.warn("Client with Role - {} failed to get permissions for topic - {}. {}", role, topicName,
-                            ex.getMessage());
-                    return null;
                 });
     }
 
@@ -167,13 +163,6 @@ public class PulsarAuthorizationProvider implements AuthorizationProvider {
                         return CompletableFuture.completedFuture(true);
                     }
                     return canConsumeAsync(topicName, role, authenticationData, null);
-                }).exceptionally(ex -> {
-                    if (log.isDebugEnabled()) {
-                        log.debug("Topic [{}] Role [{}] exception occurred while trying to check produce/consume"
-                                + " permissions. {}", topicName.toString(), role, ex.getMessage());
-
-                    }
-                    throw FutureUtil.wrapToCompletionException(ex);
                 });
     }