[GitHub] [pinot] Jackie-Jiang commented on a change in pull request #7798: Fixing Pinot Admin system exit logic

[GitBox <gi...@apache.org>]

Jackie-Jiang commented on a change in pull request #7798:
URL: https://github.com/apache/pinot/pull/7798#discussion_r752805143



##########
File path: pinot-tools/src/main/java/org/apache/pinot/tools/admin/PinotAdministrator.java
##########
@@ -138,7 +138,7 @@
       description = "Print the version of Pinot package.")
   boolean _version = false;
 
-  int _status = 0;
+  int _status = 1;

Review comment:
       (minor) add `private` to these 3 variables

##########
File path: pinot-tools/src/main/java/org/apache/pinot/tools/admin/PinotAdministrator.java
##########
@@ -190,13 +190,9 @@ public static void main(String[] args) {
     PluginManager.get().init();
     PinotAdministrator pinotAdministrator = new PinotAdministrator();
     pinotAdministrator.execute(args);
-    // Ignore `pinot.admin.system.exit` property for Pinot quickstarts.
-    if ((args.length > 0) && ("quickstart".equalsIgnoreCase(args[0]))) {
-      return;
-    }
-    if (Boolean.parseBoolean(System.getProperties().getProperty("pinot.admin.system.exit"))) {
-      // If status is true, cmd was successfully, so return 0 from process.
-      System.exit(pinotAdministrator._status);
+    if (Boolean.parseBoolean(System.getProperties().getProperty("pinot.admin.system.exit"))
+        && (pinotAdministrator._status != 0)) {

Review comment:
       (minor) suggest switch the check order
   ```suggestion
       if (pinotAdministrator._status != 0 && Boolean.parseBoolean(System.getProperties().getProperty("pinot.admin.system.exit"))) {
   ```




-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: commits-unsubscribe@pinot.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org



---------------------------------------------------------------------
To unsubscribe, e-mail: commits-unsubscribe@pinot.apache.org
For additional commands, e-mail: commits-help@pinot.apache.org