You are viewing a plain text version of this content. The canonical link for it is here.
Posted to reviews@helix.apache.org by GitBox <gi...@apache.org> on 2019/08/29 05:16:11 UTC
[GitHub] [helix] jiajunwang commented on issue #431: Refine the WAGED
rebalancer related interfaces for integration
jiajunwang commented on issue #431: Refine the WAGED rebalancer related interfaces for integration
URL: https://github.com/apache/helix/pull/431#issuecomment-526026253
> Overall LGTM just minor comments. Do you want to add unit test later when adding the implementations?
Yes, that's the plan, this change does not contain real business logic. I just tested with existing test cases to ensure the modified stage is not broken.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
With regards,
Apache Git Services
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@helix.apache.org
For additional commands, e-mail: reviews-help@helix.apache.org