[GitHub] [incubator-nuttx] davids5 commented on pull request #1747: sched: Rename note_add to sched_note_add

[GitBox <gi...@apache.org>]

davids5 commented on pull request #1747:
URL: https://github.com/apache/incubator-nuttx/pull/1747#issuecomment-690615821


   I am referring to changing https://github.com/apache/incubator-nuttx/pull/1747/commits/4e45a66e5142b5d7df37a07b17e30d3fa4bc4262 
   
   This schedule_note_xxxx interface has been used for years. It is an API to `board-specific logic` it does not require a de-multiplexer the APIs are focused.   Please do not misinterpret the note: "NOTE: This is an internal OS interfaces and are called at at very critical locations in the OS." (it is the same as SPI selects that are defined by the board)
   
   What it means is It is an API to **`board-specific logic`** that should **NOT** waist any time. 
   
   The proposal of 1) queuing a data type and 2) de-queuing it and 3) de-multiplexing it not useful in the original intent: 
   That is to note an event of a **specific** kind.
   
   Feel free to extend the use case but not change the interface. That is a breaking change. 
   


----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org