You are viewing a plain text version of this content. The canonical link for it is here.
Posted to issues@phoenix.apache.org by "Hudson (Jira)" <ji...@apache.org> on 2019/12/01 12:53:00 UTC
[jira] [Commented] (PHOENIX-5494) Batched, mutable Index updates
are unnecessarily run one-by-one
[ https://issues.apache.org/jira/browse/PHOENIX-5494?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16985550#comment-16985550 ]
Hudson commented on PHOENIX-5494:
---------------------------------
FAILURE: Integrated in Jenkins build Phoenix-4.x-HBase-1.3 #610 (See [https://builds.apache.org/job/Phoenix-4.x-HBase-1.3/610/])
PHOENIX-5494 Batched, mutable Index updates are unnecessarily run (chenglei: rev 661531ad2393b1be039381b6d8bb01f797b9b54f)
* (edit) phoenix-core/src/test/java/org/apache/phoenix/hbase/index/covered/TestCoveredColumnIndexCodec.java
* (edit) phoenix-core/src/main/java/org/apache/phoenix/hbase/index/covered/LocalTableState.java
* (edit) phoenix-core/src/main/java/org/apache/phoenix/hbase/index/builder/IndexBuildManager.java
* (delete) phoenix-core/src/main/java/org/apache/phoenix/hbase/index/covered/data/LocalTable.java
* (edit) phoenix-core/src/test/java/org/apache/phoenix/hbase/index/covered/NonTxIndexBuilderTest.java
* (delete) phoenix-core/src/test/java/org/apache/phoenix/hbase/index/covered/data/TestLocalTable.java
* (edit) phoenix-core/src/main/java/org/apache/phoenix/hbase/index/covered/NonTxIndexBuilder.java
* (add) phoenix-core/src/main/java/org/apache/phoenix/hbase/index/covered/data/CachedLocalTable.java
* (edit) phoenix-core/src/test/java/org/apache/phoenix/hbase/index/covered/LocalTableStateTest.java
* (edit) phoenix-core/src/main/java/org/apache/phoenix/hbase/index/covered/data/LocalHBaseState.java
* (edit) phoenix-core/src/main/java/org/apache/phoenix/hbase/index/builder/BaseIndexBuilder.java
* (edit) phoenix-core/src/main/java/org/apache/phoenix/hbase/index/builder/IndexBuilder.java
> Batched, mutable Index updates are unnecessarily run one-by-one
> ---------------------------------------------------------------
>
> Key: PHOENIX-5494
> URL: https://issues.apache.org/jira/browse/PHOENIX-5494
> Project: Phoenix
> Issue Type: Improvement
> Affects Versions: 4.15.0, 5.1.0
> Reporter: Lars Hofhansl
> Assignee: chenglei
> Priority: Major
> Labels: performance
> Fix For: 4.15.0, 5.1.0
>
> Attachments: 5494-4.x-HBase-1.5.txt, PHOENIX-5494-4.x-HBase-1.4.patch, PHOENIX-5494.master.001.patch, PHOENIX-5494.master.002.patch, PHOENIX-5494.master.003.patch, PHOENIX-5494_v9-4.x-HBase-1.4.patch, PHOENIX-5494_v9-master.patch, Screenshot_20191110_160243.png, Screenshot_20191110_160351.png, Screenshot_20191110_161453.png
>
> Time Spent: 5h 20m
> Remaining Estimate: 0h
>
> I just noticed that index updates on mutable tables retrieve their deletes (to invalidate the old index entry) one-by-one.
> For batches, this can be *the* major time spent during an index update. The cost is mostly incured by the repeated setup (and seeking) of the new region scanner (for each row).
> We can instead do a skip scan and get all updates in a single scan per region.
> (Logically that is simple, but it will require some refactoring)
> I won't be getting to this, but recording it here in case someone feels inclined.
--
This message was sent by Atlassian Jira
(v8.3.4#803005)