You are viewing a plain text version of this content. The canonical link for it is here.
Posted to builds@apache.org by Richard Zowalla <rz...@apache.org> on 2022/05/05 07:57:48 UTC

GitHub Actions - Change in Behaviour - Automatic Pull Request Creation via GH

Hi all, 

we automatically re-generate some files during a build of TomEE and
used to automatically create a PR via GitHub actions. Similar
approaches are done by other projects (such as Camel) too. 

This is a quite handy feature as it allows us to create and review
related PRs and then merge the generated files into the codebase.

Such PRs looked like: https://github.com/apache/tomee/pull/877

However, it seems, that the behaviour has changed and the actions now
reports

> Error: GitHub Actions is not permitted to create or approve pull
requests.

See: 
https://github.com/apache/tomee/runs/6301961580?check_suite_focus=true

The funny thing is, that the Commit / Push on a branch is working and
is mirrored to the ASF Git but a PR cannot be created. 

This results in commits / PRs such as: 
https://github.com/apache/tomee/pull/879


My questions are:

- Did some default change?
- Is this an intended (security) related change?
- How can we restore the previous behaviour?

According to Humbedooh via #INFRA on Slack there was no change
conducted by INFRA. 

CC-ing dev@ here, so the TomEE Dev community is in the loop.

Thanks and Gruß
Richard



Re: GitHub Actions - Change in Behaviour - Automatic Pull Request Creation via GH

Posted by Richard Zowalla <rz...@apache.org>.
It is working again. Thanks to Gavin/INFRA !

Am Donnerstag, dem 05.05.2022 um 10:02 +0200 schrieb Richard Zowalla:
> In case someone stumbles across:
> 
> - https://issues.apache.org/jira/browse/INFRA-23226
> - https://github.com/peter-evans/create-pull-request/issues/1175
> - 
> https://github.blog/changelog/2022-05-03-github-actions-prevent-github-actions-from-creating-and-approving-pull-requests/
> 
> Gruß
> Richard
> 
> 
> Am Donnerstag, dem 05.05.2022 um 09:57 +0200 schrieb Richard Zowalla:
> > Hi all, 
> > 
> > we automatically re-generate some files during a build of TomEE and
> > used to automatically create a PR via GitHub actions. Similar
> > approaches are done by other projects (such as Camel) too. 
> > 
> > This is a quite handy feature as it allows us to create and review
> > related PRs and then merge the generated files into the codebase.
> > 
> > Such PRs looked like: https://github.com/apache/tomee/pull/877
> > 
> > However, it seems, that the behaviour has changed and the actions
> > now
> > reports
> > 
> > > Error: GitHub Actions is not permitted to create or approve pull
> > requests.
> > 
> > See: 
> > https://github.com/apache/tomee/runs/6301961580?check_suite_focus=true
> > 
> > The funny thing is, that the Commit / Push on a branch is working
> > and
> > is mirrored to the ASF Git but a PR cannot be created. 
> > 
> > This results in commits / PRs such as: 
> > https://github.com/apache/tomee/pull/879
> > 
> > 
> > My questions are:
> > 
> > - Did some default change?
> > - Is this an intended (security) related change?
> > - How can we restore the previous behaviour?
> > 
> > According to Humbedooh via #INFRA on Slack there was no change
> > conducted by INFRA. 
> > 
> > CC-ing dev@ here, so the TomEE Dev community is in the loop.
> > 
> > Thanks and Gruß
> > Richard
> > 
> > 

Re: GitHub Actions - Change in Behaviour - Automatic Pull Request Creation via GH

Posted by Richard Zowalla <rz...@apache.org>.
It is working again. Thanks to Gavin/INFRA !

Am Donnerstag, dem 05.05.2022 um 10:02 +0200 schrieb Richard Zowalla:
> In case someone stumbles across:
> 
> - https://issues.apache.org/jira/browse/INFRA-23226
> - https://github.com/peter-evans/create-pull-request/issues/1175
> - 
> https://github.blog/changelog/2022-05-03-github-actions-prevent-github-actions-from-creating-and-approving-pull-requests/
> 
> Gruß
> Richard
> 
> 
> Am Donnerstag, dem 05.05.2022 um 09:57 +0200 schrieb Richard Zowalla:
> > Hi all, 
> > 
> > we automatically re-generate some files during a build of TomEE and
> > used to automatically create a PR via GitHub actions. Similar
> > approaches are done by other projects (such as Camel) too. 
> > 
> > This is a quite handy feature as it allows us to create and review
> > related PRs and then merge the generated files into the codebase.
> > 
> > Such PRs looked like: https://github.com/apache/tomee/pull/877
> > 
> > However, it seems, that the behaviour has changed and the actions
> > now
> > reports
> > 
> > > Error: GitHub Actions is not permitted to create or approve pull
> > requests.
> > 
> > See: 
> > https://github.com/apache/tomee/runs/6301961580?check_suite_focus=true
> > 
> > The funny thing is, that the Commit / Push on a branch is working
> > and
> > is mirrored to the ASF Git but a PR cannot be created. 
> > 
> > This results in commits / PRs such as: 
> > https://github.com/apache/tomee/pull/879
> > 
> > 
> > My questions are:
> > 
> > - Did some default change?
> > - Is this an intended (security) related change?
> > - How can we restore the previous behaviour?
> > 
> > According to Humbedooh via #INFRA on Slack there was no change
> > conducted by INFRA. 
> > 
> > CC-ing dev@ here, so the TomEE Dev community is in the loop.
> > 
> > Thanks and Gruß
> > Richard
> > 
> > 

Re: GitHub Actions - Change in Behaviour - Automatic Pull Request Creation via GH

Posted by Richard Zowalla <rz...@apache.org>.
In case someone stumbles across:

- https://issues.apache.org/jira/browse/INFRA-23226
- https://github.com/peter-evans/create-pull-request/issues/1175
- 
https://github.blog/changelog/2022-05-03-github-actions-prevent-github-actions-from-creating-and-approving-pull-requests/

Gruß
Richard


Am Donnerstag, dem 05.05.2022 um 09:57 +0200 schrieb Richard Zowalla:
> Hi all, 
> 
> we automatically re-generate some files during a build of TomEE and
> used to automatically create a PR via GitHub actions. Similar
> approaches are done by other projects (such as Camel) too. 
> 
> This is a quite handy feature as it allows us to create and review
> related PRs and then merge the generated files into the codebase.
> 
> Such PRs looked like: https://github.com/apache/tomee/pull/877
> 
> However, it seems, that the behaviour has changed and the actions now
> reports
> 
> > Error: GitHub Actions is not permitted to create or approve pull
> requests.
> 
> See: 
> https://github.com/apache/tomee/runs/6301961580?check_suite_focus=true
> 
> The funny thing is, that the Commit / Push on a branch is working and
> is mirrored to the ASF Git but a PR cannot be created. 
> 
> This results in commits / PRs such as: 
> https://github.com/apache/tomee/pull/879
> 
> 
> My questions are:
> 
> - Did some default change?
> - Is this an intended (security) related change?
> - How can we restore the previous behaviour?
> 
> According to Humbedooh via #INFRA on Slack there was no change
> conducted by INFRA. 
> 
> CC-ing dev@ here, so the TomEE Dev community is in the loop.
> 
> Thanks and Gruß
> Richard
> 
> 

Re: GitHub Actions - Change in Behaviour - Automatic Pull Request Creation via GH

Posted by Richard Zowalla <rz...@apache.org>.
In case someone stumbles across:

- https://issues.apache.org/jira/browse/INFRA-23226
- https://github.com/peter-evans/create-pull-request/issues/1175
- 
https://github.blog/changelog/2022-05-03-github-actions-prevent-github-actions-from-creating-and-approving-pull-requests/

Gruß
Richard


Am Donnerstag, dem 05.05.2022 um 09:57 +0200 schrieb Richard Zowalla:
> Hi all, 
> 
> we automatically re-generate some files during a build of TomEE and
> used to automatically create a PR via GitHub actions. Similar
> approaches are done by other projects (such as Camel) too. 
> 
> This is a quite handy feature as it allows us to create and review
> related PRs and then merge the generated files into the codebase.
> 
> Such PRs looked like: https://github.com/apache/tomee/pull/877
> 
> However, it seems, that the behaviour has changed and the actions now
> reports
> 
> > Error: GitHub Actions is not permitted to create or approve pull
> requests.
> 
> See: 
> https://github.com/apache/tomee/runs/6301961580?check_suite_focus=true
> 
> The funny thing is, that the Commit / Push on a branch is working and
> is mirrored to the ASF Git but a PR cannot be created. 
> 
> This results in commits / PRs such as: 
> https://github.com/apache/tomee/pull/879
> 
> 
> My questions are:
> 
> - Did some default change?
> - Is this an intended (security) related change?
> - How can we restore the previous behaviour?
> 
> According to Humbedooh via #INFRA on Slack there was no change
> conducted by INFRA. 
> 
> CC-ing dev@ here, so the TomEE Dev community is in the loop.
> 
> Thanks and Gruß
> Richard
> 
> 

Re: GitHub Actions - Change in Behaviour - Automatic Pull Request Creation via GH

Posted by Jarek Potiuk <ja...@potiuk.com>.
GitHub does NOT make things easy :)

On Thu, May 5, 2022 at 10:38 AM Gavin McDonald <gm...@apache.org> wrote:

> On Thu, May 5, 2022 at 10:15 AM Jarek Potiuk <ja...@potiuk.com> wrote:
>
> > See
> >
> >
> https://github.blog/changelog/2022-05-03-github-actions-prevent-github-actions-from-creating-and-approving-pull-requests/-
> > that prevention was introduced by GitHub 2 days ago.
> >
> >
> yes, and as it is combined with a feature we disabled 2 monthsv agi in the
> same checkbox, it means I just had to reverse that
> restriction :)
>
>
>
> > On Thu, May 5, 2022 at 9:57 AM Richard Zowalla <rz...@apache.org> wrote:
> >
> > > Hi all,
> > >
> > > we automatically re-generate some files during a build of TomEE and
> > > used to automatically create a PR via GitHub actions. Similar
> > > approaches are done by other projects (such as Camel) too.
> > >
> > > This is a quite handy feature as it allows us to create and review
> > > related PRs and then merge the generated files into the codebase.
> > >
> > > Such PRs looked like: https://github.com/apache/tomee/pull/877
> > >
> > > However, it seems, that the behaviour has changed and the actions now
> > > reports
> > >
> > > > Error: GitHub Actions is not permitted to create or approve pull
> > > requests.
> > >
> > > See:
> > > https://github.com/apache/tomee/runs/6301961580?check_suite_focus=true
> > >
> > > The funny thing is, that the Commit / Push on a branch is working and
> > > is mirrored to the ASF Git but a PR cannot be created.
> > >
> > > This results in commits / PRs such as:
> > > https://github.com/apache/tomee/pull/879
> > >
> > >
> > > My questions are:
> > >
> > > - Did some default change?
> > > - Is this an intended (security) related change?
> > > - How can we restore the previous behaviour?
> > >
> > > According to Humbedooh via #INFRA on Slack there was no change
> > > conducted by INFRA.
> > >
> > > CC-ing dev@ here, so the TomEE Dev community is in the loop.
> > >
> > > Thanks and Gruß
> > > Richard
> > >
> > >
> > >
> >
>
>
> --
>
> *Gavin McDonald*
> Systems Administrator
> ASF Infrastructure Team
>

Re: GitHub Actions - Change in Behaviour - Automatic Pull Request Creation via GH

Posted by Gavin McDonald <gm...@apache.org>.
On Thu, May 5, 2022 at 10:15 AM Jarek Potiuk <ja...@potiuk.com> wrote:

> See
>
> https://github.blog/changelog/2022-05-03-github-actions-prevent-github-actions-from-creating-and-approving-pull-requests/-
> that prevention was introduced by GitHub 2 days ago.
>
>
yes, and as it is combined with a feature we disabled 2 monthsv agi in the
same checkbox, it means I just had to reverse that
restriction :)



> On Thu, May 5, 2022 at 9:57 AM Richard Zowalla <rz...@apache.org> wrote:
>
> > Hi all,
> >
> > we automatically re-generate some files during a build of TomEE and
> > used to automatically create a PR via GitHub actions. Similar
> > approaches are done by other projects (such as Camel) too.
> >
> > This is a quite handy feature as it allows us to create and review
> > related PRs and then merge the generated files into the codebase.
> >
> > Such PRs looked like: https://github.com/apache/tomee/pull/877
> >
> > However, it seems, that the behaviour has changed and the actions now
> > reports
> >
> > > Error: GitHub Actions is not permitted to create or approve pull
> > requests.
> >
> > See:
> > https://github.com/apache/tomee/runs/6301961580?check_suite_focus=true
> >
> > The funny thing is, that the Commit / Push on a branch is working and
> > is mirrored to the ASF Git but a PR cannot be created.
> >
> > This results in commits / PRs such as:
> > https://github.com/apache/tomee/pull/879
> >
> >
> > My questions are:
> >
> > - Did some default change?
> > - Is this an intended (security) related change?
> > - How can we restore the previous behaviour?
> >
> > According to Humbedooh via #INFRA on Slack there was no change
> > conducted by INFRA.
> >
> > CC-ing dev@ here, so the TomEE Dev community is in the loop.
> >
> > Thanks and Gruß
> > Richard
> >
> >
> >
>


-- 

*Gavin McDonald*
Systems Administrator
ASF Infrastructure Team

Re: GitHub Actions - Change in Behaviour - Automatic Pull Request Creation via GH

Posted by Jarek Potiuk <ja...@potiuk.com>.
See
https://github.blog/changelog/2022-05-03-github-actions-prevent-github-actions-from-creating-and-approving-pull-requests/-
that prevention was introduced by GitHub 2 days ago.

On Thu, May 5, 2022 at 9:57 AM Richard Zowalla <rz...@apache.org> wrote:

> Hi all,
>
> we automatically re-generate some files during a build of TomEE and
> used to automatically create a PR via GitHub actions. Similar
> approaches are done by other projects (such as Camel) too.
>
> This is a quite handy feature as it allows us to create and review
> related PRs and then merge the generated files into the codebase.
>
> Such PRs looked like: https://github.com/apache/tomee/pull/877
>
> However, it seems, that the behaviour has changed and the actions now
> reports
>
> > Error: GitHub Actions is not permitted to create or approve pull
> requests.
>
> See:
> https://github.com/apache/tomee/runs/6301961580?check_suite_focus=true
>
> The funny thing is, that the Commit / Push on a branch is working and
> is mirrored to the ASF Git but a PR cannot be created.
>
> This results in commits / PRs such as:
> https://github.com/apache/tomee/pull/879
>
>
> My questions are:
>
> - Did some default change?
> - Is this an intended (security) related change?
> - How can we restore the previous behaviour?
>
> According to Humbedooh via #INFRA on Slack there was no change
> conducted by INFRA.
>
> CC-ing dev@ here, so the TomEE Dev community is in the loop.
>
> Thanks and Gruß
> Richard
>
>
>

Re: GitHub Actions - Change in Behaviour - Automatic Pull Request Creation via GH

Posted by Jarek Potiuk <ja...@potiuk.com>.
See
https://github.blog/changelog/2022-05-03-github-actions-prevent-github-actions-from-creating-and-approving-pull-requests/-
that prevention was introduced by GitHub 2 days ago.

On Thu, May 5, 2022 at 9:57 AM Richard Zowalla <rz...@apache.org> wrote:

> Hi all,
>
> we automatically re-generate some files during a build of TomEE and
> used to automatically create a PR via GitHub actions. Similar
> approaches are done by other projects (such as Camel) too.
>
> This is a quite handy feature as it allows us to create and review
> related PRs and then merge the generated files into the codebase.
>
> Such PRs looked like: https://github.com/apache/tomee/pull/877
>
> However, it seems, that the behaviour has changed and the actions now
> reports
>
> > Error: GitHub Actions is not permitted to create or approve pull
> requests.
>
> See:
> https://github.com/apache/tomee/runs/6301961580?check_suite_focus=true
>
> The funny thing is, that the Commit / Push on a branch is working and
> is mirrored to the ASF Git but a PR cannot be created.
>
> This results in commits / PRs such as:
> https://github.com/apache/tomee/pull/879
>
>
> My questions are:
>
> - Did some default change?
> - Is this an intended (security) related change?
> - How can we restore the previous behaviour?
>
> According to Humbedooh via #INFRA on Slack there was no change
> conducted by INFRA.
>
> CC-ing dev@ here, so the TomEE Dev community is in the loop.
>
> Thanks and Gruß
> Richard
>
>
>