You are viewing a plain text version of this content. The canonical link for it is here.
Posted to commits@cordova.apache.org by GitBox <gi...@apache.org> on 2020/03/04 15:24:04 UTC
[GitHub] [cordova-plugin-inappbrowser] kutoman opened a new pull request
#638: (iOS) fixing problem status bar frame too narrow
kutoman opened a new pull request #638: (iOS) fixing problem status bar frame too narrow
URL: https://github.com/apache/cordova-plugin-inappbrowser/pull/638
this approach considers the safe area insets
<!--
Please make sure the checklist boxes are all checked before submitting the PR. The checklist is intended as a quick reference, for complete details please see our Contributor Guidelines:
http://cordova.apache.org/contribute/contribute_guidelines.html
Thanks!
-->
### Platforms affected
### Motivation and Context
<!-- Why is this change required? What problem does it solve? -->
<!-- If it fixes an open issue, please link to the issue here. -->
This change prevents from hardcoding the status bar frame size.
It doesn't really fix any open issue as far as I could see.
### Description
<!-- Describe your changes in detail -->
the status bar frame was too narrow so that some symbols of the iPhone XR statusbar weren't
contained by the frame fully.
### Testing
<!-- Please describe in detail how you tested your changes. -->
tested it in iPhone 8 and iPhone XR simulators
### Checklist
- [ ] I've run the tests to see all new and existing tests pass
- [ ] I added automated test coverage as appropriate for this change
- [x] Commit is prefixed with `(platform)` if this change only applies to one platform (e.g. `(android)`)
- [ ] If this Pull Request resolves an issue, I linked to the issue in the text above (and used the correct [keyword to close issues using keywords](https://help.github.com/articles/closing-issues-using-keywords/))
- [ ] I've updated the documentation if necessary
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
With regards,
Apache Git Services
---------------------------------------------------------------------
To unsubscribe, e-mail: commits-unsubscribe@cordova.apache.org
For additional commands, e-mail: commits-help@cordova.apache.org
[GitHub] [cordova-plugin-inappbrowser] kutoman commented on issue #638:
(iOS) fixing problem status bar frame too narrow
Posted by GitBox <gi...@apache.org>.
kutoman commented on issue #638: (iOS) fixing problem status bar frame too narrow
URL: https://github.com/apache/cordova-plugin-inappbrowser/pull/638#issuecomment-600492208
#546 handles the same issue differently
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
With regards,
Apache Git Services
---------------------------------------------------------------------
To unsubscribe, e-mail: commits-unsubscribe@cordova.apache.org
For additional commands, e-mail: commits-help@cordova.apache.org
[GitHub] [cordova-plugin-inappbrowser] kutoman closed pull request #638:
(iOS) fixing problem status bar frame too narrow
Posted by GitBox <gi...@apache.org>.
kutoman closed pull request #638: (iOS) fixing problem status bar frame too narrow
URL: https://github.com/apache/cordova-plugin-inappbrowser/pull/638
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
With regards,
Apache Git Services
---------------------------------------------------------------------
To unsubscribe, e-mail: commits-unsubscribe@cordova.apache.org
For additional commands, e-mail: commits-help@cordova.apache.org
[GitHub] [cordova-plugin-inappbrowser] mosabab commented on issue #638:
(iOS) fixing problem status bar frame too narrow
Posted by GitBox <gi...@apache.org>.
mosabab commented on issue #638: (iOS) fixing problem status bar frame too narrow
URL: https://github.com/apache/cordova-plugin-inappbrowser/pull/638#issuecomment-604333725
I test it but this need to some modifications.
Anyway you can close your pull request because someone made a well tested pull request that will be merged to master in the future:
https://github.com/apache/cordova-plugin-inappbrowser/pull/546
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
With regards,
Apache Git Services
---------------------------------------------------------------------
To unsubscribe, e-mail: commits-unsubscribe@cordova.apache.org
For additional commands, e-mail: commits-help@cordova.apache.org
[GitHub] [cordova-plugin-inappbrowser] timbru31 commented on issue #638:
(iOS) fixing problem status bar frame too narrow
Posted by GitBox <gi...@apache.org>.
timbru31 commented on issue #638: (iOS) fixing problem status bar frame too narrow
URL: https://github.com/apache/cordova-plugin-inappbrowser/pull/638#issuecomment-600026430
The CI failure was unrelated, I've restarted the affected build and now it's green.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
With regards,
Apache Git Services
---------------------------------------------------------------------
To unsubscribe, e-mail: commits-unsubscribe@cordova.apache.org
For additional commands, e-mail: commits-help@cordova.apache.org