You are viewing a plain text version of this content. The canonical link for it is here.
Posted to notifications@geode.apache.org by GitBox <gi...@apache.org> on 2020/09/24 21:06:43 UTC

[GitHub] [geode] davebarnes97 opened a new pull request #5549: GEODE-8533: Docs - compaction-threshold mechanism description are wrong

davebarnes97 opened a new pull request #5549:
URL: https://github.com/apache/geode/pull/5549


   Questions for reviewers:
   - Have the explanations satisfactorily stated that the compaction-threshold is a percentage of live data (non-garbage), as opposed to a percentage of garbage?
   - Is it clear that the threshold is activated when the live data percentage drops below the threshold, as opposed to exceeding it?
   - Is the modified formula for calculating required disk space correct?
   Thanks!
   


----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org



[GitHub] [geode] davebarnes97 merged pull request #5549: GEODE-8533: Docs - compaction-threshold mechanism description are wrong

Posted by GitBox <gi...@apache.org>.
davebarnes97 merged pull request #5549:
URL: https://github.com/apache/geode/pull/5549


   


----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org