You are viewing a plain text version of this content. The canonical link for it is here.
Posted to dev@poi.apache.org by bu...@apache.org on 2008/06/26 18:07:27 UTC

DO NOT REPLY [Bug 45289] New: [PATCH] Small improvement for HSSF Countif function

https://issues.apache.org/bugzilla/show_bug.cgi?id=45289

           Summary: [PATCH]Small improvement for HSSF Countif function
           Product: POI
           Version: 3.0-dev
          Platform: PC
        OS/Version: Windows XP
            Status: NEW
          Severity: enhancement
          Priority: P2
         Component: HSSF
        AssignedTo: dev@poi.apache.org
        ReportedBy: domenico.napoletano@exprivia.it


The current COUNTIF funztion implementation in HSSF can handle espression like

COUNTIF(A1:A5; "12")

COUNTIF(A1:A5; "right")

but not analogous ones like

COUNTIF(A1:A5; "=12")

COUNTIF(A1:A5; "=right")

A simple patch could consist of small editing of createGeneralMatchPredicate
method:

1) replace the first statement

String value = stringEval.getStringValue();

with

String value = stringEval.getStringValue().replaceAll("^=", "");

2) comment out the

case '=':

statement (preserving the throw statement right next)


-- 
Configure bugmail: https://issues.apache.org/bugzilla/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are the assignee for the bug.

---------------------------------------------------------------------
To unsubscribe, e-mail: dev-unsubscribe@poi.apache.org
For additional commands, e-mail: dev-help@poi.apache.org

DO NOT REPLY [Bug 45289] [PATCH]Small improvement for HSSF Countif function

Posted by bu...@apache.org.
https://issues.apache.org/bugzilla/show_bug.cgi?id=45289


Josh Micich <jo...@gildedtree.com> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
             Status|ASSIGNED                    |RESOLVED
         Resolution|                            |FIXED




--- Comment #2 from Josh Micich <jo...@gildedtree.com>  2008-07-11 01:03:40 PST ---
Fixed in svn r675853.

Added support for all operators (=, <>, <, <=, >, >=), also wildcard criteria.
Fixed up POI to follow COUNTIF's funny type conversion rules.

Junits added.


-- 
Configure bugmail: https://issues.apache.org/bugzilla/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are the assignee for the bug.

---------------------------------------------------------------------
To unsubscribe, e-mail: dev-unsubscribe@poi.apache.org
For additional commands, e-mail: dev-help@poi.apache.org

DO NOT REPLY [Bug 45289] [PATCH]Small improvement for HSSF Countif function

Posted by bu...@apache.org.
https://issues.apache.org/bugzilla/show_bug.cgi?id=45289


Nick Burch <ni...@torchbox.com> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
             Status|NEW                         |ASSIGNED




--- Comment #1 from Nick Burch <ni...@torchbox.com>  2008-06-28 11:59:55 PST ---
This looks like an OK fix to me.

Josh - as our current formula guru, does it make sense to you too?


-- 
Configure bugmail: https://issues.apache.org/bugzilla/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are the assignee for the bug.

---------------------------------------------------------------------
To unsubscribe, e-mail: dev-unsubscribe@poi.apache.org
For additional commands, e-mail: dev-help@poi.apache.org