You are viewing a plain text version of this content. The canonical link for it is here.
Posted to issues-all@impala.apache.org by "ASF subversion and git services (Jira)" <ji...@apache.org> on 2022/11/07 21:28:00 UTC

[jira] [Commented] (IMPALA-11621) testdata/bin/kill-hive-server.sh should remove the HiveServer2 pid file

    [ https://issues.apache.org/jira/browse/IMPALA-11621?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17630036#comment-17630036 ] 

ASF subversion and git services commented on IMPALA-11621:
----------------------------------------------------------

Commit 3938dae8be6f28132de67f10d0361665e5c6cad3 in impala's branch refs/heads/master from Michael Smith
[ https://gitbox.apache.org/repos/asf?p=impala.git;h=3938dae8b ]

IMPALA-11621: (Addendum) ignore hiveserver2.pid

Add gitignore for the hiveserver2.pid file created by Hive's startup
script.

Change-Id: I1850e98b5d869fed004f6198296e2de4f16680fa
Reviewed-on: http://gerrit.cloudera.org:8080/19192
Reviewed-by: Daniel Becker <da...@cloudera.com>
Reviewed-by: Joe McDonnell <jo...@cloudera.com>
Tested-by: Impala Public Jenkins <im...@cloudera.com>


> testdata/bin/kill-hive-server.sh should remove the HiveServer2 pid file
> -----------------------------------------------------------------------
>
>                 Key: IMPALA-11621
>                 URL: https://issues.apache.org/jira/browse/IMPALA-11621
>             Project: IMPALA
>          Issue Type: Improvement
>          Components: Infrastructure
>    Affects Versions: Impala 4.2.0
>            Reporter: Joe McDonnell
>            Assignee: Joe McDonnell
>            Priority: Major
>             Fix For: Impala 4.2.0
>
>
> With HIVE-22193, Hive added a graceful stop functionality that also changed some startup scripts. Hive now keeps a file with the HiveServer2's pid and checks to see if it is already running before starting up. testdata/bin/kill-hive-server.sh uses testdata/bin/kill-java-service.sh, and it doesn't know to remove the pid file. Since testdata/bin/kill-java-service.sh would fail if it was unable to stop HiveServer2, it should be safe to remove the pid file after that command succeeds.
> If we don't remove the pid file, the OS might reuse the pid and this could interfere with HiveServer2 startup.



--
This message was sent by Atlassian Jira
(v8.20.10#820010)

---------------------------------------------------------------------
To unsubscribe, e-mail: issues-all-unsubscribe@impala.apache.org
For additional commands, e-mail: issues-all-help@impala.apache.org