[jira] [Commented] (MAPREDUCE-5895) FileAlreadyExistsException was thrown : Temporary Index File can not be cleaned up because OutputStream doesn't close properly

["Kousuke Saruta (JIRA)" <ji...@apache.org>]

    [ https://issues.apache.org/jira/browse/MAPREDUCE-5895?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=14009771#comment-14009771 ] 

Kousuke Saruta commented on MAPREDUCE-5895:
-------------------------------------------

Thank you for your comment [~devaraj.k]!
I think dos.close calls bos.close internally right?

> FileAlreadyExistsException was thrown : Temporary Index File can not be cleaned up because OutputStream doesn't close properly
> ------------------------------------------------------------------------------------------------------------------------------
>
>                 Key: MAPREDUCE-5895
>                 URL: https://issues.apache.org/jira/browse/MAPREDUCE-5895
>             Project: Hadoop Map/Reduce
>          Issue Type: Bug
>          Components: client
>    Affects Versions: 3.0.0
>            Reporter: Kousuke Saruta
>         Attachments: MAPREDUCE-5895.patch
>
>
> In TaskLog.java, Temporary Index File is created by following code.
> {code}
> BufferedOutputStream bos =
>   new BufferedOutputStream(
>     SecureIOUtils.createForWrite(tmpIndexFile, 0644));
> DataOutputStream dos = new DataOutputStream(bos);
> {code}
> The code is surrounded by try-finally so if some Exception/ERROR is thrown between constructing bos and dos, temporary file is not cleaned up.
> I met the situation that when a thread ran, OOM was thrown after bos created and temporary file is not cleaned up. At different time, another thread executed same logic and fail because of FileAlreadyExistsException.



--
This message was sent by Atlassian JIRA
(v6.2#6252)