You are viewing a plain text version of this content. The canonical link for it is here.
Posted to notifications@zookeeper.apache.org by GitBox <gi...@apache.org> on 2020/06/30 11:58:04 UTC

[GitHub] [zookeeper] Hinterwaeldlers opened a new pull request #1390: ZOOKEEPER-3526: data inconsistency due to mistaken TRUNC caused by maxCommittedLog is much less than minCommittedLog when in readonly mode

Hinterwaeldlers opened a new pull request #1390:
URL: https://github.com/apache/zookeeper/pull/1390


   Use common zxid between all ZooKeeperServers used within a server instance


----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org



[GitHub] [zookeeper] Hinterwaeldlers closed pull request #1390: ZOOKEEPER-3526: data inconsistency due to mistaken TRUNC caused by maxCommittedLog is much less than minCommittedLog when in readonly mode

Posted by GitBox <gi...@apache.org>.
Hinterwaeldlers closed pull request #1390:
URL: https://github.com/apache/zookeeper/pull/1390


   


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: notifications-unsubscribe@zookeeper.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org



[GitHub] [zookeeper] maoling commented on pull request #1390: ZOOKEEPER-3526: data inconsistency due to mistaken TRUNC caused by maxCommittedLog is much less than minCommittedLog when in readonly mode

Posted by GitBox <gi...@apache.org>.
maoling commented on pull request #1390:
URL: https://github.com/apache/zookeeper/pull/1390#issuecomment-978833173


   @Hinterwaeldlers. Very sorry for our late, the inconsistency issue always has the highest priority. As you see, our reviewer has noticed this PR, I will nudge this PR


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: notifications-unsubscribe@zookeeper.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org



[GitHub] [zookeeper] maoling edited a comment on pull request #1390: ZOOKEEPER-3526: data inconsistency due to mistaken TRUNC caused by maxCommittedLog is much less than minCommittedLog when in readonly mode

Posted by GitBox <gi...@apache.org>.
maoling edited a comment on pull request #1390:
URL: https://github.com/apache/zookeeper/pull/1390#issuecomment-807928587


   @ztzg @eolivelli  @anmolnar  @nkalmar  This is a serious bug which's related with the consistency, any of your guys have a cycle to review it? @Hinterwaeldlers


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org



[GitHub] [zookeeper] nkalmar commented on pull request #1390: ZOOKEEPER-3526: data inconsistency due to mistaken TRUNC caused by maxCommittedLog is much less than minCommittedLog when in readonly mode

Posted by GitBox <gi...@apache.org>.
nkalmar commented on pull request #1390:
URL: https://github.com/apache/zookeeper/pull/1390#issuecomment-976524673


   @eolivelli you already reviewed the patch for 3.6, are we good to merge this?


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: notifications-unsubscribe@zookeeper.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org



[GitHub] [zookeeper] Hinterwaeldlers commented on pull request #1390: ZOOKEEPER-3526: data inconsistency due to mistaken TRUNC caused by maxCommittedLog is much less than minCommittedLog when in readonly mode

Posted by GitBox <gi...@apache.org>.
Hinterwaeldlers commented on pull request #1390:
URL: https://github.com/apache/zookeeper/pull/1390#issuecomment-1031265970


   Any progress within the review progress so far?
   Thanks in advance


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: notifications-unsubscribe@zookeeper.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org



[GitHub] [zookeeper] maoling commented on pull request #1390: ZOOKEEPER-3526: data inconsistency due to mistaken TRUNC caused by maxCommittedLog is much less than minCommittedLog when in readonly mode

Posted by GitBox <gi...@apache.org>.
maoling commented on pull request #1390:
URL: https://github.com/apache/zookeeper/pull/1390#issuecomment-1036109761


   @Hinterwaeldlers 
   - The unit test did not work anymore, please use the `Junit5` jupiter.api
   - Please reopen your origin PRs again branch-3.5, branch-3.6, branch-3.7 (Notice
   master and branch-3.7 use `Junit5`, branch-3.5 and branch-3.6 use `Junit4`)


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: notifications-unsubscribe@zookeeper.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org



[GitHub] [zookeeper] maoling commented on pull request #1390: ZOOKEEPER-3526: data inconsistency due to mistaken TRUNC caused by maxCommittedLog is much less than minCommittedLog when in readonly mode

Posted by GitBox <gi...@apache.org>.
maoling commented on pull request #1390:
URL: https://github.com/apache/zookeeper/pull/1390#issuecomment-1032150367


   Oops, I'm looking


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: notifications-unsubscribe@zookeeper.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org



[GitHub] [zookeeper] maoling closed pull request #1390: ZOOKEEPER-3526: data inconsistency due to mistaken TRUNC caused by maxCommittedLog is much less than minCommittedLog when in readonly mode

Posted by GitBox <gi...@apache.org>.
maoling closed pull request #1390:
URL: https://github.com/apache/zookeeper/pull/1390


   


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: notifications-unsubscribe@zookeeper.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org



[GitHub] [zookeeper] maoling commented on pull request #1390: ZOOKEEPER-3526: data inconsistency due to mistaken TRUNC caused by maxCommittedLog is much less than minCommittedLog when in readonly mode

Posted by GitBox <gi...@apache.org>.
maoling commented on pull request #1390:
URL: https://github.com/apache/zookeeper/pull/1390#issuecomment-807928587


   @ztzg @eolivelli  @anmolnar  @nkalmar  This is a serious bug which's related with the consistency, any of your guys have a cycle to review it?


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org



[GitHub] [zookeeper] Hinterwaeldlers commented on pull request #1390: ZOOKEEPER-3526: data inconsistency due to mistaken TRUNC caused by maxCommittedLog is much less than minCommittedLog when in readonly mode

Posted by GitBox <gi...@apache.org>.
Hinterwaeldlers commented on pull request #1390:
URL: https://github.com/apache/zookeeper/pull/1390#issuecomment-802727514


   As wished in https://github.com/apache/zookeeper/pull/1391 I've ported the fix to the master branch.
   After checking the CI result, it seems like it is a general problem with the CI, unrelated to this fix. Right?


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org



[GitHub] [zookeeper] Hinterwaeldlers commented on pull request #1390: ZOOKEEPER-3526: data inconsistency due to mistaken TRUNC caused by maxCommittedLog is much less than minCommittedLog when in readonly mode

Posted by GitBox <gi...@apache.org>.
Hinterwaeldlers commented on pull request #1390:
URL: https://github.com/apache/zookeeper/pull/1390#issuecomment-976233290


   I hope someone can check this Pull-Request


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: notifications-unsubscribe@zookeeper.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org