[GitHub] [airflow] BasPH commented on a change in pull request #5393: [AIRFLOW-4753] Utils log json formatter

[GitBox <gi...@apache.org>]

BasPH commented on a change in pull request #5393: [AIRFLOW-4753] Utils log json formatter
URL: https://github.com/apache/airflow/pull/5393#discussion_r291833462
 
 

 ##########
 File path: scripts/ci/ci_pylint.sh
 ##########
 @@ -17,13 +17,14 @@
 # limitations under the License.
 #
 
-# Script to run Pylint on all code. Should be started from root directory:
-# ./[airflow dir]/scripts/ci/ci_pylint.sh
+# Script to run Pylint on all code. Should be started from root directory of Airflow:
+# ./scripts/ci/ci_pylint.sh
 
 set -ex
 
 find . -name "*.py" \
 -not -path "./.eggs/*" \
 -not -path "./airflow/www/node_modules/*" \
 -not -path "./airflow/_vendor/*" \
--not -path "./build" | grep -vFf scripts/ci/pylint_todo.txt | xargs pylint --output-format=colorized
+-not -path "./build/*" \
+! -name 'webserver_config.py' | grep -vFf scripts/ci/pylint_todo.txt | xargs pylint --output-format=colorized
 
 Review comment:
   Tiny nit: to keep `! -name 'webserver_config.py'` consistent with the other code, would use `-not`:
   ```
   -not -name 'webserver_config.py'
   ```

----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
users@infra.apache.org


With regards,
Apache Git Services