[GitHub] [druid] ccaominh commented on a change in pull request #10469: Test UI to trigger auto compaction

[GitBox <gi...@apache.org>]

ccaominh commented on a change in pull request #10469:
URL: https://github.com/apache/druid/pull/10469#discussion_r499192514



##########
File path: web-console/e2e-tests/component/datasources/overview.ts
##########
@@ -116,6 +124,23 @@ export class DatasourcesOverview {
 
     const editActions = await this.page.$$('span[icon=wrench]');
     editActions[index].click();
+    await this.waitForPopupMenu();
+  }
+
+  private async waitForPopupMenu(): Promise<void> {
+    await this.page.waitFor(1000); // https://blueprintjs.com/docs/#core/components/popover.testing

Review comment:
       After incorporating the changes with the upgraded playwright version, it seems this fixed sleep is no longer needed to make the E2E test reliable, so I removed it.
   
   Although it may not be needed for E2E tests, I think your suggestion to have a testing mode for components with `Popover`s could be useful for unit tests though.




----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org



---------------------------------------------------------------------
To unsubscribe, e-mail: commits-unsubscribe@druid.apache.org
For additional commands, e-mail: commits-help@druid.apache.org