You are viewing a plain text version of this content. The canonical link for it is here.
Posted to issues@iceberg.apache.org by "jackye1995 (via GitHub)" <gi...@apache.org> on 2023/04/25 16:49:41 UTC

[GitHub] [iceberg] jackye1995 commented on a diff in pull request #7349: Core: Move table-creation-without-namespace-test to CatalogTests

jackye1995 commented on code in PR #7349:
URL: https://github.com/apache/iceberg/pull/7349#discussion_r1176787739


##########
core/src/main/java/org/apache/iceberg/inmemory/InMemoryCatalog.java:
##########
@@ -315,7 +315,7 @@ public void doCommit(TableMetadata base, TableMetadata metadata) {
 
       if (null == base && !namespaceExists(tableIdentifier.namespace())) {
         throw new NoSuchNamespaceException(
-            "Cannot create table %s. Namespace %s does not exist",
+            "Cannot create table %s. Namespace does not exist: %s",

Review Comment:
   I guess the original message was written in that way to avoid 2 colons. I am fine either way, let me know what you think.



-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: issues-unsubscribe@iceberg.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org


---------------------------------------------------------------------
To unsubscribe, e-mail: issues-unsubscribe@iceberg.apache.org
For additional commands, e-mail: issues-help@iceberg.apache.org