You are viewing a plain text version of this content. The canonical link for it is here.
Posted to github@arrow.apache.org by "mbrobbel (via GitHub)" <gi...@apache.org> on 2025/09/26 09:45:10 UTC
[PR] Migrate `arrow-cast` to Rust 2024 [arrow-rs]
mbrobbel opened a new pull request, #8453:
URL: https://github.com/apache/arrow-rs/pull/8453
# Which issue does this PR close?
- Contribute to #6827
# Rationale for this change
Splitting up #8227.
# What changes are included in this PR?
Migrate `arrow-cast` to Rust 2024
# Are these changes tested?
CI
# Are there any user-facing changes?
Yes
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: github-unsubscribe@arrow.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
Re: [PR] Migrate `arrow-cast` to Rust 2024 [arrow-rs]
Posted by "mbrobbel (via GitHub)" <gi...@apache.org>.
mbrobbel commented on code in PR #8453:
URL: https://github.com/apache/arrow-rs/pull/8453#discussion_r2381691851
##########
arrow-cast/src/pretty.rs:
##########
@@ -60,7 +60,7 @@ use crate::display::{ArrayFormatter, FormatOptions};
/// | 5 | e |
/// +---+---+"#);
/// ```
-pub fn pretty_format_batches(results: &[RecordBatch]) -> Result<impl Display, ArrowError> {
+pub fn pretty_format_batches(results: &[RecordBatch]) -> Result<impl Display + use<>, ArrowError> {
Review Comment:
https://github.com/apache/arrow-rs/pull/8227#discussion_r2323000661
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: github-unsubscribe@arrow.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
Re: [PR] Migrate `arrow-cast` to Rust 2024 [arrow-rs]
Posted by "mbrobbel (via GitHub)" <gi...@apache.org>.
mbrobbel merged PR #8453:
URL: https://github.com/apache/arrow-rs/pull/8453
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: github-unsubscribe@arrow.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
Re: [PR] Migrate `arrow-cast` to Rust 2024 [arrow-rs]
Posted by "mbrobbel (via GitHub)" <gi...@apache.org>.
mbrobbel commented on PR #8453:
URL: https://github.com/apache/arrow-rs/pull/8453#issuecomment-3338830056
Thanks @crepererum
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: github-unsubscribe@arrow.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
Re: [PR] Migrate `arrow-cast` to Rust 2024 [arrow-rs]
Posted by "mbrobbel (via GitHub)" <gi...@apache.org>.
mbrobbel commented on code in PR #8453:
URL: https://github.com/apache/arrow-rs/pull/8453#discussion_r2381691851
##########
arrow-cast/src/pretty.rs:
##########
@@ -60,7 +60,7 @@ use crate::display::{ArrayFormatter, FormatOptions};
/// | 5 | e |
/// +---+---+"#);
/// ```
-pub fn pretty_format_batches(results: &[RecordBatch]) -> Result<impl Display, ArrowError> {
+pub fn pretty_format_batches(results: &[RecordBatch]) -> Result<impl Display + use<>, ArrowError> {
Review Comment:
https://github.com/apache/arrow-rs/pull/8227/files#r2323000661
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: github-unsubscribe@arrow.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org