[jira] [Commented] (HBASE-10255) Remove dependency on LimitInputStream

["stack (JIRA)" <ji...@apache.org>]

    [ https://issues.apache.org/jira/browse/HBASE-10255?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13860376#comment-13860376 ] 

stack commented on HBASE-10255:
-------------------------------

This issue remains unresolved though it has had a patch applied to a few branches.

-1 on current patch as applied since no supporting benchmark that new dependency does not slow throughput in a critical section. I've also taken the time to attach an alternative suggestion that would have us back on the original class w/o need of import from a 'foreign' domain.

> Remove dependency on LimitInputStream
> -------------------------------------
>
>                 Key: HBASE-10255
>                 URL: https://issues.apache.org/jira/browse/HBASE-10255
>             Project: HBase
>          Issue Type: Task
>            Reporter: Ted Yu
>            Assignee: Ted Yu
>            Priority: Minor
>             Fix For: 0.98.0, 0.99.0
>
>         Attachments: 10255-v1.txt, 10255-v2.txt, alternate_lis.txt
>
>
> LimitInputStream has always been a @Beta API and beta apis aren't guaranteed to remain stable over such a long period (v12 to v15).
> LimitInputStream was copied from Guava v12
> The recommended replacement is to use ByteStreams#limit(java.io.InputStream, long) instead.



--
This message was sent by Atlassian JIRA
(v6.1.5#6160)