You are viewing a plain text version of this content. The canonical link for it is here.
Posted to dev@cordova.apache.org by audreyso <gi...@git.apache.org> on 2017/07/13 16:45:33 UTC
[GitHub] cordova-ios pull request #327: CB-12895: replaced jshint with eslint
GitHub user audreyso opened a pull request:
https://github.com/apache/cordova-ios/pull/327
CB-12895: replaced jshint with eslint
<!--
Please make sure the checklist boxes are all checked before submitting the PR. The checklist
is intended as a quick reference, for complete details please see our Contributor Guidelines:
http://cordova.apache.org/contribute/contribute_guidelines.html
Thanks!
-->
### Platforms affected
### What does this PR do?
Replaced jshint with eslint
### What testing has been done on this change?
### Checklist
- [X] [Reported an issue](http://cordova.apache.org/contribute/issues.html) in the JIRA database
- [X] Commit message follows the format: "CB-3232: (android) Fix bug with resolving file paths", where CB-xxxx is the JIRA ID & "android" is the platform affected.
- [X] Added automated test coverage as appropriate for this change.
You can merge this pull request into a Git repository by running:
$ git pull https://github.com/audreyso/cordova-ios CB-12895-2
Alternatively you can review and apply these changes as the patch at:
https://github.com/apache/cordova-ios/pull/327.patch
To close this pull request, make a commit to your master/trunk branch
with (at least) the following in the commit message:
This closes #327
----
commit f9b046e5fae2f83c7aa9bf20d80a1fcfd09d05f9
Author: Audrey So <au...@apache.org>
Date: 2017-06-15T17:56:59Z
CB-12895 : removed jshint and added eslint
commit b7b92263af52efd2bad27d5bdba63ee24244e76a
Author: Audrey So <au...@apache.org>
Date: 2017-06-15T18:02:03Z
CB-12895 : formatted using eslint rules
commit d2fae43e99f2f4da52d3aa13aee309c805964eea
Author: Audrey So <au...@apache.org>
Date: 2017-07-12T21:47:46Z
CB-12895 : updated indenting with eslint rules
----
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---
---------------------------------------------------------------------
To unsubscribe, e-mail: dev-unsubscribe@cordova.apache.org
For additional commands, e-mail: dev-help@cordova.apache.org
[GitHub] cordova-ios issue #327: CB-12895: replaced jshint with eslint
Posted by codecov-io <gi...@git.apache.org>.
Github user codecov-io commented on the issue:
https://github.com/apache/cordova-ios/pull/327
# [Codecov](https://codecov.io/gh/apache/cordova-ios/pull/327?src=pr&el=h1) Report
> Merging [#327](https://codecov.io/gh/apache/cordova-ios/pull/327?src=pr&el=desc) into [master](https://codecov.io/gh/apache/cordova-ios/commit/26beb94e2d454917db0bb024ab75e8dd9759c028?src=pr&el=desc) will **increase** coverage by `0.14%`.
> The diff coverage is `52.39%`.
[](https://codecov.io/gh/apache/cordova-ios/pull/327?src=pr&el=tree)
```diff
@@ Coverage Diff @@
## master #327 +/- ##
==========================================
+ Coverage 63.77% 63.91% +0.14%
==========================================
Files 14 14
Lines 1623 1671 +48
Branches 277 277
==========================================
+ Hits 1035 1068 +33
- Misses 588 603 +15
```
| [Impacted Files](https://codecov.io/gh/apache/cordova-ios/pull/327?src=pr&el=tree) | Coverage Δ | |
|---|---|---|
| [...mplates/scripts/cordova/lib/copy-www-build-step.js](https://codecov.io/gh/apache/cordova-ios/pull/327?src=pr&el=tree#diff-YmluL3RlbXBsYXRlcy9zY3JpcHRzL2NvcmRvdmEvbGliL2NvcHktd3d3LWJ1aWxkLXN0ZXAuanM=) | `0% <0%> (ø)` | :arrow_up: |
| [bin/templates/scripts/cordova/lib/clean.js](https://codecov.io/gh/apache/cordova-ios/pull/327?src=pr&el=tree#diff-YmluL3RlbXBsYXRlcy9zY3JpcHRzL2NvcmRvdmEvbGliL2NsZWFuLmpz) | `0% <0%> (ø)` | :arrow_up: |
| [bin/templates/scripts/cordova/lib/prepare.js](https://codecov.io/gh/apache/cordova-ios/pull/327?src=pr&el=tree#diff-YmluL3RlbXBsYXRlcy9zY3JpcHRzL2NvcmRvdmEvbGliL3ByZXBhcmUuanM=) | `84.66% <100%> (+0.06%)` | :arrow_up: |
| [bin/templates/scripts/cordova/lib/PodsJson.js](https://codecov.io/gh/apache/cordova-ios/pull/327?src=pr&el=tree#diff-YmluL3RlbXBsYXRlcy9zY3JpcHRzL2NvcmRvdmEvbGliL1BvZHNKc29uLmpz) | `100% <100%> (ø)` | :arrow_up: |
| [bin/templates/scripts/cordova/lib/run.js](https://codecov.io/gh/apache/cordova-ios/pull/327?src=pr&el=tree#diff-YmluL3RlbXBsYXRlcy9zY3JpcHRzL2NvcmRvdmEvbGliL3J1bi5qcw==) | `25.61% <17.8%> (+3.2%)` | :arrow_up: |
| [bin/templates/scripts/cordova/lib/build.js](https://codecov.io/gh/apache/cordova-ios/pull/327?src=pr&el=tree#diff-YmluL3RlbXBsYXRlcy9zY3JpcHRzL2NvcmRvdmEvbGliL2J1aWxkLmpz) | `38.77% <19.78%> (+1.93%)` | :arrow_up: |
| [bin/templates/scripts/cordova/lib/versions.js](https://codecov.io/gh/apache/cordova-ios/pull/327?src=pr&el=tree#diff-YmluL3RlbXBsYXRlcy9zY3JpcHRzL2NvcmRvdmEvbGliL3ZlcnNpb25zLmpz) | `12.35% <27.58%> (+0.45%)` | :arrow_up: |
| [bin/templates/scripts/cordova/lib/check\_reqs.js](https://codecov.io/gh/apache/cordova-ios/pull/327?src=pr&el=tree#diff-YmluL3RlbXBsYXRlcy9zY3JpcHRzL2NvcmRvdmEvbGliL2NoZWNrX3JlcXMuanM=) | `42.04% <36.11%> (+2.04%)` | :arrow_up: |
| [bin/templates/scripts/cordova/Api.js](https://codecov.io/gh/apache/cordova-ios/pull/327?src=pr&el=tree#diff-YmluL3RlbXBsYXRlcy9zY3JpcHRzL2NvcmRvdmEvQXBpLmpz) | `53.89% <42.85%> (ø)` | :arrow_up: |
| [bin/templates/scripts/cordova/lib/Podfile.js](https://codecov.io/gh/apache/cordova-ios/pull/327?src=pr&el=tree#diff-YmluL3RlbXBsYXRlcy9zY3JpcHRzL2NvcmRvdmEvbGliL1BvZGZpbGUuanM=) | `76.85% <60.41%> (+1.2%)` | :arrow_up: |
| ... and [4 more](https://codecov.io/gh/apache/cordova-ios/pull/327?src=pr&el=tree-more) | |
------
[Continue to review full report at Codecov](https://codecov.io/gh/apache/cordova-ios/pull/327?src=pr&el=continue).
> **Legend** - [Click here to learn more](https://docs.codecov.io/docs/codecov-delta)
> `Δ = absolute <relative> (impact)`, `ø = not affected`, `? = missing data`
> Powered by [Codecov](https://codecov.io/gh/apache/cordova-ios/pull/327?src=pr&el=footer). Last update [26beb94...80f4521](https://codecov.io/gh/apache/cordova-ios/pull/327?src=pr&el=lastupdated). Read the [comment docs](https://docs.codecov.io/docs/pull-request-comments).
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---
---------------------------------------------------------------------
To unsubscribe, e-mail: dev-unsubscribe@cordova.apache.org
For additional commands, e-mail: dev-help@cordova.apache.org
[GitHub] cordova-ios pull request #327: CB-12895: replaced jshint with eslint
Posted by asfgit <gi...@git.apache.org>.
Github user asfgit closed the pull request at:
https://github.com/apache/cordova-ios/pull/327
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---
---------------------------------------------------------------------
To unsubscribe, e-mail: dev-unsubscribe@cordova.apache.org
For additional commands, e-mail: dev-help@cordova.apache.org