You are viewing a plain text version of this content. The canonical link for it is here.
Posted to commits@camel.apache.org by GitBox <gi...@apache.org> on 2022/08/21 21:33:16 UTC
[GitHub] [camel] rhuan080 opened a new pull request, #8192: CAMEL-18131 - Adding health check to test conectivity
rhuan080 opened a new pull request, #8192:
URL: https://github.com/apache/camel/pull/8192
Signed-off-by: Rhuan Rocha <rh...@gmail.com>
- [ ] Make sure there is a [JIRA issue](https://issues.apache.org/jira/browse/CAMEL) filed for the change (usually before you start working on it). Trivial changes like typos do not require a JIRA issue. Your pull request should address just this issue, without pulling in other changes.
- [ ] Each commit in the pull request should have a meaningful subject line and body.
- [ ] If you're unsure, you can format the pull request title like `[CAMEL-XXX] Fixes bug in camel-file component`, where you replace `CAMEL-XXX` with the appropriate JIRA issue.
- [ ] Write a pull request description that is detailed enough to understand what the pull request does, how, and why.
- [ ] Run `mvn clean install -Psourcecheck` in your module with source check enabled to make sure basic checks pass and there are no checkstyle violations. A more thorough check will be performed on your pull request automatically.
Below are the contribution guidelines:
https://github.com/apache/camel/blob/main/CONTRIBUTING.md
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@camel.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [camel] orpiske commented on pull request #8192: CAMEL-18131 - Adding health check to test conectivity
Posted by GitBox <gi...@apache.org>.
orpiske commented on PR #8192:
URL: https://github.com/apache/camel/pull/8192#issuecomment-1231825569
> @davsclaus I have tested it in my local environment and it works fine. I think it is some issue about the environment. Mainly because the issue is in another component that is not related to this update.
In this case, my suggestion is to rebase the code and push it again. That way when the test script generates the diff for the affected components, only the one you changed will be tested.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@camel.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [camel] github-actions[bot] commented on pull request #8192: CAMEL-18131 - Adding health check to test conectivity
Posted by GitBox <gi...@apache.org>.
github-actions[bot] commented on PR #8192:
URL: https://github.com/apache/camel/pull/8192#issuecomment-1228184398
:x: Finished component verification: **1 component(s) test failed** out of 12 component(s) tested
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@camel.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [camel] rhuan080 closed pull request #8192: CAMEL-18131 - Adding health check to test conectivity
Posted by GitBox <gi...@apache.org>.
rhuan080 closed pull request #8192: CAMEL-18131 - Adding health check to test conectivity
URL: https://github.com/apache/camel/pull/8192
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@camel.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [camel] davsclaus commented on pull request #8192: CAMEL-18131 - Adding health check to test conectivity
Posted by GitBox <gi...@apache.org>.
davsclaus commented on PR #8192:
URL: https://github.com/apache/camel/pull/8192#issuecomment-1221974410
Yes we can remove the component verifier which also means it should be removed on the component at
```
registerExtension(new AWS2S3ComponentVerifierExtension());
```
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@camel.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [camel] rhuan080 commented on pull request #8192: CAMEL-18131 - Adding health check to test conectivity
Posted by GitBox <gi...@apache.org>.
rhuan080 commented on PR #8192:
URL: https://github.com/apache/camel/pull/8192#issuecomment-1231737236
@davsclaus I have tested it in my local environment and it works fine. I think it is some issue about the environment. Mainly because the issue is in another component that is not related to this update.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@camel.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [camel] davsclaus commented on pull request #8192: CAMEL-18131 - Adding health check to test conectivity
Posted by GitBox <gi...@apache.org>.
davsclaus commented on PR #8192:
URL: https://github.com/apache/camel/pull/8192#issuecomment-1231559719
The PR keeps failing, wonder what that error is?
Also mind that this essentially makes the S3 component do health-checks with a live check to AWS every time its invoked. Not sure if AWS would rate limit you - meaning that the interval for triggering health checks should be a reasonable (5 or 10s or longer)
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@camel.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [camel] rhuan080 commented on pull request #8192: CAMEL-18131 - Adding health check to test conectivity
Posted by GitBox <gi...@apache.org>.
rhuan080 commented on PR #8192:
URL: https://github.com/apache/camel/pull/8192#issuecomment-1231933417
Hi @orpiske,
Based on the file changed list, the files updated were just about the aws2-s3. Thus, I think I don`t need to rebase it. However, I will do that.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@camel.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [camel] github-actions[bot] commented on pull request #8192: CAMEL-18131 - Adding health check to test conectivity
Posted by GitBox <gi...@apache.org>.
github-actions[bot] commented on PR #8192:
URL: https://github.com/apache/camel/pull/8192#issuecomment-1221624888
:warning: This PR changes Camel components and will be tested automatically.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@camel.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [camel] github-actions[bot] commented on pull request #8192: CAMEL-18131 - Adding health check to test conectivity
Posted by GitBox <gi...@apache.org>.
github-actions[bot] commented on PR #8192:
URL: https://github.com/apache/camel/pull/8192#issuecomment-1221633852
:heavy_check_mark: Finished component verification: 0 component(s) test failed out of **1 component(s) tested**
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@camel.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [camel] oscerd commented on a diff in pull request #8192: CAMEL-18131 - Adding health check to test conectivity
Posted by GitBox <gi...@apache.org>.
oscerd commented on code in PR #8192:
URL: https://github.com/apache/camel/pull/8192#discussion_r951010724
##########
components/camel-aws/camel-aws2-s3/src/main/java/org/apache/camel/component/aws2/s3/AWS2S3ComponentVerifierExtension.java:
##########
@@ -20,14 +20,7 @@
import org.apache.camel.component.extension.verifier.DefaultComponentVerifierExtension;
import org.apache.camel.component.extension.verifier.ResultBuilder;
-import org.apache.camel.component.extension.verifier.ResultErrorBuilder;
import org.apache.camel.component.extension.verifier.ResultErrorHelper;
-import software.amazon.awssdk.auth.credentials.AwsBasicCredentials;
-import software.amazon.awssdk.auth.credentials.StaticCredentialsProvider;
-import software.amazon.awssdk.core.exception.SdkClientException;
-import software.amazon.awssdk.regions.Region;
-import software.amazon.awssdk.services.s3.S3Client;
-import software.amazon.awssdk.services.s3.S3ClientBuilder;
public class AWS2S3ComponentVerifierExtension extends DefaultComponentVerifierExtension {
Review Comment:
I think we could also remove the class
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@camel.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [camel] github-actions[bot] commented on pull request #8192: CAMEL-18131 - Adding health check to test conectivity
Posted by GitBox <gi...@apache.org>.
github-actions[bot] commented on PR #8192:
URL: https://github.com/apache/camel/pull/8192#issuecomment-1225132821
:x: Finished component verification: **1 component(s) test failed** out of 12 component(s) tested
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@camel.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [camel] github-actions[bot] commented on pull request #8192: CAMEL-18131 - Adding health check to test conectivity
Posted by GitBox <gi...@apache.org>.
github-actions[bot] commented on PR #8192:
URL: https://github.com/apache/camel/pull/8192#issuecomment-1231992785
There are too many components to be tested in this PR, components were removed or the code needs a rebase: (17 likely to be tested)
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@camel.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [camel] orpiske commented on pull request #8192: CAMEL-18131 - Adding health check to test conectivity
Posted by GitBox <gi...@apache.org>.
orpiske commented on PR #8192:
URL: https://github.com/apache/camel/pull/8192#issuecomment-1231952219
> Hi @orpiske,
>
> Based on the file changed list, the files updated were just about the aws2-s3. Thus, I think I don`t need to rebase it. However, I will do that.
<img width="550" alt="Screenshot 2022-08-30 at 19 16 51" src="https://user-images.githubusercontent.com/1851560/187502762-2545b958-5d0c-4d56-b50a-73d3857fe34d.png">
Just as a matter of explanation: the `rebase` from upstream syncs your branch with the other changes that had been merged to `upstream/main`. Looking at your branch right, it was 227 commits behind `upstream/main`. When our diff script runs to find out what has changed, it compares the PR changes to `upstream/main`, therefore the greater the distance from main, the more will be tested (and this is why the label bot adds tags for jms, kafka and others even if the PR hasn't changed those).
On a side note: I should probably add this to the contribution guide 🫣
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@camel.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org