You are viewing a plain text version of this content. The canonical link for it is here.
Posted to dev@cordova.apache.org by m1r4ge <gi...@git.apache.org> on 2015/07/13 17:59:21 UTC
[GitHub] cordova-lib pull request: CB-9354 Fix array merging with complex i...
GitHub user m1r4ge opened a pull request:
https://github.com/apache/cordova-lib/pull/256
CB-9354 Fix array merging with complex items
The issue corresponding to this PR [CB-9354](https://issues.apache.org/jira/browse/CB-9354).
You can merge this pull request into a Git repository by running:
$ git pull https://github.com/m1r4ge/cordova-lib fix/plist_array_munge
Alternatively you can review and apply these changes as the patch at:
https://github.com/apache/cordova-lib/pull/256.patch
To close this pull request, make a commit to your master/trunk branch
with (at least) the following in the commit message:
This closes #256
----
commit b3d38a777cef08d751e0a00aa9fbb6f455de2fe4
Author: Svyatoslav Grebenchukov <m1...@gmail.com>
Date: 2015-07-13T15:52:42Z
CB-9354 Fix array merging with complex items
----
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---
---------------------------------------------------------------------
To unsubscribe, e-mail: dev-unsubscribe@cordova.apache.org
For additional commands, e-mail: dev-help@cordova.apache.org
[GitHub] cordova-lib issue #256: CB-9354 Fix array merging with complex items
Posted by revolunet <gi...@git.apache.org>.
Github user revolunet commented on the issue:
https://github.com/apache/cordova-lib/pull/256
thanks \U0001f44d
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---
---------------------------------------------------------------------
To unsubscribe, e-mail: dev-unsubscribe@cordova.apache.org
For additional commands, e-mail: dev-help@cordova.apache.org
[GitHub] cordova-lib pull request: CB-9354 Fix array merging with complex i...
Posted by vladimir-kotikov <gi...@git.apache.org>.
Github user vladimir-kotikov commented on the pull request:
https://github.com/apache/cordova-lib/pull/256#issuecomment-136397624
@m1r4ge, tested and confirm that this works. However, there is already a `nodeEqual` method (see https://github.com/apache/cordova-lib/blob/master/cordova-lib/src/plugman/util/plist-helpers.js#L83), which compares nodes in a more correct way. Consider using it instead of string comparison.
Also please file an Apache ICLA, if possible (http://www.apache.org/dev/new-committers-guide.html#cla). Thanks.
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---
---------------------------------------------------------------------
To unsubscribe, e-mail: dev-unsubscribe@cordova.apache.org
For additional commands, e-mail: dev-help@cordova.apache.org
[GitHub] cordova-lib pull request: CB-9354 Fix array merging with complex i...
Posted by machty <gi...@git.apache.org>.
Github user machty commented on the pull request:
https://github.com/apache/cordova-lib/pull/256#issuecomment-132415681
+1, fixes the issue for me
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---
---------------------------------------------------------------------
To unsubscribe, e-mail: dev-unsubscribe@cordova.apache.org
For additional commands, e-mail: dev-help@cordova.apache.org
[GitHub] cordova-lib pull request: CB-9354 Fix array merging with complex i...
Posted by m1r4ge <gi...@git.apache.org>.
Github user m1r4ge commented on the pull request:
https://github.com/apache/cordova-lib/pull/256#issuecomment-136423739
@vladimir-kotikov It's seemed to me that I tried that method and it didn't work properly. Now everything works fine. Thx for clarifications. I'll file Aache ICLA soon.
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---
---------------------------------------------------------------------
To unsubscribe, e-mail: dev-unsubscribe@cordova.apache.org
For additional commands, e-mail: dev-help@cordova.apache.org
[GitHub] cordova-lib pull request: CB-9354 Fix array merging with complex i...
Posted by vladimir-kotikov <gi...@git.apache.org>.
Github user vladimir-kotikov commented on the pull request:
https://github.com/apache/cordova-lib/pull/256#issuecomment-136734142
his was merged in https://github.com/apache/cordova-lib/commit/b0c196510aa73b3ef0752c78f06e2a99afe04a95. @m1r4ge, could you please close this PR.
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---
---------------------------------------------------------------------
To unsubscribe, e-mail: dev-unsubscribe@cordova.apache.org
For additional commands, e-mail: dev-help@cordova.apache.org
[GitHub] cordova-lib pull request: CB-9354 Fix array merging with complex i...
Posted by psychowico <gi...@git.apache.org>.
Github user psychowico commented on the pull request:
https://github.com/apache/cordova-lib/pull/256#issuecomment-136369156
can you merge this, plz? very annoying bug.
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---
---------------------------------------------------------------------
To unsubscribe, e-mail: dev-unsubscribe@cordova.apache.org
For additional commands, e-mail: dev-help@cordova.apache.org
[GitHub] cordova-lib pull request: CB-9354 Fix array merging with complex i...
Posted by m1r4ge <gi...@git.apache.org>.
Github user m1r4ge commented on the pull request:
https://github.com/apache/cordova-lib/pull/256#issuecomment-136740512
Closed. Thank you Vladimir.
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---
---------------------------------------------------------------------
To unsubscribe, e-mail: dev-unsubscribe@cordova.apache.org
For additional commands, e-mail: dev-help@cordova.apache.org
[GitHub] cordova-lib pull request: CB-9354 Fix array merging with complex i...
Posted by vladimir-kotikov <gi...@git.apache.org>.
Github user vladimir-kotikov commented on the pull request:
https://github.com/apache/cordova-lib/pull/256#issuecomment-143984151
@gregavola, this change has not released yet, so you have to wait for next cordova release.
As an option you could try to clone this repository and link cordova-lib to your existing cordova installation. However this scenario is not supported and may have some negative consequences.
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---
---------------------------------------------------------------------
To unsubscribe, e-mail: dev-unsubscribe@cordova.apache.org
For additional commands, e-mail: dev-help@cordova.apache.org
[GitHub] cordova-lib pull request: CB-9354 Fix array merging with complex i...
Posted by m1r4ge <gi...@git.apache.org>.
Github user m1r4ge closed the pull request at:
https://github.com/apache/cordova-lib/pull/256
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---
---------------------------------------------------------------------
To unsubscribe, e-mail: dev-unsubscribe@cordova.apache.org
For additional commands, e-mail: dev-help@cordova.apache.org
[GitHub] cordova-lib pull request: CB-9354 Fix array merging with complex i...
Posted by gregavola <gi...@git.apache.org>.
Github user gregavola commented on the pull request:
https://github.com/apache/cordova-lib/pull/256#issuecomment-143828977
Sorry to comment here - but how I can update my version of Cordova-Lib to support this change?
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---
---------------------------------------------------------------------
To unsubscribe, e-mail: dev-unsubscribe@cordova.apache.org
For additional commands, e-mail: dev-help@cordova.apache.org
[GitHub] cordova-lib pull request: CB-9354 Fix array merging with complex i...
Posted by KonradFak <gi...@git.apache.org>.
Github user KonradFak commented on the pull request:
https://github.com/apache/cordova-lib/pull/256#issuecomment-136372119
+1, waiting for merge
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---
---------------------------------------------------------------------
To unsubscribe, e-mail: dev-unsubscribe@cordova.apache.org
For additional commands, e-mail: dev-help@cordova.apache.org