You are viewing a plain text version of this content. The canonical link for it is here.
Posted to dev@myfaces.apache.org by "Paul Rivera (JIRA)" <de...@myfaces.apache.org> on 2008/08/18 16:13:45 UTC
[jira] Created: (MYFACES-1907) update
myfaces-archetype-jsfcomponents to use myfaces-builder-plugin
update myfaces-archetype-jsfcomponents to use myfaces-builder-plugin
--------------------------------------------------------------------
Key: MYFACES-1907
URL: https://issues.apache.org/jira/browse/MYFACES-1907
Project: MyFaces Core
Issue Type: Improvement
Reporter: Paul Rivera
Priority: Minor
myfaces-archetype-jsfcomponents needs to be updated to use myfaces-builder-plugin in component authoring instead of the manual process.
--
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.
[jira] Commented: (MYFACES-1907) update
myfaces-archetype-jsfcomponents to use myfaces-builder-plugin
Posted by "Leonardo Uribe (JIRA)" <de...@myfaces.apache.org>.
[ https://issues.apache.org/jira/browse/MYFACES-1907?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=12631998#action_12631998 ]
Leonardo Uribe commented on MYFACES-1907:
-----------------------------------------
The archetype should not have snapshot dependencies with any library. Paul, please test it with myfaces-builder-plugin 1.0.0
> update myfaces-archetype-jsfcomponents to use myfaces-builder-plugin
> --------------------------------------------------------------------
>
> Key: MYFACES-1907
> URL: https://issues.apache.org/jira/browse/MYFACES-1907
> Project: MyFaces Core
> Issue Type: Improvement
> Reporter: Paul Rivera
> Priority: Minor
> Attachments: myfaces-archetype-jsfcomponents-MyFaces12-2.patch, myfaces-jsfcomponents-archetype-MyFaces12.patch, myfaces-jsfcomponents-archetype.patch
>
>
> myfaces-archetype-jsfcomponents needs to be updated to use myfaces-builder-plugin in component authoring instead of the manual process.
--
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.
[jira] Commented: (MYFACES-1907) update
myfaces-archetype-jsfcomponents to use myfaces-builder-plugin
Posted by "Paul Rivera (JIRA)" <de...@myfaces.apache.org>.
[ https://issues.apache.org/jira/browse/MYFACES-1907?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=12632569#action_12632569 ]
Paul Rivera commented on MYFACES-1907:
--------------------------------------
Ok, no problem.
I've removed the dependencies below which are not used in this archetype anymore:
commons-lang
commons-validator
commons-collections
commons-el
commons-codec
I've attached a new patch (myfaces-archetype-jsfcomponents-MyFaces12-4.patch)
> update myfaces-archetype-jsfcomponents to use myfaces-builder-plugin
> --------------------------------------------------------------------
>
> Key: MYFACES-1907
> URL: https://issues.apache.org/jira/browse/MYFACES-1907
> Project: MyFaces Core
> Issue Type: Improvement
> Reporter: Paul Rivera
> Priority: Minor
> Attachments: myfaces-archetype-jsfcomponents-MyFaces12-2.patch, myfaces-archetype-jsfcomponents-MyFaces12-3.patch, myfaces-archetype-jsfcomponents-MyFaces12-4.patch, myfaces-jsfcomponents-archetype-MyFaces12.patch, myfaces-jsfcomponents-archetype.patch
>
>
> myfaces-archetype-jsfcomponents needs to be updated to use myfaces-builder-plugin in component authoring instead of the manual process.
--
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.
[jira] Commented: (MYFACES-1907) update
myfaces-archetype-jsfcomponents to use myfaces-builder-plugin
Posted by "Paul Rivera (JIRA)" <de...@myfaces.apache.org>.
[ https://issues.apache.org/jira/browse/MYFACES-1907?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=12631852#action_12631852 ]
Paul Rivera commented on MYFACES-1907:
--------------------------------------
I've attached a new patch (myfaces-archetype-jsfcomponents-MyFaces12-2.patch).
This patch will now use classes from myfaces commons. I've also noticed that componentClass12.vm and tagClass12.vm are already in myfaces-builder-plugin. So, I didn't include them in the archetype anymore. Although the files below:
tagConverterClass12.vm
tagValidatorClass12.vm
validatorClass12.vm
are not yet in myfaces-builder-plugin. So, I need to include them in the archetype.
Also, tagConverterClass12.vm needs to be fixed to use commons.
i.e.:
from extends org.apache.myfaces.converter.ConverterTag
to extends org.apache.myfaces.commons.converter.ConverterTag
> update myfaces-archetype-jsfcomponents to use myfaces-builder-plugin
> --------------------------------------------------------------------
>
> Key: MYFACES-1907
> URL: https://issues.apache.org/jira/browse/MYFACES-1907
> Project: MyFaces Core
> Issue Type: Improvement
> Reporter: Paul Rivera
> Priority: Minor
> Attachments: myfaces-archetype-jsfcomponents-MyFaces12-2.patch, myfaces-jsfcomponents-archetype-MyFaces12.patch, myfaces-jsfcomponents-archetype.patch
>
>
> myfaces-archetype-jsfcomponents needs to be updated to use myfaces-builder-plugin in component authoring instead of the manual process.
--
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.
[jira] Commented: (MYFACES-1907) update
myfaces-archetype-jsfcomponents to use myfaces-builder-plugin
Posted by "Leonardo Uribe (JIRA)" <de...@myfaces.apache.org>.
[ https://issues.apache.org/jira/browse/MYFACES-1907?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=12631617#action_12631617 ]
Leonardo Uribe commented on MYFACES-1907:
-----------------------------------------
For converters and validators, there should be a dependency to myfaces commons instead to myfaces-impl. Please update a patch with this suggestion, so I can commit the code.
> update myfaces-archetype-jsfcomponents to use myfaces-builder-plugin
> --------------------------------------------------------------------
>
> Key: MYFACES-1907
> URL: https://issues.apache.org/jira/browse/MYFACES-1907
> Project: MyFaces Core
> Issue Type: Improvement
> Reporter: Paul Rivera
> Priority: Minor
> Attachments: myfaces-jsfcomponents-archetype-MyFaces12.patch, myfaces-jsfcomponents-archetype.patch
>
>
> myfaces-archetype-jsfcomponents needs to be updated to use myfaces-builder-plugin in component authoring instead of the manual process.
--
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.
[jira] Commented: (MYFACES-1907) update
myfaces-archetype-jsfcomponents to use myfaces-builder-plugin
Posted by "Paul Rivera (JIRA)" <de...@myfaces.apache.org>.
[ https://issues.apache.org/jira/browse/MYFACES-1907?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=12632081#action_12632081 ]
Paul Rivera commented on MYFACES-1907:
--------------------------------------
Do you mean myfaces-builder-plugin 1.0.1? Version 1.0.0 doesn't seem to exist and it is also not in
http://repo1.maven.org/maven2/org/apache/myfaces/buildtools/myfaces-builder-plugin/
I've attached a new patch (myfaces-archetype-jsfcomponents-MyFaces12-3.patch). This uses myfaces-builder-plugin 1.0.1.
Although, I had to add componentClass12.vm and tagClass12.vm to this archetype since myfaces-builder-plugin 1.0.1 still does not have them in its resources\META-INF folder unlike myfaces-builder-plugin 1.0.2-SNAPSHOT. If these template files are not included, your build will fail.
Maybe we can modify this archetype again when myfaces-builder-plugin 1.0.2 is available.
> update myfaces-archetype-jsfcomponents to use myfaces-builder-plugin
> --------------------------------------------------------------------
>
> Key: MYFACES-1907
> URL: https://issues.apache.org/jira/browse/MYFACES-1907
> Project: MyFaces Core
> Issue Type: Improvement
> Reporter: Paul Rivera
> Priority: Minor
> Attachments: myfaces-archetype-jsfcomponents-MyFaces12-2.patch, myfaces-archetype-jsfcomponents-MyFaces12-3.patch, myfaces-jsfcomponents-archetype-MyFaces12.patch, myfaces-jsfcomponents-archetype.patch
>
>
> myfaces-archetype-jsfcomponents needs to be updated to use myfaces-builder-plugin in component authoring instead of the manual process.
--
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.
[jira] Commented: (MYFACES-1907) update
myfaces-archetype-jsfcomponents to use myfaces-builder-plugin
Posted by "Leonardo Uribe (JIRA)" <de...@myfaces.apache.org>.
[ https://issues.apache.org/jira/browse/MYFACES-1907?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=12632372#action_12632372 ]
Leonardo Uribe commented on MYFACES-1907:
-----------------------------------------
I have checked the patch and works fine. Just one last modification left: there are some unnecessary dependencies (commons-el and others), others retrieved transitively (This code comes from a jsf 1.1 version so it is natural to see those ones). Paul, Could you remove the unused dependencies (or transitive dependencies) from the generated poms please? This is the last thing before commit this patch.
> update myfaces-archetype-jsfcomponents to use myfaces-builder-plugin
> --------------------------------------------------------------------
>
> Key: MYFACES-1907
> URL: https://issues.apache.org/jira/browse/MYFACES-1907
> Project: MyFaces Core
> Issue Type: Improvement
> Reporter: Paul Rivera
> Priority: Minor
> Attachments: myfaces-archetype-jsfcomponents-MyFaces12-2.patch, myfaces-archetype-jsfcomponents-MyFaces12-3.patch, myfaces-jsfcomponents-archetype-MyFaces12.patch, myfaces-jsfcomponents-archetype.patch
>
>
> myfaces-archetype-jsfcomponents needs to be updated to use myfaces-builder-plugin in component authoring instead of the manual process.
--
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.